[RFC 2/2] vduse: allow to specify device-specific features if it's multiclass

Eugenio Pérez
2025-10-02T10:36:02Z

Even if the device supports more than one class, there are ways to solve
the ambiguity of which device are we creating. In the VDUSE case it is
the name, for example.

RFC: I fon't understand 100% the motivation of this limitation, as the
backend should be the one filtering out the invalid features if any.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
drivers/vdpa/vdpa.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 34874beb0152..0fc32f3bd66f 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -688,15 +688,6 @@ static int vdpa_nl_cmd_dev_add_set_doit(struct sk_buff *skb, struct genl_info *i
err = -EINVAL;
goto err;
}
- if (!(config.mask & VDPA_DEV_NET_ATTRS_MASK) &&
- config.mask & BIT_ULL(VDPA_ATTR_DEV_FEATURES) &&
- classes & BIT_ULL(VIRTIO_ID_NET) && ncls > 1 &&
- config.device_features & VIRTIO_DEVICE_F_MASK) {
- NL_SET_ERR_MSG_MOD(info->extack,
- "Management device supports multi-class while device features specified are ambiguous");
- err = -EINVAL;
- goto err;
- }

err = mdev->ops->dev_add(mdev, name, &config);
err:
--
2.51.0