Re: [RFC PATCH 09/15] iommu/vt-d: Add live update freeze callback

Jason Gunthorpe
2025-09-29T15:58:32Z

On Sun, Sep 28, 2025 at 07:06:17PM +0000, Samiullah Khawaja wrote:

> +static int intel_liveupdate_freeze(struct liveupdate_subsystem *handle, u64 *data)
> +{
> + struct iommu_ser *ser = __va(*data);
> +
> + ser->iommu_units_phys = __pa(ser->iommu_units);
> + ser->devices_phys = __pa(ser->devices);

Why didn't this happen at an earlier stage? It makes no sense to some
hacky naked __pa

Jason