From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 819B0148830 for ; Thu, 2 Oct 2025 19:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759431654; cv=none; b=GNYxqcSslbDuG5c5cMLqfmm/sHitK3+SmomOReoi+IGxzxIqSmB4957H0oUS5Myl8l7hU5e6Ri2darQuk9Tr10sQzhNm2SGn9F9g/hs7V3VyVtM9tOd3eyqcWtQ+yGbKapVoIahlVruhleFc4t+rl7qhNFhXCjmycK+6kuCUoRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759431654; c=relaxed/simple; bh=HdRM6QtSEu6oISwiLRqfnMz+LiKeMqQ1/pBIxbMP6TM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lpxjgB/ooPjgztkNHOgB2ZqxxhEJyqw+ngBre9UxHq7VFmwC7odACXGSG4+sjAENAFscKuKdujGCGsYz8TPbrm8Pd4keypKUecclD6MiCr8gPvkggAjXvIOl1hzUxhPx+SsQsk6sqhyLuv3y7Snr8qwp8KU/fpsZaL5KlbtZE/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nd8jOs9L; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nd8jOs9L" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-46e542196c7so14643105e9.0 for ; Thu, 02 Oct 2025 12:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759431651; x=1760036451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=u6fOaFPX2oAXf2qf/MzKaSamzMn6vecX7vKZ+f0WXRk=; b=Nd8jOs9LmfZos29FOCxMlZejNqkZstiaNoGsS2kxj5kRpcHOM9+HMVvBxTapHaZyQ4 01E1MSfcixlF7b/bVw4Bfhz9g4kV7eC5oE6vHs0EK0+9By2NdPXkSi1q7n3WCpMcgHPI B4+iMVq3bVOocKFxp/4UGdwFVFffpWMuvVhKMOo+iLBwMWAaSnYLOQNeRq+k5jjBHCn7 iGalhbV4UVfcGkpgc1g7dixm+w/V2PZwnrYZHlESiFge1X8bo/RF6LCOgTToYh/5NKHY KJJaxh+VJPDdFFmVtIUriBz8TqCbemTUJjhdjtQtDCmtGCM0amGJKo3xPJrVPTYSaWeb ClEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759431651; x=1760036451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u6fOaFPX2oAXf2qf/MzKaSamzMn6vecX7vKZ+f0WXRk=; b=IemL3BVu3sD4FvDI+oPTiwsgOY2sLxOvswvsPPWA15TRCqNMJZ163D/M3ROAwC0oZU xuI19jO4bm/aukddGKzn182nvRvbJLND0AvwPWL9M0AeNMi4VF26fIvr97CjlZR35voD SDODkE6lLlBbetvuy/wOOPPLo/yOoO92f74uogKAKM6DbO4c0z/pA5Yi836FV5tvFH9/ 07UPOKiasNeJtc92/5I8tP0DD2dHhMb1W9k2QXzRElv6gUz+FMjT2nCKIJF9qrVvlkLu mmhD3ZvSbbtihtUpj504iw98d/NZcKPcTzEG6q2Q5BNNpI9feFo0eRZoJiBK6qH1Em3+ v5pw== X-Forwarded-Encrypted: i=1; AJvYcCXFFYpNHDcb2w09EUH1xLlT4NO0IW75gJ97AFw8s3xYHbijO1kZfOz0uPJkIzXf1YEKW1WCS/r7fXYeSb4=@vger.kernel.org X-Gm-Message-State: AOJu0YwpKWRfXjziDNJoQMAfh59HabUJoU0F6RADHoOtNQuOQUUzoOIy lSmFtZWvkrwXD1xRW2MuEBkdci0WRYK0exHSZ/uFIfNWb+WPXy/EjvIL X-Gm-Gg: ASbGncvYKDWOUdYcKn8/50SDiQCwEYnbJzZYqG4E+emeQ7e8zCBbQ4+gN+GUJB1m/++ 4nz6neezWD3dc9yMH/lpZIXAYquiANHGwsXnFkBHIicQ5+o+8AbCvlWnd056oYLAl+sLWUnXPlJ yPYtQPmNg6JB6ixad7iIxVHWD065lE4SE4iV1pp1kB33uVQ7A9c7KT8DdlRIliI0t+7SUF2gEP4 Ix2qSw8h4pvj4n6PNEemUecCU5xrBccaSHx2mG9wQSs4ka1lbyhLT6SR9qILztn4CGOK5TwgdS7 Rg6cRSIo50eLTqwLYQXy/28NbFFs5KDRQHSwZ9I7cZTuLPw64Gp6N+TMt+g+WJxtVGPLZRO9wNI ioMlyQU3cLYoO9mkHI/WmIOk8gGhHKkbW1+riQjPdqVrHwhj1E8DO5twtX8HNie5TiUfhuQD4es tca4q8smZ1TYPH X-Google-Smtp-Source: AGHT+IGaoHiZFJpX7P4fpJ5gN/YctPtIRaA4HuaLp2YmDRoVlK6rbZNidGIsWnYJjI0Td812wrRW+w== X-Received: by 2002:a05:600c:83ca:b0:45d:5c71:769d with SMTP id 5b1f17b1804b1-46e70c5cef4mr4217145e9.8.1759431650257; Thu, 02 Oct 2025 12:00:50 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e6918bb06sm51107905e9.8.2025.10.02.12.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 12:00:49 -0700 (PDT) Date: Thu, 2 Oct 2025 20:00:47 +0100 From: David Laight To: Mehdi Ben Hadj Khelifa Cc: andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, matttbe@kernel.org, martineau@kernel.org, geliang@kernel.org, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, linux@jordanrome.com, ameryhung@gmail.com, toke@redhat.com, houtao1@huawei.com, emil@etsalapatis.com, yatsenko@meta.com, isolodrai@meta.com, a.s.protopopov@gmail.com, dxu@dxuuu.xyz, memxor@gmail.com, vmalik@redhat.com, bigeasy@linutronix.de, tj@kernel.org, gregkh@linuxfoundation.org, paul@paul-moore.com, bboscaccy@linux.microsoft.com, James.Bottomley@HansenPartnership.com, mrpre@163.com, jakub@cloudflare.com, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com Subject: Re: [PATCH] selftests/bpf: Add -Wsign-compare C compilation flag Message-ID: <20251002200047.2b9f9ef9@pumpkin> In-Reply-To: References: <20250924162408.815137-1-mehdi.benhadjkhelifa@gmail.com> <20250926124555.009bfcd6@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 29 Sep 2025 17:03:29 +0100 Mehdi Ben Hadj Khelifa wrote: > On 9/26/25 12:45 PM, David Laight wrote: > > On Wed, 24 Sep 2025 17:23:49 +0100 > > Mehdi Ben Hadj Khelifa wrote: > > > >> -Change all the source files and the corresponding headers > >> to having matching sign comparisons. > > Hi david, > sorry for the late reply. > > > 'Fixing' -Wsign-compare by adding loads of casts doesn't seem right. > > The only real way is to change all the types to unsigned ones. > The last v3 did only do that with no casting as it was suggested by > David too. > > > Consider the following: > > int x = read(fd, buf, len); > > if (x < 0) > > return -1; > > if (x > sizeof (struct fubar)) > > return -1; > > That will generate a 'sign-compare' error, but min(x, sizeof (struct fubar)) > > doesn't generate an error because the compiler knows 'x' isn't negative. > > Yes,-Wsign-compare does add errors with -Werror enabled in that case > and many other cases where the code is perfectly fine which is one of > it's drawbacks. > Also I though that because of GCC/Clang heuristics > sometimes min() suppress the warning not because that the compiler knows > that x isn't negative.I'm probably wrong here. That sentence doesn't make sense. The statically_true() test in min() uses the 'value' tracking done by modern versions of gcc and clang. This means it can let signed types be promoted to unsigned ones because the compiler knows the value isn't negative. OTOH -Wsign-compare is a much older warning and is only based on the types. > > A well known compiler also rejects: > > unsigned char a; > > unsigned int b; > > if (b > a) > > return; > > because 'a' is promoted to 'signed int' before it does the check. > > In my knowledge,compilers don't necessarily reject the above code by > default. Since -Wall in GCC includes -Wsign-compare but -Wall in clang > doesn't, doing -Wall -Werror for clang compiler won't trigger an error > in the case above not even a warning.My changes are to make those > comparisons produce an error since the -Werror flag is already enabled > in the Makefile. This isn't about whether -Wsign-compare is enabled or not (or even what the option is called). It is about whether the compiler's 'sign-compare' warning triggers for that code. The one that detects the warning/error isn't gcc or clang but is probably used far more than clang. > > > So until the compilers start looking at the known domain of the value > > (not just the type) I enabling -Wsign-compare' is pretty pointless. > > I agree that enabling -Wsign-compare is pretty noisy. But it does have > some usefulness. Take for example this code: > int n = -5; > for (unsigned i = 0; i < n; i++) { > // ... > } > Since this is valid code by the compiler, it will allow it but n here is > promoted to an unsigned which converts -5 to being 4294967291 thus > making the loop run more than what was desired.of course,here the > example is much easy to follow and variables are very well set but the > point is that these could cause issues when hidden inside a lot of macro > code. There is plenty of broken code out there. It isn't hard to find places where explicit casts make things worse. The problem is that, even for the above example, the -5 could come from way earlier up the code. If you 'fix' the warning by changing it to 'i < (unsigned)n' the code is still just as likely to be buggy. > > > As a matter of interest did you actually find any bugs? > > No,I have not found any bug related to the current state of code in bpf > selftests but It works as a prevention mechanism for future bugs.Rather > than wait until something breaks in future code. That's what I expected... > > David > > > > Thank you for your time David.I would appreciate if you suggest on how I > can have a useful patch on this or if I should drop this. > Best Regards, > Mehdi > > > >> > >> Signed-off-by: Mehdi Ben Hadj Khelifa > >> --- > >> As suggested by the TODO, -Wsign-compare was added to the C compilation > >> flags for the selftests/bpf/Makefile and all corresponding files in > >> selftests and a single file under tools/lib/bpf/usdt.bpf.h have been > >> carefully changed to account for correct sign comparisons either by > >> explicit casting or changing the variable type.Only local variables > >> and variables which are in limited scope have been changed in cases > >> where it doesn't break the code.Other struct variables or global ones > >> have left untouched to avoid other conflicts and opted to explicit > >> casting in this case.This change will help avoid implicit type > >> conversions and have predictable behavior. > >> > >> I have already compiled all bpf tests with no errors as well as the > >> kernel and have ran all the selftests with no obvious side effects. > >> I would like to know if it's more convinient to have all changes as > >> a single patch like here or if it needs to be divided in some way > >> and sent as a patch series. > >> > >> Best Regards, > >> Mehdi Ben Hadj Khelifa > > ... >