Re: [PATCH v2 11/15] blktrace: add block trace commands for zone operations

Johannes Thumshirn
2025-10-09T11:17:34Z

On 10/8/25 8:14 AM, hch wrote:
> On Tue, Oct 07, 2025 at 01:08:00PM +0000, Johannes Thumshirn wrote:
>> Sure for the old commands everything is still in the lower 32bits, this
>> has the nice property that we don't need to duplicate all the code for
>> v1 and v2.
> I don't think you need to duplicate anything, just have a little
> function that maps from the free-form v2 commands and flags to the
> v1 field. Preferably including a mapping of all unsupported ones to
> a catchall unsupported command and flag each to indicate that the
> trace includes something only visible with v2.

So I've tried making a translation function (which is the trivial part)
but then it's a game of whack-a-mole to unbreak compilation, ftrace, etc..

I think it's not really worth the effort.