From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED0C572631 for ; Fri, 3 Oct 2025 13:25:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759497949; cv=none; b=PqUxNSTNX0Pkh46UjOCpz7MHgxPSJjDu5arbghGqGZ+GASrICWeDtY94RJMyZkR0CrP4yjUyGEeKgT099jnQwJ41WQcuKZ7uM/vvWnGfvwiY7caQR7HaiLViJml4BikcWkd8isyZJ72PpHtSFW+t8svwX2RfQeGVN0q/T9JECGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759497949; c=relaxed/simple; bh=lXoinWuk7LcPByoZgbYxrsiJlpNjzWGndm6j+rSNBHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MQdkL7elOir0DtLHumLQkjZzIXvsMWmOR8IOXSpEBdMt0V3sY462nRN66uS7wFBJ5UxVxwo7qD0jpsJNFmv1Vjm5pFZRwsIuTBji3P+cLFkOAka12G79XieRzZnzw2veIdeiW/wVc1tfJvDyMrM/5apeQtZEyiyv2gg40BMAhV0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P6EeDXA2; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P6EeDXA2" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-28e8c5d64d8so21465465ad.1 for ; Fri, 03 Oct 2025 06:25:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759497947; x=1760102747; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6iGJQ9sNQ8HMQ2w/YdZJV7Y46XjQibOSjc27097Uy4c=; b=P6EeDXA2BNK5kbmVJQs/wGfNf7LUh/MEQ74EtjjOJCOLwi3wPwmr2y1cdjeD702Rg3 BPIWhbY6cQ+PA+YaZ0Pe9msRr0UZxy3TyL30HSSbJkKccZl8yOPx3M5/x1kLg1SyeKuJ PnNfhSDkI4AtOWtuTnkn1bXzjuB/inkhdgpg/kftoPcWwq0qNYo788pL/WUOH8LeaC/I hPHhduZn+cGYHWlJVS/by0gGUScjGafr/PURauIlvaE8SfMMy8OBaBirkjI0AvfD/622 69yi2ckn0jBFkkHS0MeJNkx8KK185ieTtao5px+iXvDB1wZ8kGFbKJnm4FtWo0INFTYf BmoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759497947; x=1760102747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6iGJQ9sNQ8HMQ2w/YdZJV7Y46XjQibOSjc27097Uy4c=; b=TxCyu9x8X3nLmmguCt3TAw4kmWEFgmMgKLyDktH+4vja+XaVmmmoTUeKT/yCMDGklc CoIvEMcL8ziRT/ocC5MQm3H08lUt3YSvxkUHT0wp2lz3U2PYq/8QcLUbX2ETAac+WR5V wXaQU1RGnQYBZaRQmySS/sldcd8FAWw8L6g5QwSw3KGzM+aKyGkSkq7+qqcdzBHJ0LMm WNl8+Eq2/MFQ1XXeI9JaJPPigokonfnTIen3B7ElBLhkbH59G050zdYy0ev9vtosFvsQ pMYvlkH9BW8RoRaWe3Hv0z3vYzOw8M8nQ8hSGbIJO9ea5ewPnaNQzC0YnOjQ7yVfWUX4 /SwA== X-Forwarded-Encrypted: i=1; AJvYcCWntKuYXv7AI785Gwb0AoD+wLtPer/DRqgNs/ZuID9revFjXu8G8+A2qNpoisf/CLX2+80aNp/QWwF9uKE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0BkoeAo2QoBvt1jnTEXCL99ouujG8usfcHbI9MCmfLOj2Bily tEjqXlWTMox+oeci+QgBVjcfjd0Q/HwxyTW50RVtC1FvCkyzIMLWlJu7 X-Gm-Gg: ASbGncu3Qj1yNiZY2JBuNkT343WRj5GqHQYw7tJvL8jhip5Vp1F8M09xDSdb+EPjJto UxTG2CxAB6zQEVCV/myEnHqNtQIDCwMewp2sx3UqsCHMQ/15uWuz4hk+Mgw+NsKmsOX61+Om5ur /adhX0RwDzdWxCVgcBA2dgjnNNmJfMg8cnaQBds1h99JyHBREqTHt1p5IaslguUrgb2QviLjfAL WLhb5kgA8nJSIEgIddzEDTcEcHnmnMO9YgmgRTbveHKFgpjTysa4L2yC0xSO/vryxrJo0oqe2lY C87hcGEnUOOeAaambTAC6cR2JINOuxtgepYUGBivZ8zUnmz0keQMqZhsfuZw9RIf0KWa/TkSTFt Yv7DwJBpG1FXp5UEaRgpRWUTeETP5qLHlcuOGfeeQFu9YnXmYdM5unEiH5tp19Er3FYIr6pYipk XB0J/n3V0GXg== X-Google-Smtp-Source: AGHT+IHiIZWyVFyajM0ujPkWk6tstsfUZUxnpu86ptRRwqj75xBIwN6itlGKR9miAD3w9z4iACTwwQ== X-Received: by 2002:a17:903:3c63:b0:28e:7dd9:5c29 with SMTP id d9443c01a7336-28e9a650f81mr31775805ad.51.1759497947183; Fri, 03 Oct 2025 06:25:47 -0700 (PDT) Received: from fedora ([45.116.149.225]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-28e8d1d5e36sm51069855ad.114.2025.10.03.06.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Oct 2025 06:25:46 -0700 (PDT) From: rtapadia730@gmail.com To: fdmanana@kernel.org Cc: clm@fb.com, david.hunter.linux@gmail.com, dsterba@suse.com, fdmanana@suse.com, khalid@kernel.org, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, rtapadia730@gmail.com, skhan@linuxfoundation.org Subject: Re: [PATCH] btrfs: push memalloc_nofs_save/restore() out of alloc_bitmap() Date: Fri, 3 Oct 2025 18:55:35 +0530 Message-ID: <20251003132535.42760-1-rtapadia730@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thank you for the review and explanation. > We test btrfs with fstests. The sanity tests aren't enough, they are > mostly to test internal functions. > Please don't declare variables in the middle of the code. > We always declare variables at the top of the current scope. Okay I will remember this for future patches. > Just fix the comment, removing the TODO and mention that the reason we > can't recurse is because we are holding a transaction handle open - it > doesn't matter if we are in critical section of a transaction commit > or not - all it matters is that we are holding a transaction handle > open, so a GFP_KERNEL allocation results in a deadlock if it recurses > to the filesystem to commit the transaction. I'll send a v2 patch that just removes TODO and update the comment for clearity.