From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B53243954 for ; Mon, 6 Oct 2025 07:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759734462; cv=none; b=dIrl8T5h4DgVUEK94KUR1J/BMjwbs8L2EvaWseTjWNQs4e0wtUgrK2wjHrkAB0n0SCLGperF0JPwwg7SQ+ydfIsBMMeoXAGii/mvyTTETHYBo8RMgb8DcDglx3batFOAUSomkcK6pcdYSCVavwhgNoHaLGbgOGQgByxUORfdgtQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759734462; c=relaxed/simple; bh=EQOgiGE+g35klH/QbOf0cf+PLrLzO1ZuuCOjx+b7EqU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Idr/XNUnchghE+plwPMtYNPcHzUZi6hntK3cfu9JrruxsE3+niGsikb+CqxkDalqFFxqyiUeKbovgd7B9O+EixudMmVV4WS54myqfgLa5orUV2+AfjejwrJ4UgJhGXn2tDEJdJyOEzhxIHC/o4EKOTEZZrm0hGdvjuBuvjIMWmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=JZ2Yladu; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="JZ2Yladu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1759734459; bh=EQOgiGE+g35klH/QbOf0cf+PLrLzO1ZuuCOjx+b7EqU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JZ2YladuvRsPBBU3RT4tqnwSWb600cQJGTiTxuqtg1sWx8PunjzZef1lb/R2yun1S IEv6jpwI9WQ0Iht2SViUWTe7YNC7kPkidSDWxlceUKWZjn10fhQeB/+H6vSfg9dEfV m8JqvuzZWCu/ZCBijPneuavvFHRIE15pHELuvluTUC96H8kZZI8K/IyB4CMl8wrAZk xW8nU4m9CzGyjyXQZOBQWdbzNraNbynmBIM5A0Ua9q5T+mlBQGBERC7Zm/etJje+c4 vFlnyOoXVHitJmNM9LJNPyu2zTEIkyzLUuLt2MAcdxxye6DfQFXAe4XOy5kJDpYJ3D TlZ/yFhzkNgBg== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 2138217E0AC3; Mon, 6 Oct 2025 09:07:38 +0200 (CEST) Date: Mon, 6 Oct 2025 09:07:30 +0200 From: Boris Brezillon To: =?UTF-8?B?TG/Dr2M=?= Molinari Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Christian Brauner , Nitin Gote , Andi Shyti , Christopher Healy , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH v3 05/10] drm/v3d: Use huge tmpfs mount point helper Message-ID: <20251006090730.364a1713@fedora> In-Reply-To: <20251004093054.21388-6-loic.molinari@collabora.com> References: <20251004093054.21388-1-loic.molinari@collabora.com> <20251004093054.21388-6-loic.molinari@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 4 Oct 2025 11:30:48 +0200 Lo=C3=AFc Molinari wrote: > +static void > +v3d_huge_mnt_init(struct v3d_dev *v3d) > +{ > + int err; > + > + /* > + * By creating our own shmemfs mountpoint, we can pass in > + * mount flags that better match our usecase. However, we > + * only do so on platforms which benefit from it. > + */ > + if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + goto err; > + > + /* The user doesn't want to enable Super Pages */ > + if (!super_pages) > + goto err; > + > + err =3D drm_gem_huge_mnt_create(&v3d->drm, "within_size"); > + if (err && err !=3D -EEXIST) > + goto err; > + > + drm_info(&v3d->drm, "Using Transparent Hugepages\n"); > + > + return; > + > +err: > + drm_notice(&v3d->drm, > + "Transparent Hugepage support is recommended for optimal performanc= e on this platform!\n"); With the changes suggested on patch 3, this can be shrunk a little bit: int err =3D 0; if (super_pages) err =3D drm_gem_huge_mnt_create(&v3d->drm, "within_size"); if (v3d->drm.huge_mnt) drm_info(&v3d->drm, "Using Transparent Hugepages\n"); else if (!err) drm_notice(&v3d->drm, "Transparent Hugepage support is recommended for optimal performance = on this platform!\n"); else drm_warn(&v3d->drm, "Couldn't create THP mount point (err=3D%d)\n", err);