From: Eric Biggers <ebiggers@kernel.org>
To: Joachim Vandersmissen <git@jvdsn.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
David Howells <dhowells@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] lib/crypto: Add FIPS pre-operational self-test for SHA algorithms
Date: Mon, 6 Oct 2025 20:27:06 -0700 [thread overview]
Message-ID: <20251007032706.GB77681@sol> (raw)
In-Reply-To: <38ca063d-521a-4fc4-8398-5e77625533c4@jvdsn.com>
On Mon, Oct 06, 2025 at 10:03:44PM -0500, Joachim Vandersmissen wrote:
> Hi Eric,
>
> It's a very minor change but I suggest not using "pre-operational
> self-test". That term specifically refers to a different type of self-test
> in FIPS 140-3 and it could lead to some confusion here. "cryptographic
> algorithm self-test" may be better (if you want to be formal), or just
> "self-test" or "known-answer test".
>
I don't think that's quite correct. FIPS 140-3 divides self-tests into
two categories, pre-operational (executed unconditionally at start-up
time) and conditional (executed only when conditions are met, such as an
algorithm being used for the first time). This patch chooses the first
option, pre-operational.
We could just call them algorithm self-tests if we don't want to be
specific as to what time they run at, though.
- Eric
next prev parent reply other threads:[~2025-10-07 3:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 17:26 [PATCH] lib/crypto: Add FIPS pre-operational self-test for SHA algorithms Eric Biggers
2025-10-06 23:53 ` Ard Biesheuvel
2025-10-07 1:11 ` Eric Biggers
2025-10-07 17:52 ` Ard Biesheuvel
2025-10-10 23:31 ` Eric Biggers
2025-10-07 3:03 ` Joachim Vandersmissen
2025-10-07 3:27 ` Eric Biggers [this message]
2025-10-07 3:42 ` Joachim Vandersmissen
2025-10-10 18:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007032706.GB77681@sol \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=dhowells@redhat.com \
--cc=git@jvdsn.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox