From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 124BA1F12F8 for ; Tue, 7 Oct 2025 14:35:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759847752; cv=none; b=Ftl9nibS+FCEc3G2dg9Na6qiuzhIYj/5nGYmvKZqZyvyTpQD0O761oy5JK9rS3jmSaFX0wKwxXkntmAkZMw9NENDh3PPlZQ6CijfGgzXEPiihFtv2VXR49euIHyzKV3dRUPHaXk0sxiglWmVBmqTg44MupiD3ngx1WYqvc1ao4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759847752; c=relaxed/simple; bh=ddQMm4wD+700e2ki2lu+CmIm7Je2pKn7ZCgyIA/xbKA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LJHGqx5we5jCfs9sbI1FqcxTgPIp2qbxEhhids8dwmyRIUBdr/TsarmrHVrCKoj8yoPzDr/FONV+yuFiUGg6pT0Gmcy2ZjFwBWMlf1t5ZhaqfxwcE63kEIOdqYBl2X6x1ZfZNnzXVREgsF2WmEdXEsHpx4pKle8wGmMoOM03+Do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hte+npcl; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hte+npcl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759847749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LTHNDfkzPY8gHjn3H8bW45troKESABjUXMGCPbEvS48=; b=Hte+npclV7gRWNBgfg0/u0iFGc3jcdHPoyhwmRG9gzXF7520lf+db6YImQAUYmbDKk4VV0 pYS5+2hXW7yurnXl3ZKDEP+sk7gbC/pqmt7pte8hMckVXehFxDP+AnWs4+zTsg5nqV417a PGAUNnpVDZnYODQ4noQ3kRiN2ui1OZI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-449-sQDi6061MJaa7kcZzJOSkw-1; Tue, 07 Oct 2025 10:35:44 -0400 X-MC-Unique: sQDi6061MJaa7kcZzJOSkw-1 X-Mimecast-MFC-AGG-ID: sQDi6061MJaa7kcZzJOSkw_1759847743 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7BC3E1800581; Tue, 7 Oct 2025 14:35:43 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.227.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 2113F19560A2; Tue, 7 Oct 2025 14:35:40 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 7 Oct 2025 16:34:22 +0200 (CEST) Date: Tue, 7 Oct 2025 16:34:19 +0200 From: Oleg Nesterov To: Christian Brauner Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mateusz Guzik Subject: Re: [GIT PULL 05/12 for v6.18] pidfs Message-ID: <20251007143418.GA12329@redhat.com> References: <20250926-vfs-618-e880cf3b910f@brauner> <20250926-vfs-pidfs-3e8a52b6f08b@brauner> <20251001141812.GA31331@redhat.com> <20251006-liedgut-leiden-f3d51f4242c2@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251006-liedgut-leiden-f3d51f4242c2@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 10/06, Christian Brauner wrote: > > On Wed, Oct 01, 2025 at 04:18:12PM +0200, Oleg Nesterov wrote: > > On 09/26, Christian Brauner wrote: > > > > > > Oleg Nesterov (3): > > > pid: make __task_pid_nr_ns(ns => NULL) safe for zombie callers > > ... > > > gaoxiang17 (1): > > > pid: Add a judgment for ns null in pid_nr_ns > > > > Oh... I already tried to complain twice > > > > https://lore.kernel.org/all/20250819142557.GA11345@redhat.com/ > > https://lore.kernel.org/all/20250901153054.GA5587@redhat.com/ > > > > One of these patches should be reverted. It doesn't really hurt, but it makes > > no sense to check ns != NULL twice. > > Sorry, those somehow got lost. > Do you mind sending me a revert? Thanks, will do. But which one? I am biased, but I'd prefer to revert 006568ab4c5ca2309ceb36 ("pid: Add a judgment for ns null in pid_nr_ns") Mostly because abdfd4948e45c51b1916 ("pid: make __task_pid_nr_ns(ns => NULL) safe for zombie callers") tries to explain why this change makes sense and why it is not easy to avoid ns == NULL. OK? Oleg.