[PATCH v3 14/21] crypto/arm64: polyval - Switch to 'ksimd' scoped guard API

Ard Biesheuvel
2025-10-08T15:47:02Z

Switch to the more abstract 'scoped_ksimd()' API, which will be modified
in a future patch to transparently allocate a kernel mode FP/SIMD state
buffer on the stack, so that kernel mode FP/SIMD code remains
preemptible in principe, but without the memory overhead that adds 528
bytes to the size of struct task_struct.

Reviewed-by: Eric Biggers <ebiggers@kernel.org>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
arch/arm64/crypto/polyval-ce-glue.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/crypto/polyval-ce-glue.c b/arch/arm64/crypto/polyval-ce-glue.c
index c4e653688ea0..51eefbe97885 100644
--- a/arch/arm64/crypto/polyval-ce-glue.c
+++ b/arch/arm64/crypto/polyval-ce-glue.c
@@ -15,7 +15,7 @@
* ARMv8 Crypto Extensions instructions to implement the finite field operations.
*/

-#include <asm/neon.h>
+#include <asm/simd.h>
#include <crypto/internal/hash.h>
#include <crypto/polyval.h>
#include <crypto/utils.h>
@@ -45,16 +45,14 @@ asmlinkage void pmull_polyval_mul(u8 *op1, const u8 *op2);
static void internal_polyval_update(const struct polyval_tfm_ctx *keys,
const u8 *in, size_t nblocks, u8 *accumulator)
{
- kernel_neon_begin();
- pmull_polyval_update(keys, in, nblocks, accumulator);
- kernel_neon_end();
+ scoped_ksimd()
+ pmull_polyval_update(keys, in, nblocks, accumulator);
}

static void internal_polyval_mul(u8 *op1, const u8 *op2)
{
- kernel_neon_begin();
- pmull_polyval_mul(op1, op2);
- kernel_neon_end();
+ scoped_ksimd()
+ pmull_polyval_mul(op1, op2);
}

static int polyval_arm64_setkey(struct crypto_shash *tfm,
--
2.51.0.710.ga91ca5db03-goog