Re: [PATCH v2 6/6] cpufreq/amd-pstate: Add static asserts for EPP indices

Gautham R. Shenoy
2025-10-15T09:11:19Z

Hello Mario,

On Thu, Oct 09, 2025 at 11:17:56AM -0500, Mario Limonciello (AMD) wrote:
> In case a new index is introduced add a static assert to make sure
> that strings and values are updated.
>

Thanks for hardening this part of the code.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/cpufreq/amd-pstate.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index a0f21ac1205af..b3dad7cde46f0 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -110,6 +110,7 @@ enum energy_perf_value_index {
> EPP_INDEX_BALANCE_PERFORMANCE,
> EPP_INDEX_BALANCE_POWERSAVE,
> EPP_INDEX_POWERSAVE,
> + EPP_INDEX_MAX,
> };
>
> static const char * const energy_perf_strings[] = {
> @@ -119,6 +120,7 @@ static const char * const energy_perf_strings[] = {
> [EPP_INDEX_BALANCE_POWERSAVE] = "balance_power",
> [EPP_INDEX_POWERSAVE] = "power",
> };
> +static_assert(ARRAY_SIZE(energy_perf_strings) == EPP_INDEX_MAX);
>
> static unsigned int epp_values[] = {
> [EPP_INDEX_DEFAULT] = 0,
> @@ -127,6 +129,7 @@ static unsigned int epp_values[] = {
> [EPP_INDEX_BALANCE_POWERSAVE] = AMD_CPPC_EPP_BALANCE_POWERSAVE,
> [EPP_INDEX_POWERSAVE] = AMD_CPPC_EPP_POWERSAVE,
> };
> +static_assert(ARRAY_SIZE(epp_values) == EPP_INDEX_MAX);
>
> typedef int (*cppc_mode_transition_fn)(int);
>
> --
> 2.43.0
>

--
Thanks and Regards
gautham.