Re: [PATCH v2 4/6] cpufreq/amd-pstate: Adjust return values in amd_pstate_update_status()

Gautham R. Shenoy
2025-10-15T09:02:19Z

Hello Mario,

On Thu, Oct 09, 2025 at 11:17:54AM -0500, Mario Limonciello (AMD) wrote:
> get_mode_idx_from_str() already checks the upper boundary for a string
> sent. Drop the extra check in amd_pstate_update_status() and pass
> the return code if there is a failure.

Looks good to me. This patch doesn't introduce any behavioural change
since in the absence of a match, get_mode_idx_from_str() returns
-EINVAL, which is what was being returned by
amd_pstate_update_status() previously when @buf contains an invalid
string.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

>
> Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
> ---
> drivers/cpufreq/amd-pstate.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 5feb9f5e3a491..2d2ef53d12447 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1346,9 +1346,8 @@ int amd_pstate_update_status(const char *buf, size_t size)
> return -EINVAL;
>
> mode_idx = get_mode_idx_from_str(buf, size);
> -
> - if (mode_idx < 0 || mode_idx >= AMD_PSTATE_MAX)
> - return -EINVAL;
> + if (mode_idx < 0)
> + return mode_idx;
>
> if (mode_state_machine[cppc_state][mode_idx]) {
> guard(mutex)(&amd_pstate_driver_lock);
> --
> 2.43.0
>

--
Thanks and Regards
gautham.