Re: [PATCH] NFS: Fix state renewals missing after boot

Jeff Layton
2025-10-09T11:50:13Z

On Wed, 2025-10-08 at 17:09 -0600, Joshua Watt wrote:
> From: Joshua Watt <jpewhacker@gmail.com>
>
> Since the last renewal time was initialized to 0 and jiffies start
> counting at -5 minutes, any clients connected in the first 5 minutes
> after a reboot would have their renewal timer set to a very long
> interval. If the connection was idle, this would result in the client
> state timing out on the server and the next call to the server would
> return NFS4ERR_BADSESSION.
>
> Fix this by initializing the last renewal time to the current jiffies
> instead of 0.
>
> Signed-off-by: Joshua Watt <jpewhacker@gmail.com>
> ---
> fs/nfs/client.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 4e3dcc157a83..96cdfeb26a90 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -181,6 +181,7 @@ struct nfs_client *nfs_alloc_client(const struct nfs_client_initdata *cl_init)
> clp->cl_nconnect = cl_init->nconnect;
> clp->cl_max_connect = cl_init->max_connect ? cl_init->max_connect : 1;
> clp->cl_net = get_net_track(cl_init->net, &clp->cl_ns_tracker, GFP_KERNEL);
> + clp->cl_last_renewal = jiffies;
>
> #if IS_ENABLED(CONFIG_NFS_LOCALIO)
> seqlock_init(&clp->cl_boot_lock);

Nice catch!

Reviewed-by: Jeff Layton <jlayton@kernel.org>