From: "Eugenio Pérez" <eperezma@redhat.com>
To: "Michael S . Tsirkin " <mst@redhat.com>
Cc: "Yongji Xie" <xieyongji@bytedance.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
jasowang@redhat.com, "Maxime Coquelin" <mcoqueli@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Cindy Lu" <lulu@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>
Subject: [PATCH v7 5/7] vduse: refactor vdpa_dev_add for goto err handling
Date: Fri, 10 Oct 2025 10:58:25 +0200 [thread overview]
Message-ID: <20251010085827.116958-6-eperezma@redhat.com> (raw)
In-Reply-To: <20251010085827.116958-1-eperezma@redhat.com>
Next patches introduce more error paths in this function. Refactor it
so they can be accomodated through gotos.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
v6: New in v6.
---
drivers/vdpa/vdpa_user/vduse_dev.c | 22 ++++++++++++++--------
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c
index 923330da9bef..0ce7f40b84fa 100644
--- a/drivers/vdpa/vdpa_user/vduse_dev.c
+++ b/drivers/vdpa/vdpa_user/vduse_dev.c
@@ -2173,21 +2173,27 @@ static int vdpa_dev_add(struct vdpa_mgmt_dev *mdev, const char *name,
dev->bounce_size);
write_unlock(&dev->domain_lock);
if (!dev->domain) {
- put_device(&dev->vdev->vdpa.dev);
- return -ENOMEM;
+ ret = -ENOMEM;
+ goto domain_err;
}
ret = _vdpa_register_device(&dev->vdev->vdpa, dev->vq_num);
if (ret) {
- put_device(&dev->vdev->vdpa.dev);
- write_lock(&dev->domain_lock);
- vduse_domain_destroy(dev->domain);
- dev->domain = NULL;
- write_unlock(&dev->domain_lock);
- return ret;
+ goto register_err;
}
return 0;
+
+register_err:
+ write_lock(&dev->domain_lock);
+ vduse_domain_destroy(dev->domain);
+ dev->domain = NULL;
+ write_unlock(&dev->domain_lock);
+
+domain_err:
+ put_device(&dev->vdev->vdpa.dev);
+
+ return ret;
}
static void vdpa_dev_del(struct vdpa_mgmt_dev *mdev, struct vdpa_device *dev)
--
2.51.0
next prev parent reply other threads:[~2025-10-10 8:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 8:58 [PATCH v7 0/7] Add multiple address spaces support to VDUSE Eugenio Pérez
2025-10-10 8:58 ` [PATCH v7 1/7] vduse: make domain_lock an rwlock Eugenio Pérez
2025-10-10 12:34 ` Michael S. Tsirkin
2025-10-17 6:32 ` Eugenio Perez Martin
2025-10-23 8:59 ` Eugenio Perez Martin
2025-10-27 16:57 ` Michael S. Tsirkin
2025-10-10 8:58 ` [PATCH v7 2/7] vduse: add v1 API definition Eugenio Pérez
2025-10-11 5:21 ` Jason Wang
2025-10-10 8:58 ` [PATCH v7 3/7] vduse: add vq group support Eugenio Pérez
2025-10-11 5:22 ` Jason Wang
2025-10-10 8:58 ` [PATCH v7 4/7] vduse: return internal vq group struct as map token Eugenio Pérez
2025-10-11 5:22 ` Jason Wang
2025-10-10 8:58 ` Eugenio Pérez [this message]
2025-10-11 5:23 ` [PATCH v7 5/7] vduse: refactor vdpa_dev_add for goto err handling Jason Wang
2025-10-10 8:58 ` [PATCH v7 6/7] vduse: add vq group asid support Eugenio Pérez
2025-10-11 5:23 ` Jason Wang
2025-10-10 8:58 ` [PATCH v7 7/7] vduse: bump version number Eugenio Pérez
2025-10-11 5:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010085827.116958-6-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mcoqueli@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox