From: Aaron Tomlin <atomlin@atomlin.com>
To: gregkh@linuxfoundation.org, nathan@kernel.org, rafael@kernel.org,
dakr@kernel.org
Cc: riel@surriel.com, frederic@kernel.org, atomlin@atomlin.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/2] sysfs/cpu: Use DEVICE_ATTR_RO for nohz_full attribute
Date: Fri, 10 Oct 2025 21:18:29 -0400 [thread overview]
Message-ID: <20251011011830.6670-2-atomlin@atomlin.com> (raw)
In-Reply-To: <20251011011830.6670-1-atomlin@atomlin.com>
The /sys/devices/system/cpu/nohz_full file is a read-only attribute that
reports the CPUs configured for tickless operation (CONFIG_NO_HZ_FULL=y).
The current definition uses the generic DEVICE_ATTR macro, which
unnecessarily requires specifying the file mode (0444) and a NULL
store operation pointer.
This patch converts the definition to use the dedicated DEVICE_ATTR_RO
macro. This correctly expresses the read-only nature of the attribute,
removes the redundant mode field, and simplifies the code. As a related
cleanup, rename the show function from print_cpus_nohz_full() to the
standard nohz_full_show() for consistency with common sysfs attribute
naming conventions.
Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
---
drivers/base/cpu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index fa0a2eef93ac..c792ec66462d 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -301,12 +301,13 @@ static ssize_t print_cpus_isolated(struct device *dev,
static DEVICE_ATTR(isolated, 0444, print_cpus_isolated, NULL);
#ifdef CONFIG_NO_HZ_FULL
-static ssize_t print_cpus_nohz_full(struct device *dev,
- struct device_attribute *attr, char *buf)
+static ssize_t nohz_full_show(struct device *dev,
+ struct device_attribute *attr,
+ char *buf)
{
return sysfs_emit(buf, "%*pbl\n", cpumask_pr_args(tick_nohz_full_mask));
}
-static DEVICE_ATTR(nohz_full, 0444, print_cpus_nohz_full, NULL);
+static DEVICE_ATTR_RO(nohz_full);
#endif
#ifdef CONFIG_CRASH_HOTPLUG
--
2.49.0
next prev parent reply other threads:[~2025-10-11 1:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 1:18 [PATCH v3 0/2] tick/nohz: avoid showing '(null)' if nohz_full= not set Aaron Tomlin
2025-10-11 1:18 ` Aaron Tomlin [this message]
2025-10-11 1:18 ` [PATCH v3 2/2] " Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251011011830.6670-2-atomlin@atomlin.com \
--to=atomlin@atomlin.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=rafael@kernel.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox