RE: [PATCH v2 0/2] firmware: arm_scmi/imx: Support dump syslog

Peng Fan
2025-10-20T10:41:49Z

Hi Sudeep, Cristian and all.

> Subject: [PATCH v2 0/2] firmware: arm_scmi/imx: Support dump
> syslog

There a minor build warning that I missed to remove an unused
variable in patch 2. I am thinking to post v3 with that warning fixed
in the end of this week or early next week.

Thanks,
Peng.

>
> This is the patch 5 and 6 from patchset [1] with switching to using raw
> dump, per check with Sudeep and NXP i.MX SM firmware owner
>
> System Manager firmware provides API to dump system log
> information.
> So add the interface for Linux to retrieve the information.
>
> In patch 1, I drop the two structures compared to patch 5 in [1]:
> struct scmi_imx_misc_sys_sleep_rec
> struct scmi_imx_misc_syslog
> No other changes in this patch.
>
> In patch 2, I switched to use debugfs to do raw dump the syslog,
> compared with patch 6 in [1].
>
> [1] https://lore.kernel.org/arm-
> scmi/PAXPR04MB845937237E3C1AF5A2ABA8FA880CA@PAXPR04MB
> 8459.eurprd04.prod.outlook.com/T/#m6ed303ac9c584c6e2ab39f893
> 59f3131b
> dfcc9e5
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Changes in v2:
> - Rebased to next-20251010
> - Patch 2: Remove the IS_ERR check for debugfs_create_dir per Dan
> Carpenter
> Change 'return 0' to 'return devm_add_action_or_reset'
> Drop the size check
> Include 'linux/sizes.h' to avoid build break
> - Link to v1: https://lore.kernel.org/r/20250910-sm-syslog-v1-0-
> 5b36f8f21da6@nxp.com
>
> ---
> Peng Fan (2):
> firmware: arm_scmi: imx: Support getting syslog of MISC protocol
> firmware: imx: sm-misc: Dump syslog info
>
> .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 83
> ++++++++++++++++++++++
> drivers/firmware/imx/sm-misc.c | 38 +++++++++-
> include/linux/scmi_imx_protocol.h | 2 +
> 3 files changed, 122 insertions(+), 1 deletion(-)
> ---
> base-commit: 2b763d4652393c90eaa771a5164502ec9dd965ae
> change-id: 20251011-sm-syslog-v2-1-51c0da2fe1d0
>
> Best regards,
> --
> Peng Fan <peng.fan@nxp.com>