public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <wbg@kernel.org>
To: Mark Cave-Ayland <mark.caveayland@nutanix.com>
Cc: William Breathitt Gray <wbg@kernel.org>,
	linus.walleij@linaro.org, brgl@bgdev.pl,
	andriy.shevchenko@linux.intel.com, mwalle@kernel.org,
	broonie@kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: gpio: gpio-pci-idio-16 regression after LTS upgrade
Date: Sun, 12 Oct 2025 23:22:14 +0900	[thread overview]
Message-ID: <20251012142216.72248-1-wbg@kernel.org> (raw)
In-Reply-To: <9b0375fd-235f-4ee1-a7fa-daca296ef6bf@nutanix.com>

On Mon, Oct 06, 2025 at 09:37:14AM +0100, Mark Cave-Ayland wrote:
> After some more debugging I was able to determine that the failure was
> due to the regmap cache failing initialisation in
> drivers/base/regmap/regcache-flat.c::regcache_flat_init() because
> max_register wasn't set on the regmap. I was able to fix that fairly
> easily with this:
> 
> 
> diff --git a/drivers/gpio/gpio-pci-idio-16.c
> b/drivers/gpio/gpio-pci-idio-16.c
> index 44c0a21b1d1d..55be571b5cca 100644
> --- a/drivers/gpio/gpio-pci-idio-16.c
> +++ b/drivers/gpio/gpio-pci-idio-16.c
> @@ -41,6 +41,7 @@ static const struct regmap_config
> idio_16_regmap_config = {
>          .reg_stride = 1,
>          .val_bits = 8,
>          .io_port = true,
> +  .max_register = 0x7,
>          .wr_table = &idio_16_wr_table,
>          .rd_table = &idio_16_rd_table,
>          .volatile_table = &idio_16_rd_table,

This particular failure is separate from the get_direction issue
discovered after. It would be good to have this fix as its own patch so
we can keep each solution dedicated to their respective failures and
streamline any necessary backports to the stable trees.

I have some travel scheduled in the next couple days, but I can
probably get a patch series addressing both issues ready by the end of
the week. I'll also CC the stable mailing list so we can get the fixes
picked up for the LTS kernel they are affecting.

William Breathitt Gray

  parent reply	other threads:[~2025-10-12 14:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-06  8:37 gpio: gpio-pci-idio-16 regression after LTS upgrade Mark Cave-Ayland
2025-10-07  8:16 ` William Breathitt Gray
2025-10-09  9:05   ` Mark Cave-Ayland
2025-10-09  9:49     ` William Breathitt Gray
2025-10-14  9:03       ` Michael Walle
2025-10-14 11:21         ` Ioana Ciornei
2025-10-14 11:25           ` Michael Walle
2025-10-14 11:40             ` Ioana Ciornei
2025-10-12 14:22 ` William Breathitt Gray [this message]
2025-10-13 10:32   ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251012142216.72248-1-wbg@kernel.org \
    --to=wbg@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.caveayland@nutanix.com \
    --cc=mwalle@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox