From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77BFC30F53D for ; Tue, 14 Oct 2025 08:39:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760431189; cv=none; b=So7RGP3/9kDDwY82nL6vOyn3DyzDovsV2UlJua/zqnLc7UOLkqJ+0LlFBrrafUBnBT3DiqMdaFPW56bGUXwQ5yv8KaFq6DswAbbE6NMtlav+ooQY4xThp4Q5ykBqEBBoVtpV2qA644djcDoD5ZEuVNnscPu4DnmhPfrveHbcBfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760431189; c=relaxed/simple; bh=hoQgCpk0WoxOoFSs/WuXrmbPtqn324Nd1OaXF4bX8iw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=mECtvJ6LyYaqrOiyV4OuXLhAYVjsfCqzoPRrgvxt7LGhltUUX6XekL3xI3i95izP9tine0PCUwb4qgJRJKo7ouXk4rEzmSOHKrTXIy0BcBJFD1DpnHCsmNFdhlsID09bjqSBNYkT1/0RiabD0QzXvcctxsKD/c8ZMpHHtPX69KQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SKiWRSTq; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SKiWRSTq" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-3ee13baf2e1so3658479f8f.3 for ; Tue, 14 Oct 2025 01:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760431186; x=1761035986; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YFWOuvnUfMwybXOtMoOd4svMVvGqzTx63g0iMz9e+aA=; b=SKiWRSTq7uaM8DykeikPzuVJd68LbyzZVKqyB1S3hWokRr/lSUzFBapG2OCVdy2jfv 487LmatTnJVEw8P4xOm5mHknSy0z5Ay6Pr6jmo3sG1wv/UD70iUhuctAE8ZY/U60M4AE dTnwDh1gSogKBKQYrVB0yD2FFDbshsr+6Uj3m5Jnlwq0QEGCOD2gM2fFW2w51Mi8f145 y3IoXACjQu+Et5shll3mPOtAI/AX1ZL1GXys2/alU/xAd+hu6xFTWgXa5K/2G1sKiqhN pYX333D0nNggtfRY05b4rutdjkFRbtSprIL3ognbfokMXCgpS31GFYtwBOAWzGvjDgOj EA3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760431186; x=1761035986; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YFWOuvnUfMwybXOtMoOd4svMVvGqzTx63g0iMz9e+aA=; b=Tk6Uet3CS80gnPZkG8n5yNBVMTP9J/0zxZFXVvX4xpPTKyjC6ekG1p6+kxdb9KTZye kOBme29Ox2DyI/jo0GcA1t9oHD++OCk3bE7pnUwEGbN7mlESsMHcbhYGMnjC0UID2Pzh gxkrTEtOk1HL3/kifkx/icvPvsLLT6n+33AD+5SPdQ1hTNEF0iKPoUV60cuPSF+TDsGq fewcL1rjb2IWhacu5cARcqP9PqYpQHFrp6qqxt00jPWw16s17MYQiwih5+QzcWhYIlQD 7ZGF6G1Lf8Zh8VHLYQbTa1mwQwv7Jnu/yz310p/kjaV8lLycqd7FHBZQjKEFVzMzWDY6 Iqdw== X-Forwarded-Encrypted: i=1; AJvYcCV0KEzZE3KY6aUBD/Qrw8wZnIoqQiqDgp7vcfbGlTmuC4XY4tOI/QUaHEU0Nn5tOfShA2M4sJgSgpTBq/A=@vger.kernel.org X-Gm-Message-State: AOJu0YxaA7b5LDHC40yv9+oOhS4Od9RbNjdFupaGuWpQuCtOGa++j0pB m7m1S+5Afm2lSaOMguGKiEdzjSFEtu3e0FfipOefeBi1YrkrCU7Hi3uIsE4lJyd22Mo= X-Gm-Gg: ASbGnctHYzgGPja+xZnhfibZlo8x7IxnMpDQgsR9AnsMIelyLE8xNE2qcE0cYMZ73Is jt1hc+8Pa67/0eq9l9Bjysy32fY7pJMAR7XdOe3Fy+7lfFrsFAFR5qBa702hLXxxZpyb8sZkjYw 30wpEUGx37J9DQ2elNGLvTufJnBuV8KWiB6a8Da8SKbfdB4/AkgHelpCM9eBcmTd7FbQU2uCzbw BOyIQrWgI34TLY3/KVmUPfppPLfTI/8+0isHb7wSwvYfkS9lWTEWj80r9MySdFModKULSCuOgZ4 8Pg0fJi/XXFWPWftCxm5UtEZnVloOn3Eoz2dSNv6k4uuJ7tiFU/f2p5fePkTReOFGVarlwNqJIk DB0qX3vGp5sp13KimmF/cOxT6ny4FCqU2mgApQIQgXlzi6Q1MooMuSsd5Dq6IlQ== X-Google-Smtp-Source: AGHT+IFDjuNxGsj9w5KIK44evH4nW82BXa1kd591GncY0F3Cb/1CX97GoQ+hu6emUu0ZcgJJ0c1fpA== X-Received: by 2002:a05:6000:40da:b0:3f8:8aa7:465d with SMTP id ffacd0b85a97d-4266e7d4580mr13949163f8f.30.1760431185690; Tue, 14 Oct 2025 01:39:45 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-426ce5e8a06sm22476317f8f.55.2025.10.14.01.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 01:39:45 -0700 (PDT) Date: Tue, 14 Oct 2025 11:39:41 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Peng Fan , Bjorn Andersson , Mathieu Poirier , Andrew Davis , Arnaud Pouliquen , Daniel Baluta , Maxime Coquelin , Alexandre Torgue Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Peng Fan Subject: Re: [PATCH v2 4/7] remoteproc: core: Use cleanup.h macros to simplify lock handling Message-ID: <202510121908.7aduLIkw-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251010-remoteproc-cleanup-v2-4-7cecf1bfd81c@nxp.com> Hi Peng, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Peng-Fan/remoteproc-core-Drop-redundant-initialization-of-ret-in-rproc_shutdown/20251010-202737 base: 3b9b1f8df454caa453c7fb07689064edb2eda90a patch link: https://lore.kernel.org/r/20251010-remoteproc-cleanup-v2-4-7cecf1bfd81c%40nxp.com patch subject: [PATCH v2 4/7] remoteproc: core: Use cleanup.h macros to simplify lock handling config: i386-randconfig-141-20251012 (https://download.01.org/0day-ci/archive/20251012/202510121908.7aduLIkw-lkp@intel.com/config) compiler: gcc-14 (Debian 14.2.0-19) 14.2.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202510121908.7aduLIkw-lkp@intel.com/ smatch warnings: drivers/remoteproc/remoteproc_core.c:1841 rproc_trigger_recovery() warn: missing error code? 'ret' drivers/remoteproc/remoteproc_core.c:1993 rproc_shutdown() warn: missing error code? 'ret' vim +/ret +1841 drivers/remoteproc/remoteproc_core.c 70b85ef83ce3523 Fernando Guzman Lugo 2012-08-30 1829 int rproc_trigger_recovery(struct rproc *rproc) 70b85ef83ce3523 Fernando Guzman Lugo 2012-08-30 1830 { 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1831 struct device *dev = &rproc->dev; 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1832 int ret; 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1833 c42baf6f84c7694 Peng Fan 2025-10-10 1834 ACQUIRE(mutex_intr, lock)(&rproc->lock); c42baf6f84c7694 Peng Fan 2025-10-10 1835 ret = ACQUIRE_ERR(mutex_intr, &lock); 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1836 if (ret) 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1837 return ret; 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1838 0b145574b6cd2b3 Alex Elder 2020-02-28 1839 /* State could have changed before we got the mutex */ 0b145574b6cd2b3 Alex Elder 2020-02-28 1840 if (rproc->state != RPROC_CRASHED) c42baf6f84c7694 Peng Fan 2025-10-10 @1841 return ret; Please change this to either "return 0;" or "return -ERRORCODE;" 0b145574b6cd2b3 Alex Elder 2020-02-28 1842 0b145574b6cd2b3 Alex Elder 2020-02-28 1843 dev_err(dev, "recovering %s\n", rproc->name); 0b145574b6cd2b3 Alex Elder 2020-02-28 1844 ba194232edc032b Peng Fan 2022-09-28 1845 if (rproc_has_feature(rproc, RPROC_FEAT_ATTACH_ON_RECOVERY)) ba194232edc032b Peng Fan 2022-09-28 1846 ret = rproc_attach_recovery(rproc); ba194232edc032b Peng Fan 2022-09-28 1847 else ba194232edc032b Peng Fan 2022-09-28 1848 ret = rproc_boot_recovery(rproc); 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1849 7e83cab824a8670 Sarangdhar Joshi 2017-05-26 1850 return ret; 70b85ef83ce3523 Fernando Guzman Lugo 2012-08-30 1851 } [ snip ] c13b780c4597e1e Suman Anna 2022-02-13 1976 int rproc_shutdown(struct rproc *rproc) 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1977 { b5ab5e24e960b9f Ohad Ben-Cohen 2012-05-30 1978 struct device *dev = &rproc->dev; ee3d85da617a065 Peng Fan 2025-10-10 1979 int ret; 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1980 c42baf6f84c7694 Peng Fan 2025-10-10 1981 ACQUIRE(mutex_intr, lock)(&rproc->lock); c42baf6f84c7694 Peng Fan 2025-10-10 1982 ret = ACQUIRE_ERR(mutex_intr, &lock); 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1983 if (ret) { 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1984 dev_err(dev, "can't lock rproc %s: %d\n", rproc->name, ret); c13b780c4597e1e Suman Anna 2022-02-13 1985 return ret; 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1986 } 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1987 c42baf6f84c7694 Peng Fan 2025-10-10 1988 if (rproc->state != RPROC_RUNNING && rproc->state != RPROC_ATTACHED) c42baf6f84c7694 Peng Fan 2025-10-10 1989 return -EINVAL; 5e6a0e05270e3a4 Shengjiu Wang 2022-03-28 1990 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1991 /* if the remote proc is still needed, bail out */ 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1992 if (!atomic_dec_and_test(&rproc->power)) c42baf6f84c7694 Peng Fan 2025-10-10 @1993 return ret; Same. 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1994 fcd58037f28bf70 Arnaud Pouliquen 2018-04-10 1995 ret = rproc_stop(rproc, false); 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1996 if (ret) { 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1997 atomic_inc(&rproc->power); c42baf6f84c7694 Peng Fan 2025-10-10 1998 return ret; 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 1999 } 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2000 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2001 /* clean up all acquired resources */ 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2002 rproc_resource_cleanup(rproc); 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2003 33467ac3c8dc805 Loic Pallardy 2020-04-16 2004 /* release HW resources if needed */ 33467ac3c8dc805 Loic Pallardy 2020-04-16 2005 rproc_unprepare_device(rproc); 33467ac3c8dc805 Loic Pallardy 2020-04-16 2006 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2007 rproc_disable_iommu(rproc); 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2008 988d204cdaf604c Bjorn Andersson 2016-08-11 2009 /* Free the copy of the resource table */ a0c10687ec9506b Bjorn Andersson 2016-12-30 2010 kfree(rproc->cached_table); a0c10687ec9506b Bjorn Andersson 2016-12-30 2011 rproc->cached_table = NULL; 988d204cdaf604c Bjorn Andersson 2016-08-11 2012 rproc->table_ptr = NULL; c42baf6f84c7694 Peng Fan 2025-10-10 2013 c13b780c4597e1e Suman Anna 2022-02-13 2014 return ret; 400e64df6b237eb Ohad Ben-Cohen 2011-10-20 2015 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki