From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B10E0264A8D for ; Tue, 14 Oct 2025 05:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760419146; cv=none; b=uVcrtL2GEwuXZXdZG6SwfGlEvvEsjg+omlD69WZLw+5BWhSUe4f395NKr/ukNdAmpGfn3ZTO061LlIjv1N4j/vlXU13EyFSl2/I4dvnHPqaS4qDnpCBZMZlI0sgDmBQSqkJHj2sJ1C6CuQUCshtRkPM8TqQmfYO/eCVy051mBNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760419146; c=relaxed/simple; bh=0891Evs5lqD54TbgKetbZhn/3ldOwvcF7ftrNN99I78=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gX8RDJR/VDXTznDNCVrC8pWUk5kXQSHbQXUTcCm6fVLe8xxxNS43u59wrdr2zPYQYDnjZ4oTzc9JBrawoBruy6lPTh24D6y50561ijVS8Ega/Vq/SQ6cuDVgoY8pHQjeGnKQ129CZ94hs2OX/V1ZPoVpQs5JeDR9+3aP8FG4TSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qdkbjjxh; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qdkbjjxh" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2907ba47f71so2849895ad.3 for ; Mon, 13 Oct 2025 22:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760419144; x=1761023944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MS5ghyNqywnKYwR1bU0C0clme92ktuteU3RH8OfSvOI=; b=QdkbjjxhdW4ZmN8gxnQQbO/cQj4D0WY4LXASd61YIkENfjTXuSUAO8QghELRXDU1hz kR3FlzWIc1q5NY01QC9QpJ5G/NPih3QJe+AhCHj/jq5zER2bdJw0nAjW2I6A/6xuKrn9 DFQIaWLBR3HqTHpYxTmOvangy+LecEfkssa6eXPIeBkFwP3GL+5csLMimZeSQCbR6tsM rd19r8vW00odjbdD4yed1yQobrtzgdGqe39BjjqQ6+d2Z06uARSY+Y/Oxwu0vzsmIxiH UWxMh4gaValILSG4DaNEpgfwkpFZOTkFWTdwKmnTsH2fQXaRyzsRVS8VQGQn9xRkEZ/f 5RAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760419144; x=1761023944; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MS5ghyNqywnKYwR1bU0C0clme92ktuteU3RH8OfSvOI=; b=UY8bKtztQPwgA9UYkK5D70oPZlDG+SxPGCfobqKMb4Y8fk/RgW6cGbS7+VvjfyPTY6 vLlR2WP5iNZTqzAgND9LeDYE76rK4WQol8EM5beI23hrppa0juHdlJQlviE4AM7bFDFG 0UKnGbwRz6YkavUGJblLWdm/SMTkZGCBUbxciYdbd8TmUXFLBC8DSLq6COFyV4bE8ziD TMf4CwqEV1yl4PNSymRe7s6mZ2kBFo8tJQCxwrCfK/4x3RsoKGMM+SX5mTkdWvHUf7up fdz07L3VXJsUHhwJ1XvZo1CCcIyvXTbVQ7XdzFQHuiazkUSvvLfL7cRXmh471oUD854/ u+oA== X-Forwarded-Encrypted: i=1; AJvYcCUeQbHlu8Cu8Yktfe13GHyXz2nY9LjtEKywDe+zOtAaZtwyp+UGw5WSdTgt9z2TIbzaDiEWvgx7kZTfyKY=@vger.kernel.org X-Gm-Message-State: AOJu0YzRoA8FM9i31ubb35i6+BiGpCf3DowAEFES8AKIrkT1TE/ae+XV m8Lp13zejWMQUh2O/r/bmOUYXKvG1lOZpy65a1HnFKVtHNT7qGFtu57u X-Gm-Gg: ASbGncuP/PTaH5Yy2fBQUo+E3w10/ffDilABEUK1KaUWnJixMLw99/pTCs8IgQIIsJ0 EwLua3SZXK7PIkmwAQpQRfpBR1ol7T8Akw0cIZ7k6BnDHNGqBPZ1+Em0khIj3TWYF3YXWIlN6jd nMek/f77Ot5HJuT+/MuGxEIO8UWFNtCU4FNJNu2+n97sQjpw/yVimJxiSuP8U2rdtlYnm76jlYm I1x3oG4/BhZH/WiSAOevzKQzYa9zYZxyqu1SToYhemBZ936UWEnr+AoueCfr3EqJAav2Yl6q0Ic PGDjg02Hm4JuR8YHDe74e9zVXJvO2g4Y9DN47J5BkJszjviCP8QA1c28+B0yoNQO3RnNRzwNKhH kSBD4aln66uYphwtGRFv+W205+dOg3WCjUhf/2WpD2vj14Xf8WA== X-Google-Smtp-Source: AGHT+IHpU6mGXZfoT5qQhUchdAk9g8Q+a7l0nInuSHiJEbwP4Nc8pJjP1AfMYRqiNiWA/AF+l9MMYg== X-Received: by 2002:a17:902:ef11:b0:251:5900:9803 with SMTP id d9443c01a7336-2902723b876mr300456215ad.21.1760419143758; Mon, 13 Oct 2025 22:19:03 -0700 (PDT) Received: from fedora ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29034f08d0fsm151575385ad.63.2025.10.13.22.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 22:19:03 -0700 (PDT) From: Wilfred Mallawa To: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , John Fastabend , Sabrina Dubroca , Shuah Khan , Wilfred Mallawa Subject: [PATCH net-next v5 2/2] selftests: tls: add tls record_size_limit test Date: Tue, 14 Oct 2025 15:18:27 +1000 Message-ID: <20251014051825.1084403-4-wilfred.opensource@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251014051825.1084403-2-wilfred.opensource@gmail.com> References: <20251014051825.1084403-2-wilfred.opensource@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wilfred Mallawa Test that outgoing plaintext records respect the tls TLS_TX_MAX_PAYLOAD_LEN set using setsockopt(). The limit is set to be 128, thus, in all received records, the plaintext must not exceed this amount. Also test that setting a new record size limit whilst a pending open record exists is handled correctly by discarding the request. Suggested-by: Sabrina Dubroca Signed-off-by: Wilfred Mallawa --- Changes V4 -> V5: - Cleanup unused variables - Use ASSERT_EQ more aptly V4: https://lore.kernel.org/netdev/20250923053207.113938-2-wilfred.opensource@gmail.com/ --- tools/testing/selftests/net/tls.c | 141 ++++++++++++++++++++++++++++++ 1 file changed, 141 insertions(+) diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c index e788b84551ca..158dec851176 100644 --- a/tools/testing/selftests/net/tls.c +++ b/tools/testing/selftests/net/tls.c @@ -2791,6 +2791,147 @@ TEST_F(tls_err, oob_pressure) EXPECT_EQ(send(self->fd2, buf, 5, MSG_OOB), 5); } +/* + * Parse a stream of TLS records and ensure that each record respects + * the specified @max_payload_len. + */ +static size_t parse_tls_records(struct __test_metadata *_metadata, + const __u8 *rx_buf, int rx_len, int overhead, + __u16 max_payload_len) +{ + const __u8 *rec = rx_buf; + size_t total_plaintext_rx = 0; + const __u8 rec_header_len = 5; + + while (rec < rx_buf + rx_len) { + __u16 record_payload_len; + __u16 plaintext_len; + + /* Sanity check that it's a TLS header for application data */ + ASSERT_EQ(rec[0], 23); + ASSERT_EQ(rec[1], 0x3); + ASSERT_EQ(rec[2], 0x3); + + memcpy(&record_payload_len, rec + 3, 2); + record_payload_len = ntohs(record_payload_len); + ASSERT_GE(record_payload_len, overhead); + + plaintext_len = record_payload_len - overhead; + total_plaintext_rx += plaintext_len; + + /* Plaintext must not exceed the specified limit */ + ASSERT_LE(plaintext_len, max_payload_len); + rec += rec_header_len + record_payload_len; + } + + return total_plaintext_rx; +} + +TEST(tx_max_payload_len) +{ + struct tls_crypto_info_keys tls12; + int cfd, ret, fd, overhead; + size_t total_plaintext_rx = 0; + __u8 tx[1024], rx[2000]; + __u16 limit = 128; + __u16 opt = 0; + unsigned int optlen = sizeof(opt); + bool notls; + + tls_crypto_info_init(TLS_1_2_VERSION, TLS_CIPHER_AES_CCM_128, + &tls12, 0); + + ulp_sock_pair(_metadata, &fd, &cfd, ¬ls); + + if (notls) + exit(KSFT_SKIP); + + /* Don't install keys on fd, we'll parse raw records */ + ret = setsockopt(cfd, SOL_TLS, TLS_TX, &tls12, tls12.len); + ASSERT_EQ(ret, 0); + + ret = setsockopt(cfd, SOL_TLS, TLS_TX_MAX_PAYLOAD_LEN, &limit, + sizeof(limit)); + ASSERT_EQ(ret, 0); + + ret = getsockopt(cfd, SOL_TLS, TLS_TX_MAX_PAYLOAD_LEN, &opt, &optlen); + EXPECT_EQ(ret, 0); + EXPECT_EQ(limit, opt); + EXPECT_EQ(optlen, sizeof(limit)); + + memset(tx, 0, sizeof(tx)); + ASSERT_EQ(send(cfd, tx, sizeof(tx), 0), sizeof(tx)); + close(cfd); + + ret = recv(fd, rx, sizeof(rx), 0); + + /* + * 16B tag + 8B IV -- record header (5B) is not counted but we'll + * need it to walk the record stream + */ + overhead = 16 + 8; + total_plaintext_rx = parse_tls_records(_metadata, rx, ret, overhead, + limit); + + ASSERT_EQ(total_plaintext_rx, sizeof(tx)); + close(fd); +} + +TEST(tx_max_payload_len_open_rec) +{ + struct tls_crypto_info_keys tls12; + int cfd, ret, fd, overhead; + size_t total_plaintext_rx = 0; + __u8 tx[1024], rx[2000]; + __u16 tx_partial = 256; + __u16 og_limit = 512, limit = 128; + bool notls; + + tls_crypto_info_init(TLS_1_2_VERSION, TLS_CIPHER_AES_CCM_128, + &tls12, 0); + + ulp_sock_pair(_metadata, &fd, &cfd, ¬ls); + + if (notls) + exit(KSFT_SKIP); + + /* Don't install keys on fd, we'll parse raw records */ + ret = setsockopt(cfd, SOL_TLS, TLS_TX, &tls12, tls12.len); + ASSERT_EQ(ret, 0); + + ret = setsockopt(cfd, SOL_TLS, TLS_TX_MAX_PAYLOAD_LEN, &og_limit, + sizeof(og_limit)); + ASSERT_EQ(ret, 0); + + memset(tx, 0, sizeof(tx)); + ASSERT_EQ(send(cfd, tx, tx_partial, MSG_MORE), tx_partial); + + /* + * Changing the payload limit with a pending open record should + * not be allowed. + */ + ret = setsockopt(cfd, SOL_TLS, TLS_TX_MAX_PAYLOAD_LEN, &limit, + sizeof(limit)); + ASSERT_EQ(ret, -1); + ASSERT_EQ(errno, EBUSY); + + ASSERT_EQ(send(cfd, tx + tx_partial, sizeof(tx) - tx_partial, MSG_EOR), + sizeof(tx) - tx_partial); + close(cfd); + + ret = recv(fd, rx, sizeof(rx), 0); + + /* + * 16B tag + 8B IV -- record header (5B) is not counted but we'll + * need it to walk the record stream + */ + overhead = 16 + 8; + total_plaintext_rx = parse_tls_records(_metadata, rx, ret, overhead, + og_limit); + ASSERT_EQ(total_plaintext_rx, sizeof(tx)); + close(fd); +} + TEST(non_established) { struct tls12_crypto_info_aes_gcm_256 tls12; struct sockaddr_in addr; -- 2.51.0