From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19D723019B2; Wed, 15 Oct 2025 17:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760549742; cv=none; b=CdaySpRUn2BWxuw+oOKf71AhL+3y9haXjeZFp7GbPPKRtT/0SOFAZ4kIi+H1Ic4ls0O8OWrlKhf6mkSA1vW5V33XkHorrgQMKqd24c9+auzfcRMNeipN9aCBWY0w/Vwu+FW9zr21fPZJR0bE3fi1KyMDdc2Jcn6Lo/6OMQo4azs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760549742; c=relaxed/simple; bh=pEZ5P2P/pcsHQBwGmSCZzSbB6LsFpFMiLNyesbHEmAw=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=X8QRpP/3QhaAKuxgP4SdkloRsJuf9huEe4QgnVT3SGv4JXWSlPxLgMh04IVtpkUvTCCg0E0wLL06sz+z+vWx3pvfb8qoM92A8VbijsHf0tgAGPnDnlU1XD027OMEtYZHlUxOK6ParcnFhrwwyVq6hxcILeEnh3WZ3JIiCE87Zuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UcMfrGY3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UcMfrGY3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94FB6C4CEF9; Wed, 15 Oct 2025 17:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760549741; bh=pEZ5P2P/pcsHQBwGmSCZzSbB6LsFpFMiLNyesbHEmAw=; h=Date:From:To:Cc:Subject:References:From; b=UcMfrGY3oDH/6BZKvsakQ8/3OLHN9/sKEIloRFIA8ZY/K6SJh9xvuZhdEttBtyx8Q aoguC9MR32og5pyUYv7Lb/02LHOutNGTUMcJj0i6pI7dWzs93Sj71RxZRpUCjvo9aT 4ARFxQ3ng6FBwt4Ig0MlBonBMbp1HzBNTgiIMhCTmZD+gDmo8qxDVdjeNKWUuu4NLN 1PzleJMp+hgaMw0tIAxUrHCn8DE9vHzNJHeQbUOd08jHOCYgw6FrvzEpaB1vJO+ObK ZGbYKHmvUFbewlvSqeAKIDBDIzLAGYZX5YAMv0A9GfJtPymI9+KEYMWf/oL+17P084 0ZHpi1Y5Ao/xg== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1v95Pi-0000000120v-0sSE; Wed, 15 Oct 2025 13:35:50 -0400 Message-ID: <20251015173550.062240695@kernel.org> User-Agent: quilt/0.68 Date: Wed, 15 Oct 2025 13:32:26 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Peter Zijlstra , Namhyung Kim , Takaya Saeki , Tom Zanussi , Thomas Gleixner , Ian Rogers , Douglas Raillard , Arnaldo Carvalho de Melo , Jiri Olsa , Adrian Hunter , Ingo Molnar Subject: [PATCH v3 12/13] tracing: Check for printable characters when printing field dyn strings References: <20251015173214.760495866@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 From: Steven Rostedt When the "fields" option is enabled, it prints each trace event field based on its type. But a dynamic array and a dynamic string can both have a "char *" type. Printing it as a string can cause escape characters to be printed and mess up the output of the trace. For dynamic strings, test if there are any non-printable characters, and if so, print both the string with the non printable characters as '.', and the print the hex value of the array. Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_output.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index 97db0b0ccf3e..718b255b6fd8 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c @@ -950,7 +950,9 @@ static void print_fields(struct trace_iterator *iter, struct trace_event_call *c int offset; int len; int ret; + int i; void *pos; + char *str; list_for_each_entry_reverse(field, head, link) { trace_seq_printf(&iter->seq, " %s=", field->name); @@ -977,8 +979,29 @@ static void print_fields(struct trace_iterator *iter, struct trace_event_call *c trace_seq_puts(&iter->seq, ""); break; } - pos = (void *)iter->ent + offset; - trace_seq_printf(&iter->seq, "%.*s", len, (char *)pos); + str = (char *)iter->ent + offset; + /* Check if there's any non printable strings */ + for (i = 0; i < len; i++) { + if (str[i] && !(isascii(str[i]) && isprint(str[i]))) + break; + } + if (i < len) { + for (i = 0; i < len; i++) { + if (isascii(str[i]) && isprint(str[i])) + trace_seq_putc(&iter->seq, str[i]); + else + trace_seq_putc(&iter->seq, '.'); + } + trace_seq_puts(&iter->seq, " ("); + for (i = 0; i < len; i++) { + if (i) + trace_seq_putc(&iter->seq, ':'); + trace_seq_printf(&iter->seq, "%02x", str[i]); + } + trace_seq_putc(&iter->seq, ')'); + } else { + trace_seq_printf(&iter->seq, "%.*s", len, str); + } break; case FILTER_PTR_STRING: if (!iter->fmt_size) -- 2.51.0