Re: [RFC PATCH v1 23/38] coco: guest: arm64: Update arm CCA guest driver

Jonathan Cameron
2025-07-30T14:22:12Z

On Mon, 28 Jul 2025 19:22:00 +0530
"Aneesh Kumar K.V (Arm)" <aneesh.kumar@kernel.org> wrote:

> This patch includes renaming changes to simplify the registration of a
> TSM backend in the next patch. There are no functional changes in this
> update.
>
> Signed-off-by: Aneesh Kumar K.V (Arm) <aneesh.kumar@kernel.org>

> index 0c9ea24a200c..547fc2c79f7d 100644
> --- a/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c
> +++ b/drivers/virt/coco/arm-cca-guest/arm-cca.c

> +static int cca_guest_probe(struct platform_device *pdev)
...
> + ret = devm_add_action_or_reset(&pdev->dev, unregister_cca_tsm_report, NULL);
>
> -/**
> - * arm_cca_guest_exit - unregister with the Trusted Security Module (TSM)
> - * interface.
> - */
> -static void __exit arm_cca_guest_exit(void)
> -{
> - tsm_report_unregister(&arm_cca_tsm_ops);
> + return ret;

return devm_add_action_or_reset()

Mind you, Jason probably won't like this ;)
> }

> MODULE_AUTHOR("Sami Mujawar <sami.mujawar@arm.com>");
> -MODULE_DESCRIPTION("Arm CCA Guest TSM Driver");
> +MODULE_DESCRIPTION("Arm CCA Guest TSM driver");

Is this D/d worth the noise?

> MODULE_LICENSE("GPL");