public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cezar Chiru <chiru.cezar.89@gmail.com>
To: wsa+renesas@sang-engineering.com, andi.shyti@kernel.org
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	Cezar Chiru <chiru.cezar.89@gmail.com>
Subject: [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch
Date: Thu, 16 Oct 2025 19:14:14 +0300	[thread overview]
Message-ID: <20251016161417.15545-1-chiru.cezar.89@gmail.com> (raw)
In-Reply-To: <20250926154520.40583-1-chiru.cezar.89@gmail.com>

Hello maintainers,

This patch series fixes 18 errors and multiple warnings reported by 
checkpatch.pl on drivers/i2c/algos/i2c-algo-pcf.c file.

The series PATCH v1 to PATCH v4 is a response to the discussion on the
mailing list with Markus Elfring who had comments on my earlier 
submissions. 
He suggested:
 -to split my initial submission in a patch series
 -had some valid points on imperative mood usage in commit messages
 -wrapping commit message to 75 columns per line
 -change some of the commit message to point usage of checkpatch.pl
The series PATCH v4 to PATCH v6 is a response to the discussion on the
mailing list with I2C SUBSYSTEM maintainer Wolfram Sang who requested
some changes:
He requested:
 - to remove debug macros from i2c-algo-pcf.c as no code change was done
 for almost 16 years.
 - remove wrapping paranthesis from value assigned of '(0)''.
 - resolve conficts caused by debug macros removal.
 - remove also printk and dev_dbg function calls related to DEB macros.

Here is a brief summary and order of patches to be applied:
Patch 1/3: i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c
This patch remove the define of debug macros and also their usage from
code along with printk and dev_dbg function calls.

Patch 2/3: i2c: pcf8584: Fix do not use assignment inside if conditional
This patch takes the assignement from if conditional and moves it by 1 line
up.

Patch 3/3: i2c: pcf8584: Fix space(s) required before or after different
           operators
This patch adds space(s) around some binary operators.

Testing:
   *built kernel and modules with I2C_ALGOPCF=m and my 3 patches applied on
   top of 6.17.0-rc7.
   *installed kernel and external modules generated by build on my laptop
   *rebooted and loaded i2c-algo-pcf.ko without i2c_debug parameter.
   *when loading the .ko with i2c_debug parameter an error is seen in dmesg
   and this is expected as the parameter was removed.
   *No success message related to i2c_algo_pcf was seen in dmesg but also 
   no failures.
   *Module loading and unloading successful.
   *No PCF8584 Hardware was available.

Cezar Chiru (3):
  i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c
  i2c: pcf8584: Fix do not use assignment inside if conditional
  i2c: pcf8584: Fix space(s) required before or after different
    operators

 drivers/i2c/algos/i2c-algo-pcf.c | 93 +++++++-------------------------
 1 file changed, 18 insertions(+), 75 deletions(-)

-- 
2.43.0


  parent reply	other threads:[~2025-10-16 16:14 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-07 11:45 [PATCH] i2c : algos : i2c-algo-pcf.c : fixed errors shown by checkpatch Cezar Chiru
2025-09-07 12:07 ` [PATCH v2] " Cezar Chiru
2025-09-07 13:19   ` Markus Elfring
2025-09-07 15:38     ` Cezar Chiru
2025-09-07 17:45       ` [PATCH v3] " Markus Elfring
2025-09-08 11:13         ` [PATCH 0/3] i2c : PCF8584 : Cover Letter Cezar Chiru
2025-09-08 11:13           ` [PATCH 1/3] i2c : pcf8584 : Fix debug macros defines of if statements Cezar Chiru
2025-09-08 12:44             ` Markus Elfring
2025-09-08 13:36               ` [PATCH v2 0/3] i2c: PCF8584: Cover letter Cezar Chiru
2025-09-08 13:36                 ` [PATCH v2 1/3] i2c: PCF8584: Fix debug macros defines of if statements Cezar Chiru
2025-09-08 14:46                   ` Markus Elfring
2025-09-08 15:42                     ` Cezar Chiru
2025-09-08 17:08                       ` [v2 " Markus Elfring
2025-09-08 17:58                         ` [PATCH v3 0/3] i2c: PCF8584: Fix errors reported by checkpatch.pl Cezar Chiru
2025-09-08 17:59                           ` [PATCH v3 1/3] i2c: PCF8584: Fix debug macros defines of if statements Cezar Chiru
2025-09-08 19:18                             ` Markus Elfring
2025-09-08 17:59                           ` [PATCH v3 2/3] i2c: PCF8584: Fix do not use assignment in if conditional Cezar Chiru
2025-09-08 17:59                           ` [PATCH v3 3/3] i2c: PCF8584: Fix space(s) required before or after different operators Cezar Chiru
2025-09-09  7:30                             ` Markus Elfring
2025-09-09  8:18                               ` Cezar Chiru
2025-09-08 13:36                 ` [PATCH v2 2/3] i2c: PCF8584: Fix do not use assignment in 'if' conditional Cezar Chiru
2025-09-08 13:36                 ` [PATCH v2 3/3] i2c: PCF8584: Fixed space(s) required after different operators Cezar Chiru
2025-09-08 11:13           ` [PATCH 2/3] i2c : PCF8584 : Fix do not use assignment in 'if' conditional Cezar Chiru
2025-09-08 11:13           ` [PATCH 3/3] i2c : PCF8584 : Fixed space required after different operators Cezar Chiru
2025-09-17 13:35 ` [PATCH v4 0/3] i2c: pcf8584: Fix errors reported by checkpatch.pl Cezar Chiru
2025-09-17 13:35   ` [PATCH v4 1/3] i2c: pcf8584: Fix debug macros defines of if statements Cezar Chiru
2025-09-25 10:35     ` Wolfram Sang
2025-09-25 11:56       ` Cezar Chiru
2025-09-26 15:45       ` [PATCH v5 0/3] i2c: pcf8584: Fix errors reported by checkpatch Cezar Chiru
2025-09-26 15:45         ` [PATCH v5 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-09-26 18:07           ` Wolfram Sang
2025-09-26 19:05             ` Cezar Chiru
2025-09-27  4:13             ` [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Cezar Chiru
2025-09-27  4:13               ` [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-10-17 20:47                 ` Andi Shyti
2025-09-27  4:13               ` [PATCH v6 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-09-27  4:14               ` [PATCH v6 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-10-17 20:58                 ` Andi Shyti
2025-10-17 20:39               ` [PATCH v6 0/3] i2c: pcf8584: Fix errors and warnings reported by checkpatch Andi Shyti
2025-09-26 15:45         ` [PATCH v5 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-09-26 15:45         ` [PATCH v5 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-10-16 16:14         ` Cezar Chiru [this message]
2025-10-16 16:14           ` [PATCH v6 1/3] i2c: pcf8584: Remove debug macros from i2c-algo-pcf.c Cezar Chiru
2025-10-16 16:14           ` [PATCH v6 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-10-16 16:14           ` [PATCH v6 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-09-17 13:35   ` [PATCH v4 2/3] i2c: pcf8584: Fix do not use assignment inside if conditional Cezar Chiru
2025-09-25 10:35     ` Wolfram Sang
2025-09-17 13:35   ` [PATCH v4 3/3] i2c: pcf8584: Fix space(s) required before or after different operators Cezar Chiru
2025-09-25 10:35     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251016161417.15545-1-chiru.cezar.89@gmail.com \
    --to=chiru.cezar.89@gmail.com \
    --cc=andi.shyti@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox