Re: [GIT PULL] NFSD changes for v6.18

Jeff Layton
2025-10-07T11:47:41Z

On Tue, 2025-10-07 at 13:26 +0200, Christian Brauner wrote:
> On Mon, Oct 06, 2025 at 04:58:22PM -0400, Chuck Lever wrote:
> > On 10/6/25 4:51 PM, Linus Torvalds wrote:
> > > On Mon, 6 Oct 2025 at 06:50, Chuck Lever <cel@kernel.org> wrote:
> > > >
> > > > One potential merge conflict has been reported for nfsd-6.18.
> > >
> > > No problem, this is the simple kind of explicit conflict (famous last
> > > words before I mess one of those things up).
> > >
> > > Anyway, the reason I'm replying is actually that I notice that you
> > > added that ATTR_CTIME_SET flag in <linux/fs.h> in commit afc5b36e29b9
> > > ("vfs: add ATTR_CTIME_SET flag").
> > >
> > > No complaints about it, but it looks a bit odd with ATTR_{A,M}TIME_SET
> > > in bits 7 and 8, and then the new ATTR_CTIME_SET is in bit 10 with the
> > > entirely unrelated ATTR_FORCE in between them all.
> >
> > Oof. We should have gotten Acks for "vfs: add ATTR_CTIME_SET flag". My
> > bad.
>
> Yes, indeed. I wondered why I hadn't seen this patch.
>

I did send it to fsdevel, but you may have missed it in the deluge. Mea
culpa from me too -- I should have noticed that you guys hadn't acked
this yet. Any objection?
--
Jeff Layton <jlayton@kernel.org>