Re: [PATCH v3 3/4] KVM: VMX: Disable L1TF L1 data cache flush if CONFIG_CPU_MITIGATIONS=n

Sean Christopherson
2025-10-22T15:06:25Z

On Tue, Oct 21, 2025, Pawan Gupta wrote:
> On Thu, Oct 16, 2025 at 01:04:16PM -0700, Sean Christopherson wrote:
> > @@ -302,6 +303,16 @@ static int vmx_setup_l1d_flush(enum vmx_l1d_flush_state l1tf)
> > return 0;
> > }
> >
> > +static int vmx_setup_l1d_flush(void)
> > +{
> > + /*
> > + * Hand the parameter mitigation value in which was stored in the pre
> > + * module init parser. If no parameter was given, it will contain
> > + * 'auto' which will be turned into the default 'cond' mitigation mode.
> > + */
> > + return vmx_setup_l1d_flush(vmentry_l1d_flush_param);
>
> A likely typo here, it should be:
>
> return __vmx_setup_l1d_flush(vmentry_l1d_flush_param);

Argh, I have a feeling I clobbered my branch with a --force push, as I remember
fixing this exact problem. Or maybe I saw Brendan's struggles and thought, "hold
my beer!" :-D