* [PATCH] x86/platform/uv: Use str_enabled_disabled in uv_nmi_setup_hubless_intr
@ 2025-10-17 9:37 Thorsten Blum
2025-10-17 14:23 ` Kyle Meyer
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-10-17 9:37 UTC (permalink / raw)
To: Steve Wahl, Justin Ernst, Kyle Meyer, Dimitri Sivanich,
Russ Anderson, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, H. Peter Anvin
Cc: Thorsten Blum, linux-kernel
Replace hard-coded strings with the str_enabled_disabled() helper. This
unifies the output and helps the linker with deduplication, which can
result in a smaller binary. Additionally, silence the following
Coccinelle/coccicheck warning reported by string_choices.cocci:
opportunity for str_enabled_disabled(uv_pch_intr_now_enabled)
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
arch/x86/platform/uv/uv_nmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c
index 5c50e550ab63..565ab43fa6b4 100644
--- a/arch/x86/platform/uv/uv_nmi.c
+++ b/arch/x86/platform/uv/uv_nmi.c
@@ -18,6 +18,7 @@
#include <linux/sched/debug.h>
#include <linux/slab.h>
#include <linux/string.h>
+#include <linux/string_choices.h>
#include <linux/clocksource.h>
#include <asm/apic.h>
@@ -340,7 +341,7 @@ static void uv_nmi_setup_hubless_intr(void)
uv_pch_intr_now_enabled ? GPIROUTNMI : 0);
nmi_debug("UV:NMI: GPP_D_0 interrupt %s\n",
- uv_pch_intr_now_enabled ? "enabled" : "disabled");
+ str_enabled_disabled(uv_pch_intr_now_enabled));
}
static struct init_nmi {
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86/platform/uv: Use str_enabled_disabled in uv_nmi_setup_hubless_intr
2025-10-17 9:37 [PATCH] x86/platform/uv: Use str_enabled_disabled in uv_nmi_setup_hubless_intr Thorsten Blum
@ 2025-10-17 14:23 ` Kyle Meyer
0 siblings, 0 replies; 2+ messages in thread
From: Kyle Meyer @ 2025-10-17 14:23 UTC (permalink / raw)
To: Thorsten Blum
Cc: Steve Wahl, Justin Ernst, Dimitri Sivanich, Russ Anderson,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen, x86,
H. Peter Anvin, linux-kernel
On Fri, Oct 17, 2025 at 11:37:12AM +0200, Thorsten Blum wrote:
> Replace hard-coded strings with the str_enabled_disabled() helper. This
> unifies the output and helps the linker with deduplication, which can
> result in a smaller binary. Additionally, silence the following
> Coccinelle/coccicheck warning reported by string_choices.cocci:
>
> opportunity for str_enabled_disabled(uv_pch_intr_now_enabled)
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
Reviewed-by: Kyle Meyer <kyle.meyer@hpe.com>
> arch/x86/platform/uv/uv_nmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c
> index 5c50e550ab63..565ab43fa6b4 100644
> --- a/arch/x86/platform/uv/uv_nmi.c
> +++ b/arch/x86/platform/uv/uv_nmi.c
> @@ -18,6 +18,7 @@
> #include <linux/sched/debug.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <linux/string_choices.h>
> #include <linux/clocksource.h>
>
> #include <asm/apic.h>
> @@ -340,7 +341,7 @@ static void uv_nmi_setup_hubless_intr(void)
> uv_pch_intr_now_enabled ? GPIROUTNMI : 0);
>
> nmi_debug("UV:NMI: GPP_D_0 interrupt %s\n",
> - uv_pch_intr_now_enabled ? "enabled" : "disabled");
> + str_enabled_disabled(uv_pch_intr_now_enabled));
> }
>
> static struct init_nmi {
> --
> 2.51.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-17 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-17 9:37 [PATCH] x86/platform/uv: Use str_enabled_disabled in uv_nmi_setup_hubless_intr Thorsten Blum
2025-10-17 14:23 ` Kyle Meyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox