Re: [PATCH] x86/platform/uv: Use str_enabled_disabled in uv_nmi_setup_hubless_intr

Kyle Meyer
2025-10-17T14:25:44Z

On Fri, Oct 17, 2025 at 11:37:12AM +0200, Thorsten Blum wrote:
> Replace hard-coded strings with the str_enabled_disabled() helper. This
> unifies the output and helps the linker with deduplication, which can
> result in a smaller binary. Additionally, silence the following
> Coccinelle/coccicheck warning reported by string_choices.cocci:
>
> opportunity for str_enabled_disabled(uv_pch_intr_now_enabled)
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---

Reviewed-by: Kyle Meyer <kyle.meyer@hpe.com>

> arch/x86/platform/uv/uv_nmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c
> index 5c50e550ab63..565ab43fa6b4 100644
> --- a/arch/x86/platform/uv/uv_nmi.c
> +++ b/arch/x86/platform/uv/uv_nmi.c
> @@ -18,6 +18,7 @@
> #include <linux/sched/debug.h>
> #include <linux/slab.h>
> #include <linux/string.h>
> +#include <linux/string_choices.h>
> #include <linux/clocksource.h>
>
> #include <asm/apic.h>
> @@ -340,7 +341,7 @@ static void uv_nmi_setup_hubless_intr(void)
> uv_pch_intr_now_enabled ? GPIROUTNMI : 0);
>
> nmi_debug("UV:NMI: GPP_D_0 interrupt %s\n",
> - uv_pch_intr_now_enabled ? "enabled" : "disabled");
> + str_enabled_disabled(uv_pch_intr_now_enabled));
> }
>
> static struct init_nmi {
> --
> 2.51.0
>