* [PATCH] ACPI: property: Fix argument order in __acpi_node_get_property_reference()
@ 2025-10-17 10:07 Sunil V L
2025-10-18 19:38 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Sunil V L @ 2025-10-17 10:07 UTC (permalink / raw)
To: linux-acpi, linux-kernel
Cc: Rafael J . Wysocki, Len Brown, Paul Walmsley, Andy Shevchenko,
Jassi Brar, Anup Patel, Sunil V L, Thomas Richard
A refactoring bug introduced an argument order mistake in the call to
acpi_fwnode_get_reference_args() from __acpi_node_get_property_reference().
This caused incorrect behavior when resolving ACPI property references.
Fix the issue by correcting the argument order.
Fixes: e121be784d35 ("ACPI: property: Refactor acpi_fwnode_get_reference_args() to support nargs_prop")
Reported-by: Thomas Richard <thomas.richard@bootlin.com>
Closes: https://lore.kernel.org/all/1241f2b6-9b4e-4623-8a83-77db8774ac32@bootlin.com/
Tested-by: Thomas Richard <thomas.richard@bootlin.com>
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
drivers/acpi/property.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c
index 1b997a5497e7..43d5e457814e 100644
--- a/drivers/acpi/property.c
+++ b/drivers/acpi/property.c
@@ -1107,7 +1107,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
size_t num_args,
struct fwnode_reference_args *args)
{
- return acpi_fwnode_get_reference_args(fwnode, propname, NULL, index, num_args, args);
+ return acpi_fwnode_get_reference_args(fwnode, propname, NULL, num_args, index, args);
}
EXPORT_SYMBOL_GPL(__acpi_node_get_property_reference);
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: property: Fix argument order in __acpi_node_get_property_reference()
2025-10-17 10:07 [PATCH] ACPI: property: Fix argument order in __acpi_node_get_property_reference() Sunil V L
@ 2025-10-18 19:38 ` Andy Shevchenko
2025-10-20 20:03 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2025-10-18 19:38 UTC (permalink / raw)
To: Sunil V L
Cc: linux-acpi, linux-kernel, Rafael J . Wysocki, Len Brown,
Paul Walmsley, Jassi Brar, Anup Patel, Thomas Richard
On Fri, Oct 17, 2025 at 03:37:44PM +0530, Sunil V L wrote:
> A refactoring bug introduced an argument order mistake in the call to
> acpi_fwnode_get_reference_args() from __acpi_node_get_property_reference().
> This caused incorrect behavior when resolving ACPI property references.
>
> Fix the issue by correcting the argument order.
Thanks for a fix which looks good to me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ACPI: property: Fix argument order in __acpi_node_get_property_reference()
2025-10-18 19:38 ` Andy Shevchenko
@ 2025-10-20 20:03 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2025-10-20 20:03 UTC (permalink / raw)
To: Andy Shevchenko, Sunil V L
Cc: linux-acpi, linux-kernel, Len Brown, Paul Walmsley, Jassi Brar,
Anup Patel, Thomas Richard
On Sat, Oct 18, 2025 at 9:38 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Fri, Oct 17, 2025 at 03:37:44PM +0530, Sunil V L wrote:
> > A refactoring bug introduced an argument order mistake in the call to
> > acpi_fwnode_get_reference_args() from __acpi_node_get_property_reference().
> > This caused incorrect behavior when resolving ACPI property references.
> >
> > Fix the issue by correcting the argument order.
>
> Thanks for a fix which looks good to me,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied as 6.18-rc material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-20 20:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-17 10:07 [PATCH] ACPI: property: Fix argument order in __acpi_node_get_property_reference() Sunil V L
2025-10-18 19:38 ` Andy Shevchenko
2025-10-20 20:03 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox