From: Wei Liu <wei.liu@kernel.org>
To: Mukesh Rathor <mrathor@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, kys@microsoft.com,
haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
arnd@arndb.de
Subject: Re: [PATCH v3 0/6] Hyper-V: Implement hypervisor core collection
Date: Fri, 17 Oct 2025 22:57:32 +0000 [thread overview]
Message-ID: <20251017225732.GC632885@liuwe-devbox-debian-v2.local> (raw)
In-Reply-To: <20251017223300.GB632885@liuwe-devbox-debian-v2.local>
On Fri, Oct 17, 2025 at 10:33:00PM +0000, Wei Liu wrote:
> On Mon, Oct 06, 2025 at 03:42:02PM -0700, Mukesh Rathor wrote:
> [...]
> > Mukesh Rathor (6):
> > x86/hyperv: Rename guest crash shutdown function
> > hyperv: Add two new hypercall numbers to guest ABI public header
> > hyperv: Add definitions for hypervisor crash dump support
> > x86/hyperv: Add trampoline asm code to transition from hypervisor
> > x86/hyperv: Implement hypervisor RAM collection into vmcore
> > x86/hyperv: Enable build of hypervisor crashdump collection files
> >
>
> Applied to hyperv-next. Thanks.
This breaks i386 build.
/work/linux-on-hyperv/linux.git/arch/x86/hyperv/hv_init.c: In function ‘hyperv_init’:
/work/linux-on-hyperv/linux.git/arch/x86/hyperv/hv_init.c:557:17: error: implicit declaration of function ‘hv_root_crash_init’ [-Werror=implicit-function-declaration]
557 | hv_root_crash_init();
| ^~~~~~~~~~~~~~~~~~
That's because CONFIG_MSHV_ROOT is only available on x86_64. And the
crash feature is guarded by CONFIG_MSHV_ROOT.
Applying the following diff fixes the build.
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
index e28737ec7054..c1300339d2eb 100644
--- a/arch/x86/hyperv/hv_init.c
+++ b/arch/x86/hyperv/hv_init.c
@@ -554,7 +554,9 @@ void __init hyperv_init(void)
memunmap(src);
hv_remap_tsc_clocksource();
+#ifdef CONFIG_X86_64
hv_root_crash_init();
+#endif
} else {
hypercall_msr.guest_physical_address = vmalloc_to_pfn(hv_hypercall_pg);
wrmsrq(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64);
>
> > arch/x86/hyperv/Makefile | 6 +
> > arch/x86/hyperv/hv_crash.c | 642 ++++++++++++++++++++++++++++++++
> > arch/x86/hyperv/hv_init.c | 1 +
> > arch/x86/hyperv/hv_trampoline.S | 101 +++++
> > arch/x86/include/asm/mshyperv.h | 13 +
> > arch/x86/kernel/cpu/mshyperv.c | 5 +-
> > include/hyperv/hvgdk_mini.h | 2 +
> > include/hyperv/hvhdk_mini.h | 55 +++
> > 8 files changed, 823 insertions(+), 2 deletions(-)
> > create mode 100644 arch/x86/hyperv/hv_crash.c
> > create mode 100644 arch/x86/hyperv/hv_trampoline.S
> >
> > --
> > 2.36.1.vfs.0.0
> >
next prev parent reply other threads:[~2025-10-17 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-06 22:42 [PATCH v3 0/6] Hyper-V: Implement hypervisor core collection Mukesh Rathor
2025-10-06 22:42 ` [PATCH v3 1/6] x86/hyperv: Rename guest crash shutdown function Mukesh Rathor
2025-10-06 22:42 ` [PATCH v3 2/6] hyperv: Add two new hypercall numbers to guest ABI public header Mukesh Rathor
2025-10-06 22:42 ` [PATCH v3 3/6] hyperv: Add definitions for hypervisor crash dump support Mukesh Rathor
2025-10-06 22:42 ` [PATCH v3 4/6] x86/hyperv: Add trampoline asm code to transition from hypervisor Mukesh Rathor
2025-10-06 22:42 ` [PATCH v3 5/6] x86/hyperv: Implement hypervisor RAM collection into vmcore Mukesh Rathor
2026-01-13 11:14 ` Borislav Petkov
2026-01-13 23:36 ` Mukesh R
2025-10-06 22:42 ` [PATCH v3 6/6] x86/hyperv: Enable build of hypervisor crashdump collection files Mukesh Rathor
2025-10-17 22:33 ` [PATCH v3 0/6] Hyper-V: Implement hypervisor core collection Wei Liu
2025-10-17 22:57 ` Wei Liu [this message]
2025-10-17 23:58 ` Mukesh R
2025-10-18 2:54 ` Michael Kelley
2025-10-20 19:05 ` Mukesh R
2025-10-20 20:48 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017225732.GC632885@liuwe-devbox-debian-v2.local \
--to=wei.liu@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mrathor@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox