Re: [PATCH 2/3] nvme-pci: unmap MMIO pages with appropriate interface

Leon Romanovsky
2025-10-20T07:53:12Z

On Fri, Oct 17, 2025 at 08:20:08AM +0200, Christoph Hellwig wrote:
> On Fri, Oct 17, 2025 at 08:31:59AM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia.com>
> >
> > Block layer maps MMIO memory through dma_map_phys() interface
> > with help of DMA_ATTR_MMIO attribute. There is a need to unmap
> > that memory with the appropriate unmap function, something which
> > wasn't possible before adding new REQ attribute to block layer in
> > previous patch.
>
> DMA_ATTR_MMIO only gets set in the following patch as far as I can
> tell.
>
> The more logical way would be to simply convert to dma_unmap_phys
> here and then add the flag in one go as suggested last round.

Done, thanks