From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: kevin.tian@intel.com, shuah@kernel.org,
alessandro.zanni87@gmail.com, iommu@lists.linux.dev,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()
Date: Mon, 20 Oct 2025 20:01:58 -0300 [thread overview]
Message-ID: <20251020230158.GF316284@nvidia.com> (raw)
In-Reply-To: <20251014214847.1113759-1-nicolinc@nvidia.com>
On Tue, Oct 14, 2025 at 02:48:46PM -0700, Nicolin Chen wrote:
> The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
>
> Drop the '!' to fix it.
>
> Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> tools/testing/selftests/iommu/iommufd_utils.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2025-10-20 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 21:48 [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents() Nicolin Chen
2025-10-16 7:47 ` Tian, Kevin
2025-10-16 9:09 ` Alessandro Zanni
2025-10-16 15:22 ` Nicolin Chen
2025-10-20 23:01 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020230158.GF316284@nvidia.com \
--to=jgg@nvidia.com \
--cc=alessandro.zanni87@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox