From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b4-smtp.messagingengine.com (fout-b4-smtp.messagingengine.com [202.12.124.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F35892AD16 for ; Tue, 21 Oct 2025 21:17:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761081431; cv=none; b=MFVXtFWFyNmJHtVxogGkYtqJ9z3/0TcTmhtA5FRI1v3yFuXe0th3+k2KJn84tmFevFpuNZk3tAc5lNggjgcL+lxqv+evjoNL+2BcTAFg77BMp8cFSYTB7VEr4+34TMuNeeJwV/3srokzWOSBcysGajnIyUYkxNs331ui951HXCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761081431; c=relaxed/simple; bh=AikbkCxgH7RdIgZ7RLIknLv/smx+7jf8OdCJ6/EO6pQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hnU3fDpoEL9rO1N7D6iuTnfUkE39AZJoEDEPBfPnOK974y6HwgCpTgOF+FgXpL12i0M8tXNHxg5fq9DMuEq0HTkDKoEXhP2wRhbkwQIt4dfgxgERB7Cd8Q6c78jzM68j2OxCiRemd1GIrqRc0ceKiNfdIfHrb4QNyQ7Cm39KY8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=vCoP2JV3; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=gDyegl9H; arc=none smtp.client-ip=202.12.124.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="vCoP2JV3"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="gDyegl9H" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id D01DB1D00156; Tue, 21 Oct 2025 17:17:07 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 21 Oct 2025 17:17:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1761081427; x= 1761167827; bh=HruvpjJEz3WJJK8LfCW0sjYuuW7dan0UrL1gfqBV1TE=; b=v CoP2JV3dL+GKSsUY5ulLv//IxJ9QXViqfRxGVzt2M3hCwGddwVVVHhj2WSJhbRmO dSXwZhXqJVs2XTLPFD5ajaID6msUaR92sRtPYQ/fSVnAdHCXm6uffTqUT/w3gYdv yNshAzsyIxf9Pfa8rc8RBYBxLzD/Z9IgP6c43LitxoisC7awZzVh+IFhc6lWlR8F PYTCyMNeAhcXBmZqCu3e1L29NFnnicr8pVZ/EOg4ZTjYr/21kWSeEcijz9q364BG 0RRgjo3V6rACp/5ZhS/fsSTjoZIdDzulsSlGcmxQ+Mqj4wvW4SN4fstU7JAkXIDV Tvplb+biVwFf8E3kjZMTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1761081427; x=1761167827; bh=HruvpjJEz3WJJK8LfCW0sjYuuW7dan0UrL1 gfqBV1TE=; b=gDyegl9H96DLFQPk9VVi4c/unnny7+ExL8mwOTy8KirJacabvqW /x4ppKH4IElZN4qYQ9vaG505ogXbsGofVST7QqmwTHhRJuqSijz9sdqiK0v62wLc iprk3zdtJtHVBv9F6M/E7C08jHaBau+vvtcGWjy8/C62XqJHDL7xv44WD/BnN1Zg EeslA5c0sEtNDaVfal0Q+gA5q+k6rekJA2ZyAfVz7Otljhc5EE8CScn40e+Xhar8 Iaodr2M12cV4Z2ZAxiCyALAstYXNDMh5l4SPNleqlNBOZYGrzAlLRE6O/93BNRIp BnLMAJqYTFwkxMBRBCkQ7UK6ec7TW/fFZUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddugedujeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttdertd dttddvnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohhtohcuoehoqdhtrghkrghs hhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtthgvrhhnpeehhffhteetgf ekvdeiueffveevueeftdelhfejieeitedvleeftdfgfeeuudekueenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqdhtrghkrghshhhisehsrg hkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhpohhu thdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlsehlihhsthhsrdhsohhurh gtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgv rhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Oct 2025 17:17:06 -0400 (EDT) Date: Wed, 22 Oct 2025 06:17:04 +0900 From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] firewire: core: use cleanup function to release cached configuration ROM Message-ID: <20251021211704.GA210874@workstation.local> Mail-Followup-To: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <20251020115810.92839-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251020115810.92839-1-o-takashi@sakamocchi.jp> On Mon, Oct 20, 2025 at 08:58:10PM +0900, Takashi Sakamoto wrote: > When returning from read_config_rom() function, the allocated buffer and > the previous buffer for configuration ROM should be released. The cleanup > function is useful in the case. > > This commit uses the cleanup function to remove goto statements. > > Signed-off-by: Takashi Sakamoto > --- > drivers/firewire/core-device.c | 34 ++++++++++++---------------------- > 1 file changed, 12 insertions(+), 22 deletions(-) Applied to for-next branch. Regards Takashi Sakamoto