[PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[michael.opdenacker]

From: Michael Opdenacker <michael.opdenacker@rootcommit.com>

The OrangePi RV2 board ships two RGMII ethernet ports.
Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
for reset pin control.

Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.

Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
CC: Yixun Lan <dlan@gentoo.org>
CC: Vivian Wang <wangruikang@iscas.ac.cn>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
index 337240ebb7b7..41dc8e35e6eb 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
@@ -15,6 +15,8 @@ / {
 
 	aliases {
 		serial0 = &uart0;
+		ethernet0 = &eth0;
+		ethernet1 = &eth1;
 	};
 
 	chosen {
@@ -33,6 +35,56 @@ led1 {
 	};
 };
 
+&eth0 {
+	phy-handle = <&rgmii0>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac0_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <0>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii0: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&eth1 {
+	phy-handle = <&rgmii1>;
+	phy-mode = "rgmii-id";
+	pinctrl-names = "default";
+	pinctrl-0 = <&gmac1_cfg>;
+	rx-internal-delay-ps = <0>;
+	tx-internal-delay-ps = <250>;
+	status = "okay";
+
+	mdio-bus {
+		#address-cells = <0x1>;
+		#size-cells = <0x0>;
+
+		reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>;
+		reset-delay-us = <10000>;
+		reset-post-delay-us = <100000>;
+
+		rgmii1: phy@1 {
+			reg = <0x1>;
+		};
+	};
+};
+
+&pdma {
+	status = "okay";
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Yixun Lan]

Hi Michael, 

On 20:18 Wed 22 Oct     , michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> 
> The OrangePi RV2 board ships two RGMII ethernet ports.
> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> for reset pin control.
> 
> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> CC: Yixun Lan <dlan@gentoo.org>
> CC: Vivian Wang <wangruikang@iscas.ac.cn>

Reviewed-by: Yixun Lan <dlan@gentoo.org>

-- 
Yixun Lan (dlan)

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Vivian Wang]

Thank you so much for the patch and testing results. Only some nitpicks
follow.

On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>
> The OrangePi RV2 board ships two RGMII ethernet ports.
> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> for reset pin control.
>
> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> CC: Yixun Lan <dlan@gentoo.org>
> CC: Vivian Wang <wangruikang@iscas.ac.cn>

Firstly, it is usually spelt "Cc:", with one upper-case C and one
lower-case c.

Secondly, "Cc:" should not be necessary in the patch/commit message.
From Documentation/process/submitting-patches.rst:

    If a person has had the opportunity to comment on a patch, but has not
    provided such comments, you may optionally add a ``Cc:`` tag to the patch.
    This tag documents that potentially interested parties have been included in
    the discussion.

If you look through the git logs of Linux, Cc tags are really not a
regular occurrence except those marking patches as suitable for
backporting to stable.

Thanks,
Vivian "dramforever"

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
> Thank you so much for the patch and testing results. Only some nitpicks
> follow.
> 
> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> > From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >
> > The OrangePi RV2 board ships two RGMII ethernet ports.
> > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> > for reset pin control.
> >
> > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> > CC: Yixun Lan <dlan@gentoo.org>
> > CC: Vivian Wang <wangruikang@iscas.ac.cn>
> 
> Firstly, it is usually spelt "Cc:", with one upper-case C and one
> lower-case c.

I don't think this matters at all, the git tooling at least doesn't
care.

> Secondly, "Cc:" should not be necessary in the patch/commit message.
> From Documentation/process/submitting-patches.rst:
> 
>     If a person has had the opportunity to comment on a patch, but has not
>     provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>     This tag documents that potentially interested parties have been included in
>     the discussion.
> 
> If you look through the git logs of Linux, Cc tags are really not a
> regular occurrence except those marking patches as suitable for
> backporting to stable.

If people want to handle CC lists by putting it in the patches (it's
what I do when I have no cover letter) just put them after the --- line
and git send-email will still pick the CCs up but they won't end up in
the history.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Yixun Lan]

Hi Michael, 

Since the patch itself is good enough, so I will just take it,
I will drop those CCs if no objection..

On 19:30 Thu 23 Oct     , Conor Dooley wrote:
> On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
> > Thank you so much for the patch and testing results. Only some nitpicks
> > follow.
> > 
> > On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > >
> > > The OrangePi RV2 board ships two RGMII ethernet ports.
> > > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> > > for reset pin control.
> > >
> > > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> > >
> > > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> > > CC: Yixun Lan <dlan@gentoo.org>
> > > CC: Vivian Wang <wangruikang@iscas.ac.cn>
> > 
> > Firstly, it is usually spelt "Cc:", with one upper-case C and one
> > lower-case c.
> 
> I don't think this matters at all, the git tooling at least doesn't
> care.
> 
I think it's super useful by putting additional "Cc" into individual patch
especially for a large series to notify specific maintainers while not spam others


> > Secondly, "Cc:" should not be necessary in the patch/commit message.
> > From Documentation/process/submitting-patches.rst:
> > 
> >     If a person has had the opportunity to comment on a patch, but has not
> >     provided such comments, you may optionally add a ``Cc:`` tag to the patch.
> >     This tag documents that potentially interested parties have been included in
> >     the discussion.
> > 
> > If you look through the git logs of Linux, Cc tags are really not a
> > regular occurrence except those marking patches as suitable for
> > backporting to stable.
> 
> If people want to handle CC lists by putting it in the patches (it's
> what I do when I have no cover letter) just put them after the --- line
> and git send-email will still pick the CCs up but they won't end up in
> the history.
> 
indeed, good suggestion!


-- 
Yixun Lan (dlan)

Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Michael Opdenacker]

Hi Conor

Thanks for the review!

On 10/23/25 20:30, Conor Dooley wrote:
> On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
>> Thank you so much for the patch and testing results. Only some nitpicks
>> follow.
>>
>> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
>>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>>
>>> The OrangePi RV2 board ships two RGMII ethernet ports.
>>> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
>>> for reset pin control.
>>>
>>> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
>>>
>>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
>>> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
>>> CC: Yixun Lan <dlan@gentoo.org>
>>> CC: Vivian Wang <wangruikang@iscas.ac.cn>
>> Firstly, it is usually spelt "Cc:", with one upper-case C and one
>> lower-case c.
> I don't think this matters at all, the git tooling at least doesn't
> care.
>
>> Secondly, "Cc:" should not be necessary in the patch/commit message.
>>  From Documentation/process/submitting-patches.rst:
>>
>>      If a person has had the opportunity to comment on a patch, but has not
>>      provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>>      This tag documents that potentially interested parties have been included in
>>      the discussion.
>>
>> If you look through the git logs of Linux, Cc tags are really not a
>> regular occurrence except those marking patches as suitable for
>> backporting to stable.
> If people want to handle CC lists by putting it in the patches (it's
> what I do when I have no cover letter) just put them after the --- line
> and git send-email will still pick the CCs up but they won't end up in
> the history.

Oh yes, that was my mistake. The CCs were never intended to make it to 
the final commits.
Thanks!
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/