* [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 [not found] <20251022201807.1474789-1-michael.opdenacker@rootcommit.com> @ 2025-10-22 20:18 ` michael.opdenacker 2025-10-22 22:14 ` Yixun Lan 2025-10-23 5:58 ` Vivian Wang 0 siblings, 2 replies; 6+ messages in thread From: michael.opdenacker @ 2025-10-22 20:18 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti Cc: Michael Opdenacker, Emil Renner Berthing, Vivian Wang, devicetree, linux-riscv, spacemit, linux-kernel From: Michael Opdenacker <michael.opdenacker@rootcommit.com> The OrangePi RV2 board ships two RGMII ethernet ports. Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO for reset pin control. Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board. Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com> CC: Yixun Lan <dlan@gentoo.org> CC: Vivian Wang <wangruikang@iscas.ac.cn> --- .../boot/dts/spacemit/k1-orangepi-rv2.dts | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts index 337240ebb7b7..41dc8e35e6eb 100644 --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts @@ -15,6 +15,8 @@ / { aliases { serial0 = &uart0; + ethernet0 = ð0; + ethernet1 = ð1; }; chosen { @@ -33,6 +35,56 @@ led1 { }; }; +ð0 { + phy-handle = <&rgmii0>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_cfg>; + rx-internal-delay-ps = <0>; + tx-internal-delay-ps = <0>; + status = "okay"; + + mdio-bus { + #address-cells = <0x1>; + #size-cells = <0x0>; + + reset-gpios = <&gpio K1_GPIO(110) GPIO_ACTIVE_LOW>; + reset-delay-us = <10000>; + reset-post-delay-us = <100000>; + + rgmii0: phy@1 { + reg = <0x1>; + }; + }; +}; + +ð1 { + phy-handle = <&rgmii1>; + phy-mode = "rgmii-id"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac1_cfg>; + rx-internal-delay-ps = <0>; + tx-internal-delay-ps = <250>; + status = "okay"; + + mdio-bus { + #address-cells = <0x1>; + #size-cells = <0x0>; + + reset-gpios = <&gpio K1_GPIO(115) GPIO_ACTIVE_LOW>; + reset-delay-us = <10000>; + reset-post-delay-us = <100000>; + + rgmii1: phy@1 { + reg = <0x1>; + }; + }; +}; + +&pdma { + status = "okay"; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_2_cfg>; ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 2025-10-22 20:18 ` [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 michael.opdenacker @ 2025-10-22 22:14 ` Yixun Lan 2025-10-23 5:58 ` Vivian Wang 1 sibling, 0 replies; 6+ messages in thread From: Yixun Lan @ 2025-10-22 22:14 UTC (permalink / raw) To: michael.opdenacker Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Emil Renner Berthing, Vivian Wang, devicetree, linux-riscv, spacemit, linux-kernel Hi Michael, On 20:18 Wed 22 Oct , michael.opdenacker@rootcommit.com wrote: > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > The OrangePi RV2 board ships two RGMII ethernet ports. > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO > for reset pin control. > > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board. > > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com> > CC: Yixun Lan <dlan@gentoo.org> > CC: Vivian Wang <wangruikang@iscas.ac.cn> Reviewed-by: Yixun Lan <dlan@gentoo.org> -- Yixun Lan (dlan) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 2025-10-22 20:18 ` [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 michael.opdenacker 2025-10-22 22:14 ` Yixun Lan @ 2025-10-23 5:58 ` Vivian Wang 2025-10-23 18:30 ` Conor Dooley 1 sibling, 1 reply; 6+ messages in thread From: Vivian Wang @ 2025-10-23 5:58 UTC (permalink / raw) To: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti Cc: Emil Renner Berthing, devicetree, linux-riscv, spacemit, linux-kernel Thank you so much for the patch and testing results. Only some nitpicks follow. On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote: > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > The OrangePi RV2 board ships two RGMII ethernet ports. > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO > for reset pin control. > > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board. > > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com> > CC: Yixun Lan <dlan@gentoo.org> > CC: Vivian Wang <wangruikang@iscas.ac.cn> Firstly, it is usually spelt "Cc:", with one upper-case C and one lower-case c. Secondly, "Cc:" should not be necessary in the patch/commit message. From Documentation/process/submitting-patches.rst: If a person has had the opportunity to comment on a patch, but has not provided such comments, you may optionally add a ``Cc:`` tag to the patch. This tag documents that potentially interested parties have been included in the discussion. If you look through the git logs of Linux, Cc tags are really not a regular occurrence except those marking patches as suitable for backporting to stable. Thanks, Vivian "dramforever" ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 2025-10-23 5:58 ` Vivian Wang @ 2025-10-23 18:30 ` Conor Dooley 2025-10-24 0:02 ` Yixun Lan 2025-10-24 5:36 ` Michael Opdenacker 0 siblings, 2 replies; 6+ messages in thread From: Conor Dooley @ 2025-10-23 18:30 UTC (permalink / raw) To: Vivian Wang Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Emil Renner Berthing, devicetree, linux-riscv, spacemit, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1724 bytes --] On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote: > Thank you so much for the patch and testing results. Only some nitpicks > follow. > > On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote: > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > > > The OrangePi RV2 board ships two RGMII ethernet ports. > > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO > > for reset pin control. > > > > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board. > > > > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com> > > CC: Yixun Lan <dlan@gentoo.org> > > CC: Vivian Wang <wangruikang@iscas.ac.cn> > > Firstly, it is usually spelt "Cc:", with one upper-case C and one > lower-case c. I don't think this matters at all, the git tooling at least doesn't care. > Secondly, "Cc:" should not be necessary in the patch/commit message. > From Documentation/process/submitting-patches.rst: > > If a person has had the opportunity to comment on a patch, but has not > provided such comments, you may optionally add a ``Cc:`` tag to the patch. > This tag documents that potentially interested parties have been included in > the discussion. > > If you look through the git logs of Linux, Cc tags are really not a > regular occurrence except those marking patches as suitable for > backporting to stable. If people want to handle CC lists by putting it in the patches (it's what I do when I have no cover letter) just put them after the --- line and git send-email will still pick the CCs up but they won't end up in the history. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 2025-10-23 18:30 ` Conor Dooley @ 2025-10-24 0:02 ` Yixun Lan 2025-10-24 5:36 ` Michael Opdenacker 1 sibling, 0 replies; 6+ messages in thread From: Yixun Lan @ 2025-10-24 0:02 UTC (permalink / raw) To: Conor Dooley Cc: Vivian Wang, michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Emil Renner Berthing, devicetree, linux-riscv, spacemit, linux-kernel Hi Michael, Since the patch itself is good enough, so I will just take it, I will drop those CCs if no objection.. On 19:30 Thu 23 Oct , Conor Dooley wrote: > On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote: > > Thank you so much for the patch and testing results. Only some nitpicks > > follow. > > > > On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote: > > > From: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > > > > > The OrangePi RV2 board ships two RGMII ethernet ports. > > > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO > > > for reset pin control. > > > > > > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board. > > > > > > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> > > > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com> > > > CC: Yixun Lan <dlan@gentoo.org> > > > CC: Vivian Wang <wangruikang@iscas.ac.cn> > > > > Firstly, it is usually spelt "Cc:", with one upper-case C and one > > lower-case c. > > I don't think this matters at all, the git tooling at least doesn't > care. > I think it's super useful by putting additional "Cc" into individual patch especially for a large series to notify specific maintainers while not spam others > > Secondly, "Cc:" should not be necessary in the patch/commit message. > > From Documentation/process/submitting-patches.rst: > > > > If a person has had the opportunity to comment on a patch, but has not > > provided such comments, you may optionally add a ``Cc:`` tag to the patch. > > This tag documents that potentially interested parties have been included in > > the discussion. > > > > If you look through the git logs of Linux, Cc tags are really not a > > regular occurrence except those marking patches as suitable for > > backporting to stable. > > If people want to handle CC lists by putting it in the patches (it's > what I do when I have no cover letter) just put them after the --- line > and git send-email will still pick the CCs up but they won't end up in > the history. > indeed, good suggestion! -- Yixun Lan (dlan) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 2025-10-23 18:30 ` Conor Dooley 2025-10-24 0:02 ` Yixun Lan @ 2025-10-24 5:36 ` Michael Opdenacker 1 sibling, 0 replies; 6+ messages in thread From: Michael Opdenacker @ 2025-10-24 5:36 UTC (permalink / raw) To: Conor Dooley, Vivian Wang Cc: michael.opdenacker, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Yixun Lan, Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti, Emil Renner Berthing, devicetree, linux-riscv, spacemit, linux-kernel Hi Conor Thanks for the review! On 10/23/25 20:30, Conor Dooley wrote: > On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote: >> Thank you so much for the patch and testing results. Only some nitpicks >> follow. >> >> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote: >>> From: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>> >>> The OrangePi RV2 board ships two RGMII ethernet ports. >>> Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO >>> for reset pin control. >>> >>> Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board. >>> >>> Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com> >>> CC: Emil Renner Berthing <emil.renner.berthing@gmail.com> >>> CC: Yixun Lan <dlan@gentoo.org> >>> CC: Vivian Wang <wangruikang@iscas.ac.cn> >> Firstly, it is usually spelt "Cc:", with one upper-case C and one >> lower-case c. > I don't think this matters at all, the git tooling at least doesn't > care. > >> Secondly, "Cc:" should not be necessary in the patch/commit message. >> From Documentation/process/submitting-patches.rst: >> >> If a person has had the opportunity to comment on a patch, but has not >> provided such comments, you may optionally add a ``Cc:`` tag to the patch. >> This tag documents that potentially interested parties have been included in >> the discussion. >> >> If you look through the git logs of Linux, Cc tags are really not a >> regular occurrence except those marking patches as suitable for >> backporting to stable. > If people want to handle CC lists by putting it in the patches (it's > what I do when I have no cover letter) just put them after the --- line > and git send-email will still pick the CCs up but they won't end up in > the history. Oh yes, that was my mistake. The CCs were never intended to make it to the final commits. Thanks! Michael. -- Michael Opdenacker Root Commit Yocto Project and OpenEmbedded Training course - Learn by doing: https://rootcommit.com/training/yocto/ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-10-24 5:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20251022201807.1474789-1-michael.opdenacker@rootcommit.com>
2025-10-22 20:18 ` [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2 michael.opdenacker
2025-10-22 22:14 ` Yixun Lan
2025-10-23 5:58 ` Vivian Wang
2025-10-23 18:30 ` Conor Dooley
2025-10-24 0:02 ` Yixun Lan
2025-10-24 5:36 ` Michael Opdenacker
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).