From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Gerd Bayer <gbayer@linux.ibm.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>,
Niklas Schnelle <schnelle@linux.ibm.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvme-pci: Print error message on failure in nvme_probe
Date: Wed, 22 Oct 2025 09:48:37 +0200 [thread overview]
Message-ID: <2025102230-omega-octopus-3cf1@gregkh> (raw)
In-Reply-To: <20251022062634.GA4790@lst.de>
On Wed, Oct 22, 2025 at 08:26:34AM +0200, Christoph Hellwig wrote:
> On Mon, Oct 20, 2025 at 05:29:07PM +0200, Gerd Bayer wrote:
> > Add a new error message like
> > nvme nvme0: probe failed on 2004:00:00.0 (result: -19)
> > that makes failures to probe visible in the kernel log.
>
> Is that really a thing drivers are expected to do? If it is generally
> usefull I'd expect it to be in the driver core.
We have that already, dev_err_probe(), no need to create
yet-another-version of that.
thanks,
greg k-h
next prev parent reply other threads:[~2025-10-22 7:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 15:29 [PATCH 0/2] nvme-pci: Log failures to probe Gerd Bayer
2025-10-20 15:29 ` [PATCH 1/2] nvme-pci: Print error message on failure in nvme_probe Gerd Bayer
2025-10-22 6:22 ` Wilfred Mallawa
2025-10-22 6:26 ` Christoph Hellwig
2025-10-22 7:48 ` Greg Kroah-Hartman [this message]
2025-10-22 8:20 ` Gerd Bayer
2025-10-20 15:29 ` [PATCH 2/2] nvme-pci: Add debug message on fail to read CSTS Gerd Bayer
2025-10-20 23:34 ` Chaitanya Kulkarni
2025-10-22 6:24 ` Wilfred Mallawa
2025-10-22 6:27 ` Christoph Hellwig
2025-10-22 8:21 ` Gerd Bayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102230-omega-octopus-3cf1@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=gbayer@linux.ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox