From: Greg KH <gregkh@linuxfoundation.org>
To: Vincent Liu <vincent.liu@nutanix.com>
Cc: "dakr@kernel.org" <dakr@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v2] driver core: Check drivers_autoprobe for all added devices
Date: Wed, 22 Oct 2025 12:32:00 +0200 [thread overview]
Message-ID: <2025102252-nearest-hangover-5346@gregkh> (raw)
In-Reply-To: <6ECEA944-12A6-43C0-A4F4-F73F73FDDACE@nutanix.com>
On Tue, Oct 21, 2025 at 12:49:21PM +0000, Vincent Liu wrote:
> > On 14 Oct 2025, at 13:10, Vincent Liu <vincent.liu@nutanix.com> wrote:
> >
> > On 14 Oct 2025, at 06:14, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> >> What commit id does this fix?
> >
> > I am not entirely sure if there is a particular commit that causes this issue,
> > the device_attach call was added in pci/bus.c 58d9a38f6fac, and then the
> > device_add was removed in 4f535093cf8f6. At this point I think the
> > drivers_autoprobe stopped working because driver_attach that’s left in
> > pci_bus_add_device does not check for that.
> >
> > The drivers_autoprobe check in base/bus.c has been there a long time
> > since b8c5cec23d5c.
> >
> >> What devices cause this to happen today that are seeing this issue?
> >
> > I am observing this for hot-plugged PCIe devices and VFs.
> >
> >> Should this be backported to older kernels?
> >
> > I suppose not since this was not working for a long time?
> >
>
> Are you happy with this reply Greg? Do you want me to update the commit
> message to include some of these commit ids?
Please do.
next prev parent reply other threads:[~2025-10-22 10:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 15:15 [PATCH] PCI: Check drivers_autoprobe for all added devices Vincent Liu
2025-10-02 5:55 ` Greg Kroah-Hartman
2025-10-02 12:04 ` [PATCH] driver core: " Vincent Liu
2025-10-13 18:14 ` [PATCH v2] driver core: " Vincent Liu
2025-10-14 5:14 ` Greg KH
2025-10-14 12:10 ` Vincent Liu
2025-10-21 12:49 ` Vincent Liu
2025-10-22 10:32 ` Greg KH [this message]
2025-10-14 20:07 ` Bjorn Helgaas
2025-10-15 10:23 ` Vincent Liu
2025-10-15 16:53 ` Bjorn Helgaas
2025-10-22 12:07 ` [PATCH v3] " Vincent Liu
2025-11-04 13:16 ` Vincent Liu
2025-11-20 17:00 ` [PATCH v3 RESEND] " Vincent Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102252-nearest-hangover-5346@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=vincent.liu@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox