Re: [PATCH v2 1/1] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]

On Thu, Oct 23, 2025 at 01:58:22PM +0800, Vivian Wang wrote:
> Thank you so much for the patch and testing results. Only some nitpicks
> follow.
> 
> On 10/23/25 04:18, michael.opdenacker@rootcommit.com wrote:
> > From: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> >
> > The OrangePi RV2 board ships two RGMII ethernet ports.
> > Each has an external Motorcomm YT8531C PHY attached, the PHY uses GPIO
> > for reset pin control.
> >
> > Enable PDMA for the SpacemiT K1-based SoC in the OrangePi RV2 board.
> >
> > Signed-off-by: Michael Opdenacker <michael.opdenacker@rootcommit.com>
> > CC: Emil Renner Berthing <emil.renner.berthing@gmail.com>
> > CC: Yixun Lan <dlan@gentoo.org>
> > CC: Vivian Wang <wangruikang@iscas.ac.cn>
> 
> Firstly, it is usually spelt "Cc:", with one upper-case C and one
> lower-case c.

I don't think this matters at all, the git tooling at least doesn't
care.

> Secondly, "Cc:" should not be necessary in the patch/commit message.
> From Documentation/process/submitting-patches.rst:
> 
>     If a person has had the opportunity to comment on a patch, but has not
>     provided such comments, you may optionally add a ``Cc:`` tag to the patch.
>     This tag documents that potentially interested parties have been included in
>     the discussion.
> 
> If you look through the git logs of Linux, Cc tags are really not a
> regular occurrence except those marking patches as suitable for
> backporting to stable.

If people want to handle CC lists by putting it in the patches (it's
what I do when I have no cover letter) just put them after the --- line
and git send-email will still pick the CCs up but they won't end up in
the history.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]