From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: tglx@linutronix.de
Cc: peterz@infradead.org, broonie@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] genirq/chip: Add buslock back in to irq_set_handler()
Date: Thu, 23 Oct 2025 16:48:59 +0100 [thread overview]
Message-ID: <20251023154901.1333755-2-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20251023154901.1333755-1-ckeepax@opensource.cirrus.com>
The locking was changed from a buslock to a plain lock, but the patch
description states there was no functional change. Assuming this was
accidental so reverting to using the buslock.
Fixes: 5cd05f3e2315 ("genirq/chip: Rework irq_set_handler() variants")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
kernel/irq/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 3ffa0d80ddd19..d1917b28761a3 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1030,7 +1030,7 @@ __irq_do_set_handler(struct irq_desc *desc, irq_flow_handler_t handle,
void __irq_set_handler(unsigned int irq, irq_flow_handler_t handle, int is_chained,
const char *name)
{
- scoped_irqdesc_get_and_lock(irq, 0)
+ scoped_irqdesc_get_and_buslock(irq, 0)
__irq_do_set_handler(scoped_irqdesc, handle, is_chained, name);
}
EXPORT_SYMBOL_GPL(__irq_set_handler);
--
2.47.3
next prev parent reply other threads:[~2025-10-23 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 15:48 [PATCH 0/3] Fix some accidentally dropped IRQ buslocks Charles Keepax
2025-10-23 15:48 ` Charles Keepax [this message]
2025-10-24 9:44 ` [tip: irq/urgent] genirq/chip: Add buslock back in to irq_set_handler() tip-bot2 for Charles Keepax
2025-10-23 15:49 ` [PATCH 2/3] genirq/manage: Add buslock back in to __disable_irq_nosync() Charles Keepax
2025-10-24 9:44 ` [tip: irq/urgent] " tip-bot2 for Charles Keepax
2025-10-23 15:49 ` [PATCH 3/3] genirq/manage: Add buslock back in to enable_irq() Charles Keepax
2025-10-24 9:44 ` [tip: irq/urgent] " tip-bot2 for Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023154901.1333755-2-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox