From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Shyam-sundar.S-k@amd.com, bhelgaas@google.com,
hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
jdelvare@suse.com, linux-edac@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux@roeck-us.net,
mario.limonciello@amd.com, naveenkrishna.chatradhi@amd.com,
platform-driver-x86@vger.kernel.org, suma.hegde@amd.com,
tony.luck@intel.com, x86@kernel.org
Subject: Re: [PATCH v3 06/12] x86/amd_nb: Use topology info to get AMD node count
Date: Thu, 23 Oct 2025 12:09:06 -0400 [thread overview]
Message-ID: <20251023160906.GA730672@yaz-khff2.amd.com> (raw)
In-Reply-To: <20251023170107.0cc70bad.michal.pecio@gmail.com>
On Thu, Oct 23, 2025 at 05:01:07PM +0200, Michal Pecio wrote:
> On Thu, 23 Oct 2025 09:59:35 -0400, Yazen Ghannam wrote:
> > Thanks Michal.
> >
> > I don't see anything obviously wrong.
>
> Which code is responsible for setting up those bitmaps which
> are counted by topology_init_possible_cpus()?
>
> I guess I could add some printks there and reboot.
>
The kernel seems to think there are 6 CPUs on your system:
[ 0.072059] CPU topo: Allowing 4 present CPUs plus 2 hotplug CPUs
We don't seem them enabled, but they may still get APIC IDs. If so, then
the IDs would be beyond the core shift of 2.
APIC IDs b'0 00 -> CPU0 on logical package 0
b'0 01 -> CPU1 on logical package 0
b'0 10 -> CPU2 on logical package 0
b'0 11 -> CPU3 on logical package 0
b'1 00 -> CPU0 on logical package 1
b'1 01 -> CPU1 on logical package 1
Please try booting with "possible_cpus=4".
The "number of possible CPUs" comes from the ACPI Multiple APIC
Description Table (MADT). This has the signature "APIC".
Can you please provide the disassembly of this table?
You can use the following commands:
1) Dump the ACPI tables to binaries: "sudo acpidump -b"
2) Disassemble the APIC table: "iasl -d apic.dat"
Both commands are part of the "acpica-tools" package.
[...]
>
> BTW, I forgot to mention that I have a second seemingly identical
> board with same BIOS running Phenom X6 1090T. It is not affected.
> Not sure if this is helpful. I haven't tried swapping CPUs.
Can you please share the dmesg output from that system? And the ACPI
table too?
If the BIOS is the same, then I wonder if they hardcoded 6 CPUs in the
MADT then mark the extras as "not enabled" on parts with lower cores.
Thanks,
Yazen
next prev parent reply other threads:[~2025-10-23 16:09 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 22:28 [PATCH v3 00/12] AMD NB and SMN rework Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 01/12] x86/amd_nb: Restrict init function to AMD-based systems Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 02/12] x86/amd_nb: Clean up early_is_amd_nb() Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 03/12] x86: Start moving AMD node functionality out of AMD_NB Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 04/12] x86/amd_nb: Simplify function 4 search Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 05/12] x86/amd_nb: Simplify root device search Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 06/12] x86/amd_nb: Use topology info to get AMD node count Yazen Ghannam
2025-01-09 9:15 ` [tip: x86/misc] " tip-bot2 for Yazen Ghannam
2025-10-21 23:16 ` [PATCH v3 06/12] " Michal Pecio
2025-10-22 13:39 ` Yazen Ghannam
2025-10-22 15:38 ` Michal Pecio
2025-10-22 16:04 ` Guenter Roeck
2025-10-22 16:09 ` Yazen Ghannam
2025-10-22 16:18 ` Michal Pecio
2025-10-23 13:59 ` Yazen Ghannam
2025-10-23 15:01 ` Michal Pecio
2025-10-23 16:09 ` Yazen Ghannam [this message]
2025-10-23 16:22 ` Mario Limonciello
2025-10-23 17:06 ` Michal Pecio
2025-10-23 17:12 ` Mario Limonciello
2025-10-23 18:25 ` Yazen Ghannam
2025-10-23 21:43 ` Mario Limonciello
2025-10-23 16:31 ` Michal Pecio
2025-10-23 18:15 ` Yazen Ghannam
2025-10-23 18:25 ` Michal Pecio
2025-10-23 19:04 ` Yazen Ghannam
2025-10-23 19:09 ` Yazen Ghannam
2025-10-24 8:48 ` Michal Pecio
2025-10-24 13:42 ` Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 07/12] x86/amd_nb: Simplify function 3 search Yazen Ghannam
2025-01-09 9:15 ` [tip: x86/misc] " tip-bot2 for Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 08/12] x86/amd_nb, hwmon: (k10temp): Simplify amd_pci_dev_to_node_id() Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 09/12] x86/amd_nb: Move SMN access code to a new amd_node driver Yazen Ghannam
2025-01-08 5:30 ` Shyam Sundar S K
2025-01-08 8:56 ` Borislav Petkov
2025-01-07 22:28 ` [PATCH v3 10/12] x86/amd_node: Update __amd_smn_rw() error paths Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 11/12] x86/amd_node: Remove dependency on AMD_NB Yazen Ghannam
2025-01-07 22:28 ` [PATCH v3 12/12] x86/amd_node: Use defines for SMN register offsets Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023160906.GA730672@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bhelgaas@google.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mario.limonciello@amd.com \
--cc=michal.pecio@gmail.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox