public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shenwei Wang <shenwei.wang@nxp.com>,
	Richard Cochran <richardcochran@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Josua Mayer <josua@solid-run.com>
Subject: Re: [PATCH 2/8] arm64: dts: imx8dxl-ss-conn: swap interrupts number of eqos
Date: Fri, 24 Oct 2025 11:18:03 +0200	[thread overview]
Message-ID: <20251024-backhand-disallow-75be98bbeea3@thorsis.com> (raw)
In-Reply-To: <20251022-dxl_dts-v1-2-8159dfdef8c5@nxp.com>

Hello Frank,

Am Wed, Oct 22, 2025 at 12:50:22PM -0400 schrieb Frank Li:
> Swap interrupt numbers of eqos because the below commit just swap
> interrupt-names and missed swap interrupts also.
> 
> The driver (drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c) use
> interrupt-names to get irq numbers.

This catched my eye, because we are using a SolidRun i.MX 8XLite
System-on-Module on a custom baseboard which uses that SoC.

I had problems with one CPU core stalling when doing network traffic
over the 'end1' interface, which is that eqos interface here.  All I
could see so far were an excessive number of hardware interrupts in
/proc/interrupts for end1.  With this patch this behaviour is gone, I
could not reproduce those lock-up anymore.  Thank you and FWIW:

Tested-by: Alexander Dahl <ada@thorsis.com>

Note: I applied this to v6.12.  The patch has a Fixes: tag, so I
assume it hits stable once it got merged without further action,
right?

Adding Josua Mayer to Cc because it might affect other users of that
SoM.  Josua, would it be possible to upstream the dts/dtsi files for
that SoM? O:-)

Greets
Alex

> 
> Fixes: f29c19a6e488 ("arm64: dts: imx8dxl-ss-conn: Fix Ethernet interrupt-names order")
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
> index a66ba6d0a8c05646320dc45e460662ab0ae2aa3b..da33a35c6d4660ebf0fa3f7afcf7f7a289c3c419 100644
> --- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-conn.dtsi
> @@ -29,8 +29,8 @@ eqos: ethernet@5b050000 {
>  		compatible = "nxp,imx8dxl-dwmac-eqos", "snps,dwmac-5.10a";
>  		reg = <0x5b050000 0x10000>;
>  		interrupt-parent = <&gic>;
> -		interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
> -			     <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-names = "macirq", "eth_wake_irq";
>  		clocks = <&eqos_lpcg IMX_LPCG_CLK_4>,
>  			 <&eqos_lpcg IMX_LPCG_CLK_6>,
> 
> -- 
> 2.34.1
> 
> 

  reply	other threads:[~2025-10-24  9:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 16:50 [PATCH 0/8] arm64: dts: imx8dxl related fix and minor update Frank Li
2025-10-22 16:50 ` [PATCH 1/8] arm64: dts: imx8dxl: Correct pcie-ep interrupt number Frank Li
2025-10-22 16:50 ` [PATCH 2/8] arm64: dts: imx8dxl-ss-conn: swap interrupts number of eqos Frank Li
2025-10-24  9:18   ` Alexander Dahl [this message]
2025-10-22 16:50 ` [PATCH 3/8] arm64: dts: imx8dxl-evk: add bt information for lpuart1 Frank Li
2025-10-22 16:50 ` [PATCH 4/8] arm64: dts: imx8dxl-evk: add state_100mhz and state_200mhz for usdhc Frank Li
2025-10-22 16:50 ` [PATCH 5/8] arm64: dts: imx8: add default clock rate " Frank Li
2025-10-22 16:50 ` [PATCH 6/8] arm64: dts: imx8-ss-conn: add fsl,tuning-step for usdhc1 and usdhc2 Frank Li
2025-10-22 16:50 ` [PATCH 7/8] arm64: dts: imx8-ss-conn: add missed clock enet_2x_txclk for fec[1,2] Frank Li
2025-10-22 16:50 ` [PATCH 8/8] arm64: dts: imx8dxl-ss-conn: delete usb3_lpcg node Frank Li
2025-11-11  7:25 ` [PATCH 0/8] arm64: dts: imx8dxl related fix and minor update Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024-backhand-disallow-75be98bbeea3@thorsis.com \
    --to=ada@thorsis.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=josua@solid-run.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shenwei.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox