public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <frederic@kernel.org>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>
Subject: [PATCH 6/6] timers/migration: Remove dead code handling idle CPU checking for remote timers
Date: Fri, 24 Oct 2025 15:25:36 +0200	[thread overview]
Message-ID: <20251024132536.39841-7-frederic@kernel.org> (raw)
In-Reply-To: <20251024132536.39841-1-frederic@kernel.org>

Idle migrators don't walk the whole tree in order to find out if there
are timers to migrate because they recorded the next deadline to be
verified within a single check in tmigr_requires_handle_remote().

Remove the related dead code and data.

Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
---
 kernel/time/timer_migration.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
index 73d9b0648116..19ddfa96b9df 100644
--- a/kernel/time/timer_migration.c
+++ b/kernel/time/timer_migration.c
@@ -504,11 +504,6 @@ static bool tmigr_check_lonely(struct tmigr_group *group)
  * @now:		timer base monotonic
  * @check:		is set if there is the need to handle remote timers;
  *			required in tmigr_requires_handle_remote() only
- * @tmc_active:		this flag indicates, whether the CPU which triggers
- *			the hierarchy walk is !idle in the timer migration
- *			hierarchy. When the CPU is idle and the whole hierarchy is
- *			idle, only the first event of the top level has to be
- *			considered.
  */
 struct tmigr_walk {
 	u64			nextexp;
@@ -519,7 +514,6 @@ struct tmigr_walk {
 	unsigned long		basej;
 	u64			now;
 	bool			check;
-	bool			tmc_active;
 };
 
 typedef bool (*up_f)(struct tmigr_group *, struct tmigr_group *, struct tmigr_walk *);
@@ -1119,15 +1113,6 @@ static bool tmigr_requires_handle_remote_up(struct tmigr_group *group,
 	 */
 	if (!tmigr_check_migrator(group, childmask))
 		return true;
-
-	/*
-	 * When there is a parent group and the CPU which triggered the
-	 * hierarchy walk is not active, proceed the walk to reach the top level
-	 * group before reading the next_expiry value.
-	 */
-	if (group->parent && !data->tmc_active)
-		return false;
-
 	/*
 	 * The lock is required on 32bit architectures to read the variable
 	 * consistently with a concurrent writer. On 64bit the lock is not
@@ -1172,7 +1157,6 @@ bool tmigr_requires_handle_remote(void)
 	data.now = get_jiffies_update(&jif);
 	data.childmask = tmc->groupmask;
 	data.firstexp = KTIME_MAX;
-	data.tmc_active = !tmc->idle;
 	data.check = false;
 
 	/*
-- 
2.51.0


  parent reply	other threads:[~2025-10-24 13:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-24 13:25 [PATCH 0/6] timers/migration: Fix NUMA trees + cleanups Frederic Weisbecker
2025-10-24 13:25 ` [PATCH 1/6] timers/migration: Convert "while" loops to use "for" Frederic Weisbecker
2025-11-01 19:41   ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2025-10-24 13:25 ` [PATCH 2/6] timers/migration: Remove locking on group connection Frederic Weisbecker
2025-11-01 19:41   ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2025-10-24 13:25 ` [PATCH 3/6] timers/migration: Fix imbalanced NUMA trees Frederic Weisbecker
2025-11-01 19:41   ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2025-10-24 13:25 ` [PATCH 4/6] timers/migration: Assert that hotplug preparing CPU is part of stable active hierarchy Frederic Weisbecker
2025-11-01 19:41   ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2025-10-24 13:25 ` [PATCH 5/6] timers/migration: Remove unused "cpu" parameter from tmigr_get_group() Frederic Weisbecker
2025-11-01 19:41   ` [tip: timers/core] " tip-bot2 for Frederic Weisbecker
2025-10-24 13:25 ` Frederic Weisbecker [this message]
2025-11-01 19:41   ` [tip: timers/core] timers/migration: Remove dead code handling idle CPU checking for remote timers tip-bot2 for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251024132536.39841-7-frederic@kernel.org \
    --to=frederic@kernel.org \
    --cc=anna-maria@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox