Re: [PATCH v3 10/31] media: staging: media: imx6-mipi-csi2: use devm_platform_ioremap_resource() simplify code

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Thu, Aug 21, 2025 at 04:15:45PM -0400, Frank Li wrote:
> Use devm_platform_ioremap_resource() simplify code. No functional change.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  drivers/staging/media/imx/imx6-mipi-csi2.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c
> index b04c1b98c088b8bfa66eb3f61cca8bb735b7eae4..7b8911bea3fad8187fafb1d0916d730fd6fa671c 100644
> --- a/drivers/staging/media/imx/imx6-mipi-csi2.c
> +++ b/drivers/staging/media/imx/imx6-mipi-csi2.c
> @@ -738,7 +738,6 @@ static void csi2_nf_cleanup(void *data)
>  static int csi2_probe(struct platform_device *pdev)
>  {
>  	struct csi2_dev *csi2;
> -	struct resource *res;
>  	int i, ret;
>  
>  	csi2 = devm_kzalloc(&pdev->dev, sizeof(*csi2), GFP_KERNEL);
> @@ -772,15 +771,10 @@ static int csi2_probe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res) {
> -		v4l2_err(&csi2->sd, "failed to get platform resources\n");
> -		return -ENODEV;
> -	}
> -
> -	csi2->base = devm_ioremap(&pdev->dev, res->start, PAGE_SIZE);
> -	if (!csi2->base)
> -		return -ENOMEM;
> +	csi2->base = devm_platform_ioremap_resource(pdev, 0);
> +	if (IS_ERR(csi2->base))
> +		return dev_err_probe(&pdev->dev, -ENOMEM,
> +				     "failed to get platform resources");

devm_platform_ioremap_resource() prints error messages internally with
dev_err_probe(), so you can just

		return PTR_ERR(csi2->base);

here. With that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  
>  	ret = devm_mutex_init(&pdev->dev, &csi2->lock);
>  	if (ret)
> 

-- 
Regards,

Laurent Pinchart