public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Michael Jeanson <mjeanson@efficios.com>,
	Jens Axboe <axboe@kernel.dk>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	x86@kernel.org, Sean Christopherson <seanjc@google.com>,
	Wei Liu <wei.liu@kernel.org>
Subject: [patch V6 03/31] rseq: Move algorithm comment to top
Date: Mon, 27 Oct 2025 09:44:20 +0100 (CET)	[thread overview]
Message-ID: <20251027084306.149519580@linutronix.de> (raw)
In-Reply-To: 20251027084220.785525188@linutronix.de

Move the comment which documents the RSEQ algorithm to the top of the file,
so it does not create horrible diffs later when the actual implementation
is fed into the mincer.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

---
 kernel/rseq.c |  119 ++++++++++++++++++++++++++++------------------------------
 1 file changed, 59 insertions(+), 60 deletions(-)
--- a/kernel/rseq.c
+++ b/kernel/rseq.c
@@ -8,6 +8,65 @@
  * Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
  */
 
+/*
+ * Restartable sequences are a lightweight interface that allows
+ * user-level code to be executed atomically relative to scheduler
+ * preemption and signal delivery. Typically used for implementing
+ * per-cpu operations.
+ *
+ * It allows user-space to perform update operations on per-cpu data
+ * without requiring heavy-weight atomic operations.
+ *
+ * Detailed algorithm of rseq user-space assembly sequences:
+ *
+ *                     init(rseq_cs)
+ *                     cpu = TLS->rseq::cpu_id_start
+ *   [1]               TLS->rseq::rseq_cs = rseq_cs
+ *   [start_ip]        ----------------------------
+ *   [2]               if (cpu != TLS->rseq::cpu_id)
+ *                             goto abort_ip;
+ *   [3]               <last_instruction_in_cs>
+ *   [post_commit_ip]  ----------------------------
+ *
+ *   The address of jump target abort_ip must be outside the critical
+ *   region, i.e.:
+ *
+ *     [abort_ip] < [start_ip]  || [abort_ip] >= [post_commit_ip]
+ *
+ *   Steps [2]-[3] (inclusive) need to be a sequence of instructions in
+ *   userspace that can handle being interrupted between any of those
+ *   instructions, and then resumed to the abort_ip.
+ *
+ *   1.  Userspace stores the address of the struct rseq_cs assembly
+ *       block descriptor into the rseq_cs field of the registered
+ *       struct rseq TLS area. This update is performed through a single
+ *       store within the inline assembly instruction sequence.
+ *       [start_ip]
+ *
+ *   2.  Userspace tests to check whether the current cpu_id field match
+ *       the cpu number loaded before start_ip, branching to abort_ip
+ *       in case of a mismatch.
+ *
+ *       If the sequence is preempted or interrupted by a signal
+ *       at or after start_ip and before post_commit_ip, then the kernel
+ *       clears TLS->__rseq_abi::rseq_cs, and sets the user-space return
+ *       ip to abort_ip before returning to user-space, so the preempted
+ *       execution resumes at abort_ip.
+ *
+ *   3.  Userspace critical section final instruction before
+ *       post_commit_ip is the commit. The critical section is
+ *       self-terminating.
+ *       [post_commit_ip]
+ *
+ *   4.  <success>
+ *
+ *   On failure at [2], or if interrupted by preempt or signal delivery
+ *   between [1] and [3]:
+ *
+ *       [abort_ip]
+ *   F1. <failure>
+ */
+
 #include <linux/sched.h>
 #include <linux/uaccess.h>
 #include <linux/syscalls.h>
@@ -98,66 +157,6 @@ static int rseq_validate_ro_fields(struc
 	unsafe_put_user(value, &t->rseq->field, error_label)
 #endif
 
-/*
- *
- * Restartable sequences are a lightweight interface that allows
- * user-level code to be executed atomically relative to scheduler
- * preemption and signal delivery. Typically used for implementing
- * per-cpu operations.
- *
- * It allows user-space to perform update operations on per-cpu data
- * without requiring heavy-weight atomic operations.
- *
- * Detailed algorithm of rseq user-space assembly sequences:
- *
- *                     init(rseq_cs)
- *                     cpu = TLS->rseq::cpu_id_start
- *   [1]               TLS->rseq::rseq_cs = rseq_cs
- *   [start_ip]        ----------------------------
- *   [2]               if (cpu != TLS->rseq::cpu_id)
- *                             goto abort_ip;
- *   [3]               <last_instruction_in_cs>
- *   [post_commit_ip]  ----------------------------
- *
- *   The address of jump target abort_ip must be outside the critical
- *   region, i.e.:
- *
- *     [abort_ip] < [start_ip]  || [abort_ip] >= [post_commit_ip]
- *
- *   Steps [2]-[3] (inclusive) need to be a sequence of instructions in
- *   userspace that can handle being interrupted between any of those
- *   instructions, and then resumed to the abort_ip.
- *
- *   1.  Userspace stores the address of the struct rseq_cs assembly
- *       block descriptor into the rseq_cs field of the registered
- *       struct rseq TLS area. This update is performed through a single
- *       store within the inline assembly instruction sequence.
- *       [start_ip]
- *
- *   2.  Userspace tests to check whether the current cpu_id field match
- *       the cpu number loaded before start_ip, branching to abort_ip
- *       in case of a mismatch.
- *
- *       If the sequence is preempted or interrupted by a signal
- *       at or after start_ip and before post_commit_ip, then the kernel
- *       clears TLS->__rseq_abi::rseq_cs, and sets the user-space return
- *       ip to abort_ip before returning to user-space, so the preempted
- *       execution resumes at abort_ip.
- *
- *   3.  Userspace critical section final instruction before
- *       post_commit_ip is the commit. The critical section is
- *       self-terminating.
- *       [post_commit_ip]
- *
- *   4.  <success>
- *
- *   On failure at [2], or if interrupted by preempt or signal delivery
- *   between [1] and [3]:
- *
- *       [abort_ip]
- *   F1. <failure>
- */
-
 static int rseq_update_cpu_node_id(struct task_struct *t)
 {
 	struct rseq __user *rseq = t->rseq;


  parent reply	other threads:[~2025-10-27  8:44 UTC|newest]

Thread overview: 142+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27  8:44 [patch V6 00/31] rseq: Optimize exit to user space Thomas Gleixner
2025-10-27  8:44 ` [patch V6 01/31] rseq: Avoid pointless evaluation in __rseq_notify_resume() Thomas Gleixner
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 02/31] rseq: Condense the inline stubs Thomas Gleixner
2025-10-29 10:24   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` Thomas Gleixner [this message]
2025-10-29 10:24   ` [tip: core/rseq] rseq: Move algorithm comment to top tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 04/31] rseq: Remove the ksig argument from rseq_handle_notify_resume() Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 05/31] rseq: Simplify registration Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 06/31] rseq: Simplify the event notification Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 07/31] rseq, virt: Retrigger RSEQ after vcpu_run() Thomas Gleixner
2025-10-28 15:08   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 08/31] rseq: Avoid CPU/MM CID updates when no event pending Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 09/31] rseq: Introduce struct rseq_data Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 10/31] entry: Cleanup header Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` [tip: core/rseq] entry: Clean up header tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 11/31] entry: Remove syscall_enter_from_user_mode_prepare() Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 12/31] entry: Inline irqentry_enter/exit_from/to_user_mode() Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 13/31] sched: Move MM CID related functions to sched.h Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 14/31] rseq: Cache CPU ID and MM CID values Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 15/31] rseq: Record interrupt from user space Thomas Gleixner
2025-10-28 15:26   ` Mathieu Desnoyers
2025-10-28 17:02     ` Thomas Gleixner
2025-10-28 17:53       ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 16/31] rseq: Provide tracepoint wrappers for inline code Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 17/31] rseq: Expose lightweight statistics in debugfs Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 18/31] rseq: Provide static branch for runtime debugging Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:44 ` [patch V6 19/31] rseq: Provide and use rseq_update_user_cs() Thomas Gleixner
2025-10-28 15:40   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-29 16:04   ` [patch V6 19/31] " Steven Rostedt
2025-10-29 21:00     ` Thomas Gleixner
2025-10-29 21:53       ` Steven Rostedt
2025-11-03 14:47   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 20/31] rseq: Replace the original debug implementation Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-30 21:52   ` [patch V6 20/31] " Prakash Sangappa
2025-10-31 14:27     ` Thomas Gleixner
2025-11-03 14:47   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 21/31] rseq: Make exit debugging static branch based Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 22/31] rseq: Use static branch for syscall exit debug when GENERIC_IRQ_ENTRY=y Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 23/31] rseq: Provide and use rseq_set_ids() Thomas Gleixner
2025-10-28 15:47   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 24/31] rseq: Separate the signal delivery path Thomas Gleixner
2025-10-28 15:51   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 25/31] rseq: Rework the TIF_NOTIFY handler Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:17   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 26/31] rseq: Optimize event setting Thomas Gleixner
2025-10-28 15:57   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:16   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 27/31] rseq: Implement fast path for exit to user Thomas Gleixner
2025-10-28 16:09   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-10-29 16:28   ` [patch V6 27/31] " Steven Rostedt
2025-11-03 14:47   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-04  8:16   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 28/31] rseq: Switch to fast path processing on " Thomas Gleixner
2025-10-28 16:14   ` Mathieu Desnoyers
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:16   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 29/31] entry: Split up exit_to_user_mode_prepare() Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:16   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 30/31] rseq: Split up rseq_exit_to_user_mode() Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:16   ` tip-bot2 for Thomas Gleixner
2025-10-27  8:45 ` [patch V6 31/31] rseq: Switch to TIF_RSEQ if supported Thomas Gleixner
2025-10-29 10:23   ` [tip: core/rseq] " tip-bot2 for Thomas Gleixner
2025-11-03 14:47   ` tip-bot2 for Thomas Gleixner
2025-11-04  8:16   ` tip-bot2 for Thomas Gleixner
2025-10-29 10:23 ` [patch V6 00/31] rseq: Optimize exit to user space Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251027084306.149519580@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mjeanson@efficios.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=seanjc@google.com \
    --cc=wei.liu@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox