* [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building
@ 2025-10-27 10:05 Andy Shevchenko
2025-10-27 11:15 ` Aaron Lu
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2025-10-27 10:05 UTC (permalink / raw)
To: Peter Zijlstra, linux-kernel, llvm
Cc: Ingo Molnar, Juri Lelli, Vincent Guittot, Dietmar Eggemann,
Steven Rostedt, Ben Segall, Mel Gorman, Valentin Schneider,
Nathan Chancellor, Nick Desaulniers, Bill Wendling, Justin Stitt,
Aaron Lu, Andy Shevchenko
Clang, in particular, is not happy about dead code:
kernel/sched/fair.c:5233:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
5233 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
| ^~~~~~~~~~~~~~~~
1 error generated.
kernel/sched/fair.c:6736:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
6736 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
| ^~~~~~~~~~~~~~~~
1 error generated.
Remove a leftover from the previous cleanup.
Fixes: fe8d238e646e ("sched/fair: Propagate load for throttled cfs_rq")
Fixes: eb962f251fbb ("sched/fair: Task based throttle time accounting")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
kernel/sched/fair.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 273e2871b59e..0370f11e5c25 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5230,7 +5230,6 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)
}
static void check_enqueue_throttle(struct cfs_rq *cfs_rq);
-static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
static void
requeue_delayed_entity(struct sched_entity *se);
@@ -6733,11 +6732,6 @@ static void dequeue_throttled_task(struct task_struct *p, int flags) {}
static bool enqueue_throttled_task(struct task_struct *p) { return false; }
static void record_throttle_clock(struct cfs_rq *cfs_rq) {}
-static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
-{
- return 0;
-}
-
static inline bool cfs_rq_pelt_clock_throttled(struct cfs_rq *cfs_rq)
{
return false;
--
2.50.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building
2025-10-27 10:05 [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building Andy Shevchenko
@ 2025-10-27 11:15 ` Aaron Lu
0 siblings, 0 replies; 2+ messages in thread
From: Aaron Lu @ 2025-10-27 11:15 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Peter Zijlstra, linux-kernel, llvm, Ingo Molnar, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Valentin Schneider, Nathan Chancellor,
Nick Desaulniers, Bill Wendling, Justin Stitt
On Mon, Oct 27, 2025 at 11:05:29AM +0100, Andy Shevchenko wrote:
> Clang, in particular, is not happy about dead code:
>
> kernel/sched/fair.c:5233:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
> 5233 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq);
> | ^~~~~~~~~~~~~~~~
> 1 error generated.
>
> kernel/sched/fair.c:6736:19: error: unused function 'cfs_rq_throttled' [-Werror,-Wunused-function]
> 6736 | static inline int cfs_rq_throttled(struct cfs_rq *cfs_rq)
> | ^~~~~~~~~~~~~~~~
> 1 error generated.
>
> Remove a leftover from the previous cleanup.
>
> Fixes: fe8d238e646e ("sched/fair: Propagate load for throttled cfs_rq")
> Fixes: eb962f251fbb ("sched/fair: Task based throttle time accounting")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Aaron Lu <ziqianlu@bytedance.com>
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-27 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 10:05 [PATCH v1 1/1] sched/fair: Remove dead code which might prevent from building Andy Shevchenko
2025-10-27 11:15 ` Aaron Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox