* [PATCH v6 0/4] Add DisplayPort support to QCS615 devicetree
@ 2025-10-24 5:21 Xiangxu Yin via B4 Relay
2025-10-24 5:21 ` [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller Xiangxu Yin via B4 Relay
` (3 more replies)
0 siblings, 4 replies; 18+ messages in thread
From: Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
fange.zhang, yongxing.mou, li.liu, Xiangxu Yin, Dmitry Baryshkov,
Konrad Dybcio
This series enables DisplayPort functionality on QCS615 platforms.
It introduces the required bindings, updates SM6150 dtsi for DP controller
and QMP USB3-DP PHY, and enables DP on the QCS615 Ride board with
connector and link configuration.
Depends-on:
https://lore.kernel.org/all/20250903-add-display-support-for-qcs615-platform-v8-1-7971c05d1262@oss.qualcomm.com/
https://lore.kernel.org/all/20250916-add-dp-controller-support-for-sm6150-v3-1-dd60ebbd101e@oss.qualcomm.com/
https://lore.kernel.org/all/20250926-add-displayport-support-for-qcs615-platform-v7-1-dc5edaac6c2b@oss.qualcomm.com/
Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
---
Changes in v6:
- Removed useless remote-endpoint addition from previous version. [Dmitry]
- Fix indentation and blank lines in dt-binding example.
- Fix OPP values to correct clock rates in dt-binding example.
- Fix blank lines between the last property and the following subnode [Konrad]
- Link to v5: https://lore.kernel.org/r/20251021-add-displayport-support-to-qcs615-devicetree-v5-0-92f0f3bf469f@oss.qualcomm.com
Changes in v5:
- Update commit message and fix example indentation in binding
- Update order in dtsi includes [Krzysztof]
- Link to v4: https://lore.kernel.org/r/20251015-add-displayport-support-to-qcs615-devicetree-v4-0-aa2cb8470e9d@oss.qualcomm.com
Changes in v4:
- Update commit message to reflect data-lanes changes.
- Link to v3: https://lore.kernel.org/r/20251014-add-displayport-support-to-qcs615-devicetree-v3-0-74ec96ba8144@oss.qualcomm.com
Changes in v3:
- Move data-lanes from board DTS to SoC DTS [Dmitry]
- Add missing assigned-clock PIXEL1_CLK_SRC [Dmitry]
- Update subject prefix to qcom: qcs615-ride: for DTS patch [Konrad]
- Link to v2: https://lore.kernel.org/r/20251014-add-displayport-support-to-qcs615-devicetree-v2-0-1209df74d410@oss.qualcomm.com
Changes in v2:
- Update register padding and ordering [Dmitry]
- Rebase the series on the latest driver
- Link to v1: https://lore.kernel.org/all/20241210-add-displayport-support-to-qcs615-devicetree-v1-0-02f84a92c44b@quicinc.com/
---
Xiangxu Yin (4):
dt-bindings: display: msm: Add SM6150 DisplayPort controller
dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values
arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150
arm64: dts: qcom: qcs615-ride: Enable DisplayPort
.../bindings/display/msm/qcom,sm6150-mdss.yaml | 42 +++++---
arch/arm64/boot/dts/qcom/qcs615-ride.dts | 30 ++++++
arch/arm64/boot/dts/qcom/sm6150.dtsi | 115 ++++++++++++++++++++-
3 files changed, 170 insertions(+), 17 deletions(-)
---
base-commit: efb26a23ed5f5dc3554886ab398f559dcb1de96b
change-id: 20251014-add-displayport-support-to-qcs615-devicetree-ecaad627a0fa
prerequisite-message-id: <20250903-add-display-support-for-qcs615-platform-v8-0-7971c05d1262@oss.qualcomm.com>
prerequisite-patch-id: 58be7053007469980bd7cc9fe315b66bbe021c31
prerequisite-patch-id: 3c2120117f72c64f69beff32c0239fbc7f808f36
prerequisite-message-id: <20250916-add-dp-controller-support-for-sm6150-v3-1-dd60ebbd101e@oss.qualcomm.com>
prerequisite-patch-id: eb07ea58347e77ee18fb6dade040affb0ab68954
prerequisite-message-id: <20250926-add-displayport-support-for-qcs615-platform-v7-0-dc5edaac6c2b@oss.qualcomm.com>
prerequisite-patch-id: 8c6c905df7ee55a92a4e52362c8fa7cd9742de04
prerequisite-patch-id: 0dba0fafd032bbd6cd117175f61efd1e56ae9228
prerequisite-patch-id: d954b18774cfc0cfdb23de09aab3c56cefb8e1ea
prerequisite-patch-id: 13f2d2efbcee6337001b5f8519a6da9a41d05276
prerequisite-patch-id: 3a7144645ede23ccc7d54420e5a32e5bfa3bb776
prerequisite-patch-id: b3ea55e92953c1526eaf7c5c21d939a5f8502711
prerequisite-patch-id: 977189ef7cecbe7237175a8ef611fffb814193b0
prerequisite-patch-id: 3a12c1b4f00eb1d074e51d586f2dae3a44de0613
prerequisite-patch-id: 7f80e93057c1fd088ac6b4b0652cdfe2ea221cd5
prerequisite-patch-id: 8b29d292717782982e4450a509f4428fe6e895f2
prerequisite-patch-id: 621c3ba6bcf5b5782a5264faed72fdadfd47c630
prerequisite-patch-id: 9c63f2c5bb39527e3031b2d168e3c9419441e8df
prerequisite-patch-id: 364f6a7d8f4e1bc79a8f236b8d5a2425ffd225fe
prerequisite-patch-id: eb09ea48625b5c0d39ffb37babe7d8c32a4b3122
Best regards,
--
Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-24 5:21 [PATCH v6 0/4] Add DisplayPort support to QCS615 devicetree Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 ` Xiangxu Yin via B4 Relay 2025-10-27 15:26 ` Rob Herring 2025-10-27 18:54 ` Bjorn Andersson 2025-10-24 5:21 ` [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values Xiangxu Yin via B4 Relay ` (2 subsequent siblings) 3 siblings, 2 replies; 18+ messages in thread From: Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 UTC (permalink / raw) To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Xiangxu Yin From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> SM6150 uses the same DisplayPort controller as SM8150, which is already compatible with SM8350. Add the SM6150-specific compatible string and update the binding example accordingly. Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> --- .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml @@ -51,6 +51,16 @@ patternProperties: compatible: const: qcom,sm6150-dpu + "^displayport-controller@[0-9a-f]+$": + type: object + additionalProperties: true + properties: + compatible: + items: + - const: qcom,sm6150-dp + - const: qcom,sm8150-dp + - const: qcom,sm8350-dp + "^dsi@[0-9a-f]+$": type: object additionalProperties: true -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-24 5:21 ` [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller Xiangxu Yin via B4 Relay @ 2025-10-27 15:26 ` Rob Herring 2025-10-28 5:06 ` Xiangxu Yin 2025-10-27 18:54 ` Bjorn Andersson 1 sibling, 1 reply; 18+ messages in thread From: Rob Herring @ 2025-10-27 15:26 UTC (permalink / raw) To: Xiangxu Yin Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin wrote: > SM6150 uses the same DisplayPort controller as SM8150, which is already > compatible with SM8350. Add the SM6150-specific compatible string and > update the binding example accordingly. > > Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > --- > .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > @@ -51,6 +51,16 @@ patternProperties: > compatible: > const: qcom,sm6150-dpu > > + "^displayport-controller@[0-9a-f]+$": > + type: object > + additionalProperties: true > + properties: > + compatible: > + items: > + - const: qcom,sm6150-dp > + - const: qcom,sm8150-dp > + - const: qcom,sm8350-dp The actual schema will check the order. Here, just: compatible: contains: const: qcom,sm6150-dp > + > "^dsi@[0-9a-f]+$": > type: object > additionalProperties: true > > -- > 2.34.1 > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-27 15:26 ` Rob Herring @ 2025-10-28 5:06 ` Xiangxu Yin 2025-10-28 19:57 ` Dmitry Baryshkov 0 siblings, 1 reply; 18+ messages in thread From: Xiangxu Yin @ 2025-10-28 5:06 UTC (permalink / raw) To: Rob Herring Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On 10/27/2025 11:26 PM, Rob Herring wrote: > On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin wrote: >> SM6150 uses the same DisplayPort controller as SM8150, which is already >> compatible with SM8350. Add the SM6150-specific compatible string and >> update the binding example accordingly. >> >> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> --- >> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 >> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> @@ -51,6 +51,16 @@ patternProperties: >> compatible: >> const: qcom,sm6150-dpu >> >> + "^displayport-controller@[0-9a-f]+$": >> + type: object >> + additionalProperties: true >> + properties: >> + compatible: >> + items: >> + - const: qcom,sm6150-dp >> + - const: qcom,sm8150-dp >> + - const: qcom,sm8350-dp > The actual schema will check the order. Here, just: > > compatible: > contains: > const: qcom,sm6150-dp My initial plan was to use only `qcom,sm6150-dp` with `contains` as suggested. But when I tried that, CHECK_DTBS schema check failed: ‘displayport-controller@ae90000:compatible: ['qcom,sm6150-dp', 'qcom,sm8150-dp', 'qcom,sm8350-dp'] is too long from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm6150-mdss.yaml’‘ So, I have added all. > >> + >> "^dsi@[0-9a-f]+$": >> type: object >> additionalProperties: true >> >> -- >> 2.34.1 >> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-28 5:06 ` Xiangxu Yin @ 2025-10-28 19:57 ` Dmitry Baryshkov 2025-10-29 8:51 ` Xiangxu Yin 0 siblings, 1 reply; 18+ messages in thread From: Dmitry Baryshkov @ 2025-10-28 19:57 UTC (permalink / raw) To: Xiangxu Yin Cc: Rob Herring, Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On Tue, Oct 28, 2025 at 01:06:52PM +0800, Xiangxu Yin wrote: > > On 10/27/2025 11:26 PM, Rob Herring wrote: > > On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin wrote: > >> SM6150 uses the same DisplayPort controller as SM8150, which is already > >> compatible with SM8350. Add the SM6150-specific compatible string and > >> update the binding example accordingly. > >> > >> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > >> --- > >> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ > >> 1 file changed, 10 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > >> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 > >> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > >> @@ -51,6 +51,16 @@ patternProperties: > >> compatible: > >> const: qcom,sm6150-dpu > >> > >> + "^displayport-controller@[0-9a-f]+$": > >> + type: object > >> + additionalProperties: true > >> + properties: > >> + compatible: > >> + items: > >> + - const: qcom,sm6150-dp > >> + - const: qcom,sm8150-dp > >> + - const: qcom,sm8350-dp > > The actual schema will check the order. Here, just: > > > > compatible: > > contains: > > const: qcom,sm6150-dp > > > My initial plan was to use only `qcom,sm6150-dp` with `contains` as suggested. > > But when I tried that, CHECK_DTBS schema check failed: > ‘displayport-controller@ae90000:compatible: ['qcom,sm6150-dp', 'qcom,sm8150-dp', 'qcom,sm8350-dp'] is too long > from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm6150-mdss.yaml’‘ > > So, I have added all. Please use properties: compatible: contains: > > > > > >> + > >> "^dsi@[0-9a-f]+$": > >> type: object > >> additionalProperties: true > >> > >> -- > >> 2.34.1 > >> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-28 19:57 ` Dmitry Baryshkov @ 2025-10-29 8:51 ` Xiangxu Yin 0 siblings, 0 replies; 18+ messages in thread From: Xiangxu Yin @ 2025-10-29 8:51 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Rob Herring, Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On 10/29/2025 3:57 AM, Dmitry Baryshkov wrote: > On Tue, Oct 28, 2025 at 01:06:52PM +0800, Xiangxu Yin wrote: >> On 10/27/2025 11:26 PM, Rob Herring wrote: >>> On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin wrote: >>>> SM6150 uses the same DisplayPort controller as SM8150, which is already >>>> compatible with SM8350. Add the SM6150-specific compatible string and >>>> update the binding example accordingly. >>>> >>>> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >>>> --- >>>> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >>>> @@ -51,6 +51,16 @@ patternProperties: >>>> compatible: >>>> const: qcom,sm6150-dpu >>>> >>>> + "^displayport-controller@[0-9a-f]+$": >>>> + type: object >>>> + additionalProperties: true >>>> + properties: >>>> + compatible: >>>> + items: >>>> + - const: qcom,sm6150-dp >>>> + - const: qcom,sm8150-dp >>>> + - const: qcom,sm8350-dp >>> The actual schema will check the order. Here, just: >>> >>> compatible: >>> contains: >>> const: qcom,sm6150-dp >> >> My initial plan was to use only `qcom,sm6150-dp` with `contains` as suggested. >> >> But when I tried that, CHECK_DTBS schema check failed: >> ‘displayport-controller@ae90000:compatible: ['qcom,sm6150-dp', 'qcom,sm8150-dp', 'qcom,sm8350-dp'] is too long >> from schema $id: http://devicetree.org/schemas/display/msm/qcom,sm6150-mdss.yaml’‘ >> >> So, I have added all. > Please use properties: compatible: contains: Ok, I missed the focus on the 'contains' syntax earlier. will update it in the next version. >> >>>> + >>>> "^dsi@[0-9a-f]+$": >>>> type: object >>>> additionalProperties: true >>>> >>>> -- >>>> 2.34.1 >>>> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-24 5:21 ` [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller Xiangxu Yin via B4 Relay 2025-10-27 15:26 ` Rob Herring @ 2025-10-27 18:54 ` Bjorn Andersson 2025-10-28 5:16 ` Xiangxu Yin 2025-10-28 19:58 ` Dmitry Baryshkov 1 sibling, 2 replies; 18+ messages in thread From: Bjorn Andersson @ 2025-10-27 18:54 UTC (permalink / raw) To: xiangxu.yin Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin via B4 Relay wrote: > From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > > SM6150 uses the same DisplayPort controller as SM8150, which is already > compatible with SM8350. Add the SM6150-specific compatible string and > update the binding example accordingly. > > Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > --- > .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > @@ -51,6 +51,16 @@ patternProperties: > compatible: > const: qcom,sm6150-dpu > > + "^displayport-controller@[0-9a-f]+$": > + type: object > + additionalProperties: true > + properties: > + compatible: > + items: > + - const: qcom,sm6150-dp > + - const: qcom,sm8150-dp Perhaps I'm missing something, but if sm6150-dp is the same controller as sm8150-dp, which is the same controller as sm8350-dp...doesn't that imply that sm6150-dp is the same as sm8350-dp and we could not mention the sm8150-dp here? Regards, Bjorn > + - const: qcom,sm8350-dp > + > "^dsi@[0-9a-f]+$": > type: object > additionalProperties: true > > -- > 2.34.1 > > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-27 18:54 ` Bjorn Andersson @ 2025-10-28 5:16 ` Xiangxu Yin 2025-10-28 19:58 ` Dmitry Baryshkov 1 sibling, 0 replies; 18+ messages in thread From: Xiangxu Yin @ 2025-10-28 5:16 UTC (permalink / raw) To: Bjorn Andersson Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On 10/28/2025 2:54 AM, Bjorn Andersson wrote: > On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin via B4 Relay wrote: >> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> >> SM6150 uses the same DisplayPort controller as SM8150, which is already >> compatible with SM8350. Add the SM6150-specific compatible string and >> update the binding example accordingly. >> >> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> --- >> .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 >> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> @@ -51,6 +51,16 @@ patternProperties: >> compatible: >> const: qcom,sm6150-dpu >> >> + "^displayport-controller@[0-9a-f]+$": >> + type: object >> + additionalProperties: true >> + properties: >> + compatible: >> + items: >> + - const: qcom,sm6150-dp >> + - const: qcom,sm8150-dp > Perhaps I'm missing something, but if sm6150-dp is the same controller > as sm8150-dp, which is the same controller as sm8350-dp...doesn't that > imply that sm6150-dp is the same as sm8350-dp and we could not mention > the sm8150-dp here? > > Regards, > Bjorn I have discussed this with Dmitry in message-id <20250916-add-dp-controller-support-for-sm6150-v3-1-dd60ebbd101e@oss.qualcomm.com> SM6150 uses the same controller IP as SM8150 and should fall back to sm8350 for consistency. And when running CHECK_DTBS, I encountered DTS compatible warnings, which is why all three compatibles are listed. >> + - const: qcom,sm8350-dp >> + >> "^dsi@[0-9a-f]+$": >> type: object >> additionalProperties: true >> >> -- >> 2.34.1 >> >> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller 2025-10-27 18:54 ` Bjorn Andersson 2025-10-28 5:16 ` Xiangxu Yin @ 2025-10-28 19:58 ` Dmitry Baryshkov 1 sibling, 0 replies; 18+ messages in thread From: Dmitry Baryshkov @ 2025-10-28 19:58 UTC (permalink / raw) To: Bjorn Andersson Cc: xiangxu.yin, Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On Mon, Oct 27, 2025 at 01:54:43PM -0500, Bjorn Andersson wrote: > On Fri, Oct 24, 2025 at 01:21:01PM +0800, Xiangxu Yin via B4 Relay wrote: > > From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > > > > SM6150 uses the same DisplayPort controller as SM8150, which is already > > compatible with SM8350. Add the SM6150-specific compatible string and > > update the binding example accordingly. > > > > Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > > --- > > .../devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > > index 9ac24f99d3ada1c197c9654dc9babebccae972ed..ba0dea2edea98cee0826cf38b3f33361666e004a 100644 > > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > > @@ -51,6 +51,16 @@ patternProperties: > > compatible: > > const: qcom,sm6150-dpu > > > > + "^displayport-controller@[0-9a-f]+$": > > + type: object > > + additionalProperties: true > > + properties: > > + compatible: > > + items: > > + - const: qcom,sm6150-dp > > + - const: qcom,sm8150-dp > > Perhaps I'm missing something, but if sm6150-dp is the same controller > as sm8150-dp, which is the same controller as sm8350-dp...doesn't that > imply that sm6150-dp is the same as sm8350-dp and we could not mention > the sm8150-dp here? sm6150-dp is the same as sm8150-dp. sm8150-dp is compatible with sm8350-dp, but it's not the same version. > > Regards, > Bjorn > > > + - const: qcom,sm8350-dp > > + > > "^dsi@[0-9a-f]+$": > > type: object > > additionalProperties: true > > > > -- > > 2.34.1 > > > > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values 2025-10-24 5:21 [PATCH v6 0/4] Add DisplayPort support to QCS615 devicetree Xiangxu Yin via B4 Relay 2025-10-24 5:21 ` [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 ` Xiangxu Yin via B4 Relay 2025-10-27 15:24 ` Rob Herring (Arm) 2025-10-28 20:00 ` Dmitry Baryshkov 2025-10-24 5:21 ` [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 Xiangxu Yin via B4 Relay 2025-10-24 5:21 ` [PATCH v6 4/4] arm64: dts: qcom: qcs615-ride: Enable DisplayPort Xiangxu Yin via B4 Relay 3 siblings, 2 replies; 18+ messages in thread From: Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 UTC (permalink / raw) To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Xiangxu Yin From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> - Adjusted indentation and added missing blank lines in the example. - Corrected OPP clock values to match actual DTS configuration. Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> --- .../bindings/display/msm/qcom,sm6150-mdss.yaml | 32 ++++++++++++---------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml index ba0dea2edea98cee0826cf38b3f33361666e004a..80183df71cd9288f652dc42afeae101e8edcbe65 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml @@ -140,35 +140,37 @@ examples: #size-cells = <0>; port@0 { - reg = <0>; - dpu_intf0_out: endpoint { - }; + reg = <0>; + + dpu_intf0_out: endpoint { + }; }; port@1 { - reg = <1>; - dpu_intf1_out: endpoint { - remote-endpoint = <&mdss_dsi0_in>; - }; + reg = <1>; + + dpu_intf1_out: endpoint { + remote-endpoint = <&mdss_dsi0_in>; + }; }; }; mdp_opp_table: opp-table { compatible = "operating-points-v2"; - opp-19200000 { - opp-hz = /bits/ 64 <19200000>; - required-opps = <&rpmhpd_opp_low_svs>; + opp-192000000 { + opp-hz = /bits/ 64 <192000000>; + required-opps = <&rpmhpd_opp_low_svs>; }; - opp-25600000 { - opp-hz = /bits/ 64 <25600000>; - required-opps = <&rpmhpd_opp_svs>; + opp-256000000 { + opp-hz = /bits/ 64 <256000000>; + required-opps = <&rpmhpd_opp_svs>; }; opp-307200000 { - opp-hz = /bits/ 64 <307200000>; - required-opps = <&rpmhpd_opp_nom>; + opp-hz = /bits/ 64 <307200000>; + required-opps = <&rpmhpd_opp_nom>; }; }; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values 2025-10-24 5:21 ` [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values Xiangxu Yin via B4 Relay @ 2025-10-27 15:24 ` Rob Herring (Arm) 2025-10-28 20:00 ` Dmitry Baryshkov 1 sibling, 0 replies; 18+ messages in thread From: Rob Herring (Arm) @ 2025-10-27 15:24 UTC (permalink / raw) To: Xiangxu Yin Cc: Krzysztof Kozlowski, linux-arm-msm, dri-devel, David Airlie, freedreno, linux-kernel, Simona Vetter, Dmitry Baryshkov, Bjorn Andersson, fange.zhang, Conor Dooley, Marijn Suijten, li.liu, Thomas Zimmermann, devicetree, Maarten Lankhorst, Konrad Dybcio, Abhinav Kumar, Rob Clark, Maxime Ripard, Jessica Zhang, Sean Paul, yongxing.mou On Fri, 24 Oct 2025 13:21:02 +0800, Xiangxu Yin wrote: > - Adjusted indentation and added missing blank lines in the example. > - Corrected OPP clock values to match actual DTS configuration. > > Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > --- > .../bindings/display/msm/qcom,sm6150-mdss.yaml | 32 ++++++++++++---------- > 1 file changed, 17 insertions(+), 15 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values 2025-10-24 5:21 ` [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values Xiangxu Yin via B4 Relay 2025-10-27 15:24 ` Rob Herring (Arm) @ 2025-10-28 20:00 ` Dmitry Baryshkov 2025-10-29 9:59 ` Xiangxu Yin 1 sibling, 1 reply; 18+ messages in thread From: Dmitry Baryshkov @ 2025-10-28 20:00 UTC (permalink / raw) To: xiangxu.yin Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On Fri, Oct 24, 2025 at 01:21:02PM +0800, Xiangxu Yin via B4 Relay wrote: > From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > > - Adjusted indentation and added missing blank lines in the example. > - Corrected OPP clock values to match actual DTS configuration. See Documentation/process/submitting-patches.rst to check how to write proper commit messages. > > Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > --- > .../bindings/display/msm/qcom,sm6150-mdss.yaml | 32 ++++++++++++---------- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > index ba0dea2edea98cee0826cf38b3f33361666e004a..80183df71cd9288f652dc42afeae101e8edcbe65 100644 > --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml > @@ -140,35 +140,37 @@ examples: > #size-cells = <0>; > > port@0 { > - reg = <0>; > - dpu_intf0_out: endpoint { > - }; > + reg = <0>; > + > + dpu_intf0_out: endpoint { > + }; > }; > > port@1 { > - reg = <1>; > - dpu_intf1_out: endpoint { > - remote-endpoint = <&mdss_dsi0_in>; > - }; > + reg = <1>; > + > + dpu_intf1_out: endpoint { > + remote-endpoint = <&mdss_dsi0_in>; > + }; > }; > }; > > mdp_opp_table: opp-table { > compatible = "operating-points-v2"; > > - opp-19200000 { > - opp-hz = /bits/ 64 <19200000>; > - required-opps = <&rpmhpd_opp_low_svs>; > + opp-192000000 { This is not necessary. This is just an example, so it doesn't matter, which values are actually written here. > + opp-hz = /bits/ 64 <192000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > }; > > - opp-25600000 { > - opp-hz = /bits/ 64 <25600000>; > - required-opps = <&rpmhpd_opp_svs>; > + opp-256000000 { > + opp-hz = /bits/ 64 <256000000>; > + required-opps = <&rpmhpd_opp_svs>; > }; > > opp-307200000 { > - opp-hz = /bits/ 64 <307200000>; > - required-opps = <&rpmhpd_opp_nom>; > + opp-hz = /bits/ 64 <307200000>; > + required-opps = <&rpmhpd_opp_nom>; > }; > }; > }; > > -- > 2.34.1 > > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values 2025-10-28 20:00 ` Dmitry Baryshkov @ 2025-10-29 9:59 ` Xiangxu Yin 0 siblings, 0 replies; 18+ messages in thread From: Xiangxu Yin @ 2025-10-29 9:59 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu On 10/29/2025 4:00 AM, Dmitry Baryshkov wrote: > On Fri, Oct 24, 2025 at 01:21:02PM +0800, Xiangxu Yin via B4 Relay wrote: >> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> >> - Adjusted indentation and added missing blank lines in the example. >> - Corrected OPP clock values to match actual DTS configuration. > See Documentation/process/submitting-patches.rst to check how to write > proper commit messages. Ok, will refer guide to update commit msg. >> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> --- >> .../bindings/display/msm/qcom,sm6150-mdss.yaml | 32 ++++++++++++---------- >> 1 file changed, 17 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> index ba0dea2edea98cee0826cf38b3f33361666e004a..80183df71cd9288f652dc42afeae101e8edcbe65 100644 >> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6150-mdss.yaml >> @@ -140,35 +140,37 @@ examples: >> #size-cells = <0>; >> >> port@0 { >> - reg = <0>; >> - dpu_intf0_out: endpoint { >> - }; >> + reg = <0>; >> + >> + dpu_intf0_out: endpoint { >> + }; >> }; >> >> port@1 { >> - reg = <1>; >> - dpu_intf1_out: endpoint { >> - remote-endpoint = <&mdss_dsi0_in>; >> - }; >> + reg = <1>; >> + >> + dpu_intf1_out: endpoint { >> + remote-endpoint = <&mdss_dsi0_in>; >> + }; >> }; >> }; >> >> mdp_opp_table: opp-table { >> compatible = "operating-points-v2"; >> >> - opp-19200000 { >> - opp-hz = /bits/ 64 <19200000>; >> - required-opps = <&rpmhpd_opp_low_svs>; >> + opp-192000000 { > This is not necessary. This is just an example, so it doesn't matter, > which values are actually written here. Yes, but I think correct value is better? >> + opp-hz = /bits/ 64 <192000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> }; >> >> - opp-25600000 { >> - opp-hz = /bits/ 64 <25600000>; >> - required-opps = <&rpmhpd_opp_svs>; >> + opp-256000000 { >> + opp-hz = /bits/ 64 <256000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> }; >> >> opp-307200000 { >> - opp-hz = /bits/ 64 <307200000>; >> - required-opps = <&rpmhpd_opp_nom>; >> + opp-hz = /bits/ 64 <307200000>; >> + required-opps = <&rpmhpd_opp_nom>; >> }; >> }; >> }; >> >> -- >> 2.34.1 >> >> ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 2025-10-24 5:21 [PATCH v6 0/4] Add DisplayPort support to QCS615 devicetree Xiangxu Yin via B4 Relay 2025-10-24 5:21 ` [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller Xiangxu Yin via B4 Relay 2025-10-24 5:21 ` [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 ` Xiangxu Yin via B4 Relay 2025-10-29 17:32 ` Bjorn Andersson 2025-10-24 5:21 ` [PATCH v6 4/4] arm64: dts: qcom: qcs615-ride: Enable DisplayPort Xiangxu Yin via B4 Relay 3 siblings, 1 reply; 18+ messages in thread From: Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 UTC (permalink / raw) To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Xiangxu Yin, Dmitry Baryshkov, Konrad Dybcio From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> Introduce DisplayPort controller node and associated QMP USB3-DP PHY for SM6150 SoC. Add data-lanes property to the DP endpoint and update clock assignments for proper DP integration. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/sm6150.dtsi | 115 ++++++++++++++++++++++++++++++++++- 1 file changed, 113 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm6150.dtsi b/arch/arm64/boot/dts/qcom/sm6150.dtsi index 6128d8c48f9c0807ac488ddac3b2377678e8f8c3..9741f8d14c72ed7dd6a5e483c5c0d578662f1d31 100644 --- a/arch/arm64/boot/dts/qcom/sm6150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6150.dtsi @@ -14,6 +14,7 @@ #include <dt-bindings/interconnect/qcom,icc.h> #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h> #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/phy/phy-qcom-qmp.h> #include <dt-bindings/power/qcom-rpmpd.h> #include <dt-bindings/power/qcom,rpmhpd.h> #include <dt-bindings/soc/qcom,rpmh-rsc.h> @@ -3717,6 +3718,7 @@ port@0 { reg = <0>; dpu_intf0_out: endpoint { + remote-endpoint = <&mdss_dp0_in>; }; }; @@ -3749,6 +3751,89 @@ opp-307200000 { }; }; + mdss_dp0: displayport-controller@ae90000 { + compatible = "qcom,sm6150-dp", "qcom,sm8150-dp", "qcom,sm8350-dp"; + + reg = <0x0 0x0ae90000 0x0 0x200>, + <0x0 0x0ae90200 0x0 0x200>, + <0x0 0x0ae90400 0x0 0x600>, + <0x0 0x0ae90a00 0x0 0x600>, + <0x0 0x0ae91000 0x0 0x600>; + + interrupt-parent = <&mdss>; + interrupts = <12>; + + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&dispcc DISP_CC_MDSS_DP_AUX_CLK>, + <&dispcc DISP_CC_MDSS_DP_LINK_CLK>, + <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>, + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>, + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK>; + clock-names = "core_iface", + "core_aux", + "ctrl_link", + "ctrl_link_iface", + "stream_pixel", + "stream_1_pixel"; + + assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>, + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>, + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK_SRC>; + assigned-clock-parents = <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>, + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; + + phys = <&usb_qmpphy_2 QMP_USB43DP_DP_PHY>; + phy-names = "dp"; + + operating-points-v2 = <&dp_opp_table>; + power-domains = <&rpmhpd RPMHPD_CX>; + + #sound-dai-cells = <0>; + + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + mdss_dp0_in: endpoint { + remote-endpoint = <&dpu_intf0_out>; + }; + }; + + port@1 { + reg = <1>; + + mdss_dp0_out: endpoint { + data-lanes = <3 2 0 1>; + }; + }; + }; + + dp_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-160000000 { + opp-hz = /bits/ 64 <160000000>; + required-opps = <&rpmhpd_opp_low_svs>; + }; + + opp-270000000 { + opp-hz = /bits/ 64 <270000000>; + required-opps = <&rpmhpd_opp_svs>; + }; + + opp-540000000 { + opp-hz = /bits/ 64 <540000000>; + required-opps = <&rpmhpd_opp_svs_l1>; + }; + }; + }; + mdss_dsi0: dsi@ae94000 { compatible = "qcom,sm6150-dsi-ctrl", "qcom,mdss-dsi-ctrl"; reg = <0x0 0x0ae94000 0x0 0x400>; @@ -3844,8 +3929,8 @@ dispcc: clock-controller@af00000 { <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>, <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>, <0>, - <0>, - <0>; + <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; #clock-cells = <1>; #reset-cells = <1>; @@ -4214,6 +4299,32 @@ usb_qmpphy: phy@88e6000 { status = "disabled"; }; + usb_qmpphy_2: phy@88e8000 { + compatible = "qcom,qcs615-qmp-usb3-dp-phy"; + reg = <0x0 0x088e8000 0x0 0x2000>; + + clocks = <&gcc GCC_USB2_SEC_PHY_AUX_CLK>, + <&gcc GCC_USB3_SEC_CLKREF_CLK>, + <&gcc GCC_AHB2PHY_WEST_CLK>, + <&gcc GCC_USB2_SEC_PHY_PIPE_CLK>; + clock-names = "aux", + "ref", + "cfg_ahb", + "pipe"; + + resets = <&gcc GCC_USB3PHY_PHY_SEC_BCR >, + <&gcc GCC_USB3_DP_PHY_SEC_BCR>; + reset-names = "phy_phy", + "dp_phy"; + + #clock-cells = <1>; + #phy-cells = <1>; + + qcom,tcsr-reg = <&tcsr 0xbff0 0xb24c>; + + status = "disabled"; + }; + usb_1: usb@a6f8800 { compatible = "qcom,qcs615-dwc3", "qcom,dwc3"; reg = <0x0 0x0a6f8800 0x0 0x400>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 2025-10-24 5:21 ` [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 Xiangxu Yin via B4 Relay @ 2025-10-29 17:32 ` Bjorn Andersson 2025-10-30 7:21 ` Xiangxu Yin 0 siblings, 1 reply; 18+ messages in thread From: Bjorn Andersson @ 2025-10-29 17:32 UTC (permalink / raw) To: xiangxu.yin Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Dmitry Baryshkov, Konrad Dybcio On Fri, Oct 24, 2025 at 01:21:03PM +0800, Xiangxu Yin via B4 Relay wrote: > From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > Please fix the subject prefix and drop the "for SM6150" suffix. Regards, Bjorn > Introduce DisplayPort controller node and associated QMP USB3-DP PHY > for SM6150 SoC. Add data-lanes property to the DP endpoint and update > clock assignments for proper DP integration. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/sm6150.dtsi | 115 ++++++++++++++++++++++++++++++++++- > 1 file changed, 113 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6150.dtsi b/arch/arm64/boot/dts/qcom/sm6150.dtsi > index 6128d8c48f9c0807ac488ddac3b2377678e8f8c3..9741f8d14c72ed7dd6a5e483c5c0d578662f1d31 100644 > --- a/arch/arm64/boot/dts/qcom/sm6150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6150.dtsi > @@ -14,6 +14,7 @@ > #include <dt-bindings/interconnect/qcom,icc.h> > #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/phy/phy-qcom-qmp.h> > #include <dt-bindings/power/qcom-rpmpd.h> > #include <dt-bindings/power/qcom,rpmhpd.h> > #include <dt-bindings/soc/qcom,rpmh-rsc.h> > @@ -3717,6 +3718,7 @@ port@0 { > reg = <0>; > > dpu_intf0_out: endpoint { > + remote-endpoint = <&mdss_dp0_in>; > }; > }; > > @@ -3749,6 +3751,89 @@ opp-307200000 { > }; > }; > > + mdss_dp0: displayport-controller@ae90000 { > + compatible = "qcom,sm6150-dp", "qcom,sm8150-dp", "qcom,sm8350-dp"; > + > + reg = <0x0 0x0ae90000 0x0 0x200>, > + <0x0 0x0ae90200 0x0 0x200>, > + <0x0 0x0ae90400 0x0 0x600>, > + <0x0 0x0ae90a00 0x0 0x600>, > + <0x0 0x0ae91000 0x0 0x600>; > + > + interrupt-parent = <&mdss>; > + interrupts = <12>; > + > + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, > + <&dispcc DISP_CC_MDSS_DP_AUX_CLK>, > + <&dispcc DISP_CC_MDSS_DP_LINK_CLK>, > + <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>, > + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>, > + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK>; > + clock-names = "core_iface", > + "core_aux", > + "ctrl_link", > + "ctrl_link_iface", > + "stream_pixel", > + "stream_1_pixel"; > + > + assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>, > + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>, > + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK_SRC>; > + assigned-clock-parents = <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, > + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>, > + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; > + > + phys = <&usb_qmpphy_2 QMP_USB43DP_DP_PHY>; > + phy-names = "dp"; > + > + operating-points-v2 = <&dp_opp_table>; > + power-domains = <&rpmhpd RPMHPD_CX>; > + > + #sound-dai-cells = <0>; > + > + status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + mdss_dp0_in: endpoint { > + remote-endpoint = <&dpu_intf0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + mdss_dp0_out: endpoint { > + data-lanes = <3 2 0 1>; > + }; > + }; > + }; > + > + dp_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-160000000 { > + opp-hz = /bits/ 64 <160000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-270000000 { > + opp-hz = /bits/ 64 <270000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-540000000 { > + opp-hz = /bits/ 64 <540000000>; > + required-opps = <&rpmhpd_opp_svs_l1>; > + }; > + }; > + }; > + > mdss_dsi0: dsi@ae94000 { > compatible = "qcom,sm6150-dsi-ctrl", "qcom,mdss-dsi-ctrl"; > reg = <0x0 0x0ae94000 0x0 0x400>; > @@ -3844,8 +3929,8 @@ dispcc: clock-controller@af00000 { > <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>, > <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>, > <0>, > - <0>, > - <0>; > + <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, > + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; > > #clock-cells = <1>; > #reset-cells = <1>; > @@ -4214,6 +4299,32 @@ usb_qmpphy: phy@88e6000 { > status = "disabled"; > }; > > + usb_qmpphy_2: phy@88e8000 { > + compatible = "qcom,qcs615-qmp-usb3-dp-phy"; > + reg = <0x0 0x088e8000 0x0 0x2000>; > + > + clocks = <&gcc GCC_USB2_SEC_PHY_AUX_CLK>, > + <&gcc GCC_USB3_SEC_CLKREF_CLK>, > + <&gcc GCC_AHB2PHY_WEST_CLK>, > + <&gcc GCC_USB2_SEC_PHY_PIPE_CLK>; > + clock-names = "aux", > + "ref", > + "cfg_ahb", > + "pipe"; > + > + resets = <&gcc GCC_USB3PHY_PHY_SEC_BCR >, > + <&gcc GCC_USB3_DP_PHY_SEC_BCR>; > + reset-names = "phy_phy", > + "dp_phy"; > + > + #clock-cells = <1>; > + #phy-cells = <1>; > + > + qcom,tcsr-reg = <&tcsr 0xbff0 0xb24c>; > + > + status = "disabled"; > + }; > + > usb_1: usb@a6f8800 { > compatible = "qcom,qcs615-dwc3", "qcom,dwc3"; > reg = <0x0 0x0a6f8800 0x0 0x400>; > > -- > 2.34.1 > > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 2025-10-29 17:32 ` Bjorn Andersson @ 2025-10-30 7:21 ` Xiangxu Yin 2025-10-30 18:26 ` Bjorn Andersson 0 siblings, 1 reply; 18+ messages in thread From: Xiangxu Yin @ 2025-10-30 7:21 UTC (permalink / raw) To: Bjorn Andersson Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Dmitry Baryshkov, Konrad Dybcio On 10/30/2025 1:32 AM, Bjorn Andersson wrote: > On Fri, Oct 24, 2025 at 01:21:03PM +0800, Xiangxu Yin via B4 Relay wrote: >> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> > Please fix the subject prefix and drop the "for SM6150" suffix. > > Regards, > Bjorn Ok, due to sm6150.dtsi have renamed to talos.dtsi in newest version. Will update to 'arm64: dts: qcom: talos: Add DisplayPort and QMP USB3DP PHY' >> Introduce DisplayPort controller node and associated QMP USB3-DP PHY >> for SM6150 SoC. Add data-lanes property to the DP endpoint and update >> clock assignments for proper DP integration. >> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> >> --- >> arch/arm64/boot/dts/qcom/sm6150.dtsi | 115 ++++++++++++++++++++++++++++++++++- >> 1 file changed, 113 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm6150.dtsi b/arch/arm64/boot/dts/qcom/sm6150.dtsi >> index 6128d8c48f9c0807ac488ddac3b2377678e8f8c3..9741f8d14c72ed7dd6a5e483c5c0d578662f1d31 100644 >> --- a/arch/arm64/boot/dts/qcom/sm6150.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm6150.dtsi >> @@ -14,6 +14,7 @@ >> #include <dt-bindings/interconnect/qcom,icc.h> >> #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h> >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> +#include <dt-bindings/phy/phy-qcom-qmp.h> >> #include <dt-bindings/power/qcom-rpmpd.h> >> #include <dt-bindings/power/qcom,rpmhpd.h> >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >> @@ -3717,6 +3718,7 @@ port@0 { >> reg = <0>; >> >> dpu_intf0_out: endpoint { >> + remote-endpoint = <&mdss_dp0_in>; >> }; >> }; >> >> @@ -3749,6 +3751,89 @@ opp-307200000 { >> }; >> }; >> >> + mdss_dp0: displayport-controller@ae90000 { >> + compatible = "qcom,sm6150-dp", "qcom,sm8150-dp", "qcom,sm8350-dp"; >> + >> + reg = <0x0 0x0ae90000 0x0 0x200>, >> + <0x0 0x0ae90200 0x0 0x200>, >> + <0x0 0x0ae90400 0x0 0x600>, >> + <0x0 0x0ae90a00 0x0 0x600>, >> + <0x0 0x0ae91000 0x0 0x600>; >> + >> + interrupt-parent = <&mdss>; >> + interrupts = <12>; >> + >> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_AUX_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_LINK_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>, >> + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK>; >> + clock-names = "core_iface", >> + "core_aux", >> + "ctrl_link", >> + "ctrl_link_iface", >> + "stream_pixel", >> + "stream_1_pixel"; >> + >> + assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>, >> + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>, >> + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK_SRC>; >> + assigned-clock-parents = <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, >> + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>, >> + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; >> + >> + phys = <&usb_qmpphy_2 QMP_USB43DP_DP_PHY>; >> + phy-names = "dp"; >> + >> + operating-points-v2 = <&dp_opp_table>; >> + power-domains = <&rpmhpd RPMHPD_CX>; >> + >> + #sound-dai-cells = <0>; >> + >> + status = "disabled"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + >> + mdss_dp0_in: endpoint { >> + remote-endpoint = <&dpu_intf0_out>; >> + }; >> + }; >> + >> + port@1 { >> + reg = <1>; >> + >> + mdss_dp0_out: endpoint { >> + data-lanes = <3 2 0 1>; >> + }; >> + }; >> + }; >> + >> + dp_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + opp-160000000 { >> + opp-hz = /bits/ 64 <160000000>; >> + required-opps = <&rpmhpd_opp_low_svs>; >> + }; >> + >> + opp-270000000 { >> + opp-hz = /bits/ 64 <270000000>; >> + required-opps = <&rpmhpd_opp_svs>; >> + }; >> + >> + opp-540000000 { >> + opp-hz = /bits/ 64 <540000000>; >> + required-opps = <&rpmhpd_opp_svs_l1>; >> + }; >> + }; >> + }; >> + >> mdss_dsi0: dsi@ae94000 { >> compatible = "qcom,sm6150-dsi-ctrl", "qcom,mdss-dsi-ctrl"; >> reg = <0x0 0x0ae94000 0x0 0x400>; >> @@ -3844,8 +3929,8 @@ dispcc: clock-controller@af00000 { >> <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>, >> <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>, >> <0>, >> - <0>, >> - <0>; >> + <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, >> + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; >> >> #clock-cells = <1>; >> #reset-cells = <1>; >> @@ -4214,6 +4299,32 @@ usb_qmpphy: phy@88e6000 { >> status = "disabled"; >> }; >> >> + usb_qmpphy_2: phy@88e8000 { >> + compatible = "qcom,qcs615-qmp-usb3-dp-phy"; >> + reg = <0x0 0x088e8000 0x0 0x2000>; >> + >> + clocks = <&gcc GCC_USB2_SEC_PHY_AUX_CLK>, >> + <&gcc GCC_USB3_SEC_CLKREF_CLK>, >> + <&gcc GCC_AHB2PHY_WEST_CLK>, >> + <&gcc GCC_USB2_SEC_PHY_PIPE_CLK>; >> + clock-names = "aux", >> + "ref", >> + "cfg_ahb", >> + "pipe"; >> + >> + resets = <&gcc GCC_USB3PHY_PHY_SEC_BCR >, >> + <&gcc GCC_USB3_DP_PHY_SEC_BCR>; >> + reset-names = "phy_phy", >> + "dp_phy"; >> + >> + #clock-cells = <1>; >> + #phy-cells = <1>; >> + >> + qcom,tcsr-reg = <&tcsr 0xbff0 0xb24c>; >> + >> + status = "disabled"; >> + }; >> + >> usb_1: usb@a6f8800 { >> compatible = "qcom,qcs615-dwc3", "qcom,dwc3"; >> reg = <0x0 0x0a6f8800 0x0 0x400>; >> >> -- >> 2.34.1 >> >> ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 2025-10-30 7:21 ` Xiangxu Yin @ 2025-10-30 18:26 ` Bjorn Andersson 0 siblings, 0 replies; 18+ messages in thread From: Bjorn Andersson @ 2025-10-30 18:26 UTC (permalink / raw) To: Xiangxu Yin Cc: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio, linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Dmitry Baryshkov, Konrad Dybcio On Thu, Oct 30, 2025 at 03:21:09PM +0800, Xiangxu Yin wrote: > > On 10/30/2025 1:32 AM, Bjorn Andersson wrote: > > On Fri, Oct 24, 2025 at 01:21:03PM +0800, Xiangxu Yin via B4 Relay wrote: > >> From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > >> > > Please fix the subject prefix and drop the "for SM6150" suffix. > > > > Regards, > > Bjorn > > > Ok, due to sm6150.dtsi have renamed to talos.dtsi in newest version. > > Will update to 'arm64: dts: qcom: talos: Add DisplayPort and QMP USB3DP PHY' > I'd be happy with that, thank you. Regards, Bjorn > > >> Introduce DisplayPort controller node and associated QMP USB3-DP PHY > >> for SM6150 SoC. Add data-lanes property to the DP endpoint and update > >> clock assignments for proper DP integration. > >> > >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> > >> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > >> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> > >> --- > >> arch/arm64/boot/dts/qcom/sm6150.dtsi | 115 ++++++++++++++++++++++++++++++++++- > >> 1 file changed, 113 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sm6150.dtsi b/arch/arm64/boot/dts/qcom/sm6150.dtsi > >> index 6128d8c48f9c0807ac488ddac3b2377678e8f8c3..9741f8d14c72ed7dd6a5e483c5c0d578662f1d31 100644 > >> --- a/arch/arm64/boot/dts/qcom/sm6150.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sm6150.dtsi > >> @@ -14,6 +14,7 @@ > >> #include <dt-bindings/interconnect/qcom,icc.h> > >> #include <dt-bindings/interconnect/qcom,qcs615-rpmh.h> > >> #include <dt-bindings/interrupt-controller/arm-gic.h> > >> +#include <dt-bindings/phy/phy-qcom-qmp.h> > >> #include <dt-bindings/power/qcom-rpmpd.h> > >> #include <dt-bindings/power/qcom,rpmhpd.h> > >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> > >> @@ -3717,6 +3718,7 @@ port@0 { > >> reg = <0>; > >> > >> dpu_intf0_out: endpoint { > >> + remote-endpoint = <&mdss_dp0_in>; > >> }; > >> }; > >> > >> @@ -3749,6 +3751,89 @@ opp-307200000 { > >> }; > >> }; > >> > >> + mdss_dp0: displayport-controller@ae90000 { > >> + compatible = "qcom,sm6150-dp", "qcom,sm8150-dp", "qcom,sm8350-dp"; > >> + > >> + reg = <0x0 0x0ae90000 0x0 0x200>, > >> + <0x0 0x0ae90200 0x0 0x200>, > >> + <0x0 0x0ae90400 0x0 0x600>, > >> + <0x0 0x0ae90a00 0x0 0x600>, > >> + <0x0 0x0ae91000 0x0 0x600>; > >> + > >> + interrupt-parent = <&mdss>; > >> + interrupts = <12>; > >> + > >> + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, > >> + <&dispcc DISP_CC_MDSS_DP_AUX_CLK>, > >> + <&dispcc DISP_CC_MDSS_DP_LINK_CLK>, > >> + <&dispcc DISP_CC_MDSS_DP_LINK_INTF_CLK>, > >> + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK>, > >> + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK>; > >> + clock-names = "core_iface", > >> + "core_aux", > >> + "ctrl_link", > >> + "ctrl_link_iface", > >> + "stream_pixel", > >> + "stream_1_pixel"; > >> + > >> + assigned-clocks = <&dispcc DISP_CC_MDSS_DP_LINK_CLK_SRC>, > >> + <&dispcc DISP_CC_MDSS_DP_PIXEL_CLK_SRC>, > >> + <&dispcc DISP_CC_MDSS_DP_PIXEL1_CLK_SRC>; > >> + assigned-clock-parents = <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, > >> + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>, > >> + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; > >> + > >> + phys = <&usb_qmpphy_2 QMP_USB43DP_DP_PHY>; > >> + phy-names = "dp"; > >> + > >> + operating-points-v2 = <&dp_opp_table>; > >> + power-domains = <&rpmhpd RPMHPD_CX>; > >> + > >> + #sound-dai-cells = <0>; > >> + > >> + status = "disabled"; > >> + > >> + ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + > >> + port@0 { > >> + reg = <0>; > >> + > >> + mdss_dp0_in: endpoint { > >> + remote-endpoint = <&dpu_intf0_out>; > >> + }; > >> + }; > >> + > >> + port@1 { > >> + reg = <1>; > >> + > >> + mdss_dp0_out: endpoint { > >> + data-lanes = <3 2 0 1>; > >> + }; > >> + }; > >> + }; > >> + > >> + dp_opp_table: opp-table { > >> + compatible = "operating-points-v2"; > >> + > >> + opp-160000000 { > >> + opp-hz = /bits/ 64 <160000000>; > >> + required-opps = <&rpmhpd_opp_low_svs>; > >> + }; > >> + > >> + opp-270000000 { > >> + opp-hz = /bits/ 64 <270000000>; > >> + required-opps = <&rpmhpd_opp_svs>; > >> + }; > >> + > >> + opp-540000000 { > >> + opp-hz = /bits/ 64 <540000000>; > >> + required-opps = <&rpmhpd_opp_svs_l1>; > >> + }; > >> + }; > >> + }; > >> + > >> mdss_dsi0: dsi@ae94000 { > >> compatible = "qcom,sm6150-dsi-ctrl", "qcom,mdss-dsi-ctrl"; > >> reg = <0x0 0x0ae94000 0x0 0x400>; > >> @@ -3844,8 +3929,8 @@ dispcc: clock-controller@af00000 { > >> <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>, > >> <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>, > >> <0>, > >> - <0>, > >> - <0>; > >> + <&usb_qmpphy_2 QMP_USB43DP_DP_LINK_CLK>, > >> + <&usb_qmpphy_2 QMP_USB43DP_DP_VCO_DIV_CLK>; > >> > >> #clock-cells = <1>; > >> #reset-cells = <1>; > >> @@ -4214,6 +4299,32 @@ usb_qmpphy: phy@88e6000 { > >> status = "disabled"; > >> }; > >> > >> + usb_qmpphy_2: phy@88e8000 { > >> + compatible = "qcom,qcs615-qmp-usb3-dp-phy"; > >> + reg = <0x0 0x088e8000 0x0 0x2000>; > >> + > >> + clocks = <&gcc GCC_USB2_SEC_PHY_AUX_CLK>, > >> + <&gcc GCC_USB3_SEC_CLKREF_CLK>, > >> + <&gcc GCC_AHB2PHY_WEST_CLK>, > >> + <&gcc GCC_USB2_SEC_PHY_PIPE_CLK>; > >> + clock-names = "aux", > >> + "ref", > >> + "cfg_ahb", > >> + "pipe"; > >> + > >> + resets = <&gcc GCC_USB3PHY_PHY_SEC_BCR >, > >> + <&gcc GCC_USB3_DP_PHY_SEC_BCR>; > >> + reset-names = "phy_phy", > >> + "dp_phy"; > >> + > >> + #clock-cells = <1>; > >> + #phy-cells = <1>; > >> + > >> + qcom,tcsr-reg = <&tcsr 0xbff0 0xb24c>; > >> + > >> + status = "disabled"; > >> + }; > >> + > >> usb_1: usb@a6f8800 { > >> compatible = "qcom,qcs615-dwc3", "qcom,dwc3"; > >> reg = <0x0 0x0a6f8800 0x0 0x400>; > >> > >> -- > >> 2.34.1 > >> > >> ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 4/4] arm64: dts: qcom: qcs615-ride: Enable DisplayPort 2025-10-24 5:21 [PATCH v6 0/4] Add DisplayPort support to QCS615 devicetree Xiangxu Yin via B4 Relay ` (2 preceding siblings ...) 2025-10-24 5:21 ` [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 ` Xiangxu Yin via B4 Relay 3 siblings, 0 replies; 18+ messages in thread From: Xiangxu Yin via B4 Relay @ 2025-10-24 5:21 UTC (permalink / raw) To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel, fange.zhang, yongxing.mou, li.liu, Xiangxu Yin, Konrad Dybcio From: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> Add DP connector node and configure MDSS DisplayPort controller for QCS615 Ride platform. Include PHY supply settings to support DP output. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Xiangxu Yin <xiangxu.yin@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/qcs615-ride.dts | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/qcs615-ride.dts b/arch/arm64/boot/dts/qcom/qcs615-ride.dts index 9ac1dd3483b56f9d1652f8a38f62d759efa92b6a..bb0f4b8265e4807e50d067aed8b21557d97b20dd 100644 --- a/arch/arm64/boot/dts/qcom/qcs615-ride.dts +++ b/arch/arm64/boot/dts/qcom/qcs615-ride.dts @@ -39,6 +39,20 @@ xo_board_clk: xo-board-clk { }; }; + dp0-connector { + compatible = "dp-connector"; + label = "DP0"; + type = "mini"; + + hpd-gpios = <&io_expander 8 GPIO_ACTIVE_HIGH>; + + port { + dp0_connector_in: endpoint { + remote-endpoint = <&mdss_dp0_out>; + }; + }; + }; + dp-dsi0-connector { compatible = "dp-connector"; label = "DSI0"; @@ -423,6 +437,15 @@ &mdss { status = "okay"; }; +&mdss_dp0 { + status = "okay"; +}; + +&mdss_dp0_out { + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000>; + remote-endpoint = <&dp0_connector_in>; +}; + &mdss_dsi0 { vdda-supply = <&vreg_l11a>; status = "okay"; @@ -623,6 +646,13 @@ &usb_qmpphy { status = "okay"; }; +&usb_qmpphy_2 { + vdda-phy-supply = <&vreg_l5a>; + vdda-pll-supply = <&vreg_l12a>; + + status = "okay"; +}; + &usb_1 { status = "okay"; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
end of thread, other threads:[~2025-10-30 18:23 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-10-24 5:21 [PATCH v6 0/4] Add DisplayPort support to QCS615 devicetree Xiangxu Yin via B4 Relay 2025-10-24 5:21 ` [PATCH v6 1/4] dt-bindings: display: msm: Add SM6150 DisplayPort controller Xiangxu Yin via B4 Relay 2025-10-27 15:26 ` Rob Herring 2025-10-28 5:06 ` Xiangxu Yin 2025-10-28 19:57 ` Dmitry Baryshkov 2025-10-29 8:51 ` Xiangxu Yin 2025-10-27 18:54 ` Bjorn Andersson 2025-10-28 5:16 ` Xiangxu Yin 2025-10-28 19:58 ` Dmitry Baryshkov 2025-10-24 5:21 ` [PATCH v6 2/4] dt-bindings: display: msm: sm6150-mdss: Fix example indentation and OPP values Xiangxu Yin via B4 Relay 2025-10-27 15:24 ` Rob Herring (Arm) 2025-10-28 20:00 ` Dmitry Baryshkov 2025-10-29 9:59 ` Xiangxu Yin 2025-10-24 5:21 ` [PATCH v6 3/4] arm64: dts: qcom: Add DisplayPort and QMP USB3DP PHY for SM6150 Xiangxu Yin via B4 Relay 2025-10-29 17:32 ` Bjorn Andersson 2025-10-30 7:21 ` Xiangxu Yin 2025-10-30 18:26 ` Bjorn Andersson 2025-10-24 5:21 ` [PATCH v6 4/4] arm64: dts: qcom: qcs615-ride: Enable DisplayPort Xiangxu Yin via B4 Relay
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox