From: Bjorn Helgaas <helgaas@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: "Manivannan Sadhasivam" <mani@kernel.org>,
linux-pci@vger.kernel.org,
"Manivannan Sadhasivam" <manivannan.sadhasivam@oss.qualcomm.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Frank Li" <Frank.li@nxp.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Rob Herring" <robh@kernel.org>,
"David E . Box" <david.e.box@linux.intel.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Chia-Lin Kao" <acelan.kao@canonical.com>,
"Gustavo Pimentel" <Gustavo.Pimentel@synopsys.com>,
"Han Jingoo" <jingoohan1@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH] Revert "PCI: qcom: Remove custom ASPM enablement code"
Date: Mon, 27 Oct 2025 17:35:17 -0500 [thread overview]
Message-ID: <20251027223517.GA1484052@bhelgaas> (raw)
In-Reply-To: <aP9Ed1Y1lcayFn7Q@hovoldconsulting.com>
On Mon, Oct 27, 2025 at 11:07:51AM +0100, Johan Hovold wrote:
> On Sun, Oct 26, 2025 at 02:37:54PM -0500, Bjorn Helgaas wrote:
> > On Sun, Oct 26, 2025 at 08:58:29PM +0530, Manivannan Sadhasivam wrote:
>
> > As far as I know, it's L1SS that has catastrophic effects. I haven't
> > seen anything for L0s or L1.
>
> Enabling L0s unconditionally certainly blew up on some Qualcomm
> machines. See commit d1997c987814 ("PCI: qcom: Disable ASPM L0s for
> sc8280xp, sa8540p and sa8295p").
Ah, right, thanks for that reminder.
IIUC the qcom_pcie_clear_aspm_l0s() quirk that removes L0s from the
advertised Link Capabilities is still there and prevents df5192d9bb0e
("PCI/ASPM: Enable only L0s and L1 for devicetree platforms") from
being a problem on those platforms, right?
next prev parent reply other threads:[~2025-10-27 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 21:04 [PATCH] Revert "PCI: qcom: Remove custom ASPM enablement code" Bjorn Helgaas
2025-10-26 15:28 ` Manivannan Sadhasivam
2025-10-26 19:37 ` Bjorn Helgaas
2025-10-27 10:07 ` Johan Hovold
2025-10-27 22:35 ` Bjorn Helgaas [this message]
2025-10-28 5:01 ` Manivannan Sadhasivam
2025-10-27 11:51 ` Manivannan Sadhasivam
2025-10-27 23:07 ` Bjorn Helgaas
2025-10-28 5:33 ` Manivannan Sadhasivam
2025-10-27 11:58 ` Manivannan Sadhasivam
2025-10-27 13:25 ` Johan Hovold
2025-10-27 23:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251027223517.GA1484052@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.li@nxp.com \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=acelan.kao@canonical.com \
--cc=andersson@kernel.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=david.e.box@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=johan@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox