public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Maciej Strozek <mstrozek@opensource.cirrus.com>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: sound: Increase max size of components field
Date: Tue, 28 Oct 2025 09:42:52 +0900	[thread overview]
Message-ID: <20251028004252.GA553484@workstation.local> (raw)
In-Reply-To: <3cb73dae8e8ac1a29c856dc5c86064d568003316.camel@opensource.cirrus.com>

Hi,

On Mon, Oct 27, 2025 at 11:50:32AM +0000, Maciej Strozek wrote:
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index c302698fb685..7d53f6da59e2 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -1069,7 +1069,12 @@ struct snd_ctl_card_info {
>         unsigned char longname[80];
>         unsigned char reserved_[16];
>         unsigned char mixername[80];
> -       unsigned char components[256];
> +       unsigned char components[128];
> +};

Any approach to change the result of 'sizeof(struct snd_ctl_card_info)'
breaks ABI to userspace application. This is the reason that Jaroslav
addresses to the new PCM ioctl command. Unless, the userspace
application build with the UAPI header provided by the existing version
of Linux kernel does not work as expected in your version of Linux
kernel, in respect to the sound subsystem.


Regards

Takashi Sakamoto

  parent reply	other threads:[~2025-10-28  0:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-23  9:27 [PATCH] ALSA: sound: Increase max size of components field Maciej Strozek
2025-10-23 11:56 ` Jaroslav Kysela
2025-10-27  9:04   ` Takashi Iwai
2025-10-27 11:50     ` Maciej Strozek
2025-10-27 12:32       ` Richard Fitzgerald
2025-10-28  0:42       ` Takashi Sakamoto [this message]
2025-10-28 11:14         ` Maciej Strozek
2025-10-28 11:39       ` Jaroslav Kysela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251028004252.GA553484@workstation.local \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox