* [PATCH] tpm_crb: add missing loc parameter to kerneldoc
@ 2025-10-28 2:09 Stuart Yoder
2025-11-09 4:41 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Stuart Yoder @ 2025-10-28 2:09 UTC (permalink / raw)
To: linux-integrity, jarkko, peterhuewe, jgg, sudeep.holla
Cc: Prachotan.Bathi, linux-kernel
Update the kerneldoc parameter definitions for __crb_go_idle
and __crb_cmd_ready to include the loc parameter.
Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
---
drivers/char/tpm/tpm_crb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index c75a531cfb98..0eb48429f73d 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -179,6 +179,7 @@ static int crb_try_pluton_doorbell(struct crb_priv *priv, bool wait_for_complete
*
* @dev: crb device
* @priv: crb private data
+ * @loc: locality
*
* Write CRB_CTRL_REQ_GO_IDLE to TPM_CRB_CTRL_REQ
* The device should respond within TIMEOUT_C by clearing the bit.
@@ -233,6 +234,7 @@ static int crb_go_idle(struct tpm_chip *chip)
*
* @dev: crb device
* @priv: crb private data
+ * @loc: locality
*
* Write CRB_CTRL_REQ_CMD_READY to TPM_CRB_CTRL_REQ
* and poll till the device acknowledge it by clearing the bit.
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tpm_crb: add missing loc parameter to kerneldoc
2025-10-28 2:09 [PATCH] tpm_crb: add missing loc parameter to kerneldoc Stuart Yoder
@ 2025-11-09 4:41 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2025-11-09 4:41 UTC (permalink / raw)
To: Stuart Yoder
Cc: linux-integrity, peterhuewe, jgg, sudeep.holla, Prachotan.Bathi,
linux-kernel
On Mon, Oct 27, 2025 at 09:09:21PM -0500, Stuart Yoder wrote:
> Update the kerneldoc parameter definitions for __crb_go_idle
> and __crb_cmd_ready to include the loc parameter.
>
> Signed-off-by: Stuart Yoder <stuart.yoder@arm.com>
> ---
> drivers/char/tpm/tpm_crb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
> index c75a531cfb98..0eb48429f73d 100644
> --- a/drivers/char/tpm/tpm_crb.c
> +++ b/drivers/char/tpm/tpm_crb.c
> @@ -179,6 +179,7 @@ static int crb_try_pluton_doorbell(struct crb_priv *priv, bool wait_for_complete
> *
> * @dev: crb device
> * @priv: crb private data
> + * @loc: locality
> *
> * Write CRB_CTRL_REQ_GO_IDLE to TPM_CRB_CTRL_REQ
> * The device should respond within TIMEOUT_C by clearing the bit.
> @@ -233,6 +234,7 @@ static int crb_go_idle(struct tpm_chip *chip)
> *
> * @dev: crb device
> * @priv: crb private data
> + * @loc: locality
> *
> * Write CRB_CTRL_REQ_CMD_READY to TPM_CRB_CTRL_REQ
> * and poll till the device acknowledge it by clearing the bit.
> --
> 2.34.1
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-09 4:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-28 2:09 [PATCH] tpm_crb: add missing loc parameter to kerneldoc Stuart Yoder
2025-11-09 4:41 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox