From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: akpm@linux-foundation.org, lpieralisi@kernel.org, nico@fluxnic.net
Cc: jserv@ccns.ncku.edu.tw, marscheng@google.com, wllee@google.com,
linux-kernel@vger.kernel.org,
Kuan-Wei Chiu <visitorckw@gmail.com>
Subject: [PATCH] bus: arm-cci: Fix device node leak in cci_probe_ports()
Date: Tue, 28 Oct 2025 17:18:24 +0000 [thread overview]
Message-ID: <20251028171824.2074625-1-visitorckw@gmail.com> (raw)
The coccicheck tool reported the following warning:
./drivers/bus/arm-cci.c:458:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 465.
The for_each_available_child_of_node() loop increments the reference
count of the device node. A call to of_node_put() is required before
breaking out of the loop to avoid a reference leak.
Add the missing of_node_put() call to fix the leak.
Fixes: ed69bdd8fd9b ("drivers: bus: add ARM CCI support")
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
---
Compile test only.
drivers/bus/arm-cci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
index b8184a903583..1f84a5528073 100644
--- a/drivers/bus/arm-cci.c
+++ b/drivers/bus/arm-cci.c
@@ -461,8 +461,10 @@ static int cci_probe_ports(struct device_node *np)
i = nb_ace + nb_ace_lite;
- if (i >= nb_cci_ports)
+ if (i >= nb_cci_ports) {
+ of_node_put(cp);
break;
+ }
if (of_property_read_string(cp, "interface-type",
&match_str)) {
--
2.51.1.851.g4ebd6896fd-goog
reply other threads:[~2025-10-28 17:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028171824.2074625-1-visitorckw@gmail.com \
--to=visitorckw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marscheng@google.com \
--cc=nico@fluxnic.net \
--cc=wllee@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox