From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <wagi@kernel.org>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
John Meneghini <jmeneghi@redhat.com>,
Bryan Gurney <bgurney@redhat.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Daniel Wagner <dwagner@suse.de>
Subject: Re: [PATCH] nvme: drop bogus nid quirk for multipath devices which passed id test
Date: Wed, 29 Oct 2025 08:44:03 +0100 [thread overview]
Message-ID: <20251029074403.GA30412@lst.de> (raw)
In-Reply-To: <20251028-bogus-id-check-v1-1-c087a98b5466@kernel.org>
On Tue, Oct 28, 2025 at 01:54:56PM +0100, Daniel Wagner wrote:
> Obviously, using the correct IDs is really hard. There are at least two devices
> which share a the device id and one needs the bogus id workaround the other
> doesn't.
>
> We discussed the idea to pass through configuration from the kernel command line
> at ALPSS. I am not sure, how far we got with this yet. What about something like
> this here?
The Intel devices are dual ported and multipath cabable, too. Which
isn't surprising at the dell one is just an OEM version of them.
But more imporantly dropping the quirk for multipath devices is
fundamentally the wrong thing to do, as we really need proper IDs for
multipathing. So just add another entry for the Dell device using
the dell subvendor/subdevice id that does not have the quirk.
next prev parent reply other threads:[~2025-10-29 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 12:54 [PATCH] nvme: drop bogus nid quirk for multipath devices which passed id test Daniel Wagner
2025-10-29 7:44 ` Christoph Hellwig [this message]
2025-10-29 9:45 ` Daniel Wagner
2025-10-29 9:59 ` Christoph Hellwig
2025-10-29 10:14 ` Daniel Wagner
2025-10-29 13:38 ` Christoph Hellwig
2025-11-05 7:33 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251029074403.GA30412@lst.de \
--to=hch@lst.de \
--cc=bgurney@redhat.com \
--cc=dwagner@suse.de \
--cc=jmeneghi@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox