From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72FEF3321D4; Wed, 29 Oct 2025 10:39:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761734386; cv=none; b=Hdxn2Qz9XviQS76fWRx5CEr/fxPEgR5QlVLWFFp/NgadLRuCRvFuOqvjEurPUjiXH//rpn9kUn8QaqyTxUb2polYKFVuwYiY93gxFDubTL2x+n+T7gY5jiWHqpt9+1HqcmPhPYw6TBWWDgX20LqQaKwK2BeVugHzquih48y/SMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761734386; c=relaxed/simple; bh=fQ1ZZOwoZHcyHhHjmvXHNheScD5+PKiSXtlfj+ifs1w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PfWWnpA8qnV+emlcvfwDdCoBmm8pRfSHTTwcweD/RIbq2SaMDeFg6qGdGoJXvlZf7MTh9CaBSRdYD1yzdABK6t0xNO6IXkHhmYFrzc5gyKaaYc/DSQWczGnfuYf261Xk/BasMJmiGOjLHtSWHpoR0CFmOkQFCJmVLEXo2slKUu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=cCXLWuOm; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="cCXLWuOm" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 9C8A14E413BB; Wed, 29 Oct 2025 10:39:41 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 71CBB606E8; Wed, 29 Oct 2025 10:39:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 09BDF117F2875; Wed, 29 Oct 2025 11:39:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761734380; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=kZUu6u0wS/jzGzdskNddkgJJVZ/zUOBXcp7YDEWrGzU=; b=cCXLWuOmhtnXCME378SD2JQmZ9xc/7GArt0Ev2MulE9BiAetQ/bWt8OiSIJ/dP2joCxafq 89QX752TatfoKXx1MAhJW0iDyT+24HvM09VK8OEXdell//K7pNrTIWAwuC3UXRBBe8KpVk lW1fVwyOm0w2wMNqpRhfeAdmqKBZh4A7cMWyVJll59MmzTGpxrQ2j/9RgAFHnn/ceslGhW eq91FHU0eO265JvjO+phla676d+wiYJ2w6TOQ3HYQTmEKd2MSVEiYqhzJMIMKFWHDBVydH 2BclGKojql2K0e0UVKHoDTz6quFI/UL3VLtaV36g0Vvxe87dpaf411rPignZWw== Date: Wed, 29 Oct 2025 11:39:38 +0100 From: Alexandre Belloni To: Jon Hunter Cc: Esben Haabendal , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-tegra@vger.kernel.org" Subject: Re: [PATCH v2 4/5] rtc: tps6586x: Fix initial enable_irq/disable_irq balance Message-ID: <2025102910393819d18ad0@mail.local> References: <20250516-rtc-uie-irq-fixes-v2-0-3de8e530a39e@geanix.com> <20250516-rtc-uie-irq-fixes-v2-4-3de8e530a39e@geanix.com> <0aae5643-9276-4280-8b1e-27b8fe73fe99@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0aae5643-9276-4280-8b1e-27b8fe73fe99@nvidia.com> X-Last-TLS-Session-Version: TLSv1.3 On 29/10/2025 09:20:17+0000, Jon Hunter wrote: > Hi Esben, > > On 16/05/2025 08:23, Esben Haabendal wrote: > > Interrupts are automatically enabled when requested, so we need to > > initialize irq_en accordingly to avoid causing an unbalanced enable > > warning. > > > > Signed-off-by: Esben Haabendal > > --- > > drivers/rtc/rtc-tps6586x.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/rtc/rtc-tps6586x.c b/drivers/rtc/rtc-tps6586x.c > > index 54c8429b16bfcc692b1f4d5404f0c42f720e93b4..76ecf7b798f0de22aa89a552a263b473ab3065ef 100644 > > --- a/drivers/rtc/rtc-tps6586x.c > > +++ b/drivers/rtc/rtc-tps6586x.c > > @@ -258,6 +258,7 @@ static int tps6586x_rtc_probe(struct platform_device *pdev) > > irq_set_status_flags(rtc->irq, IRQ_NOAUTOEN); > > + rtc->irq_en = true; > > ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL, > > tps6586x_rtc_irq, > > IRQF_ONESHOT, > > > > I have bisected a suspend regression on one of our Tegra20 boards (that uses > this driver) and bisect is pointing to this commit. Reverting this commit > fixes the problem. > > Looking at the above I see that the flag IRQ_NOAUTOEN is being set and so > now with your change we never enable the interrupt. Hence, the wake-ups are > now broken and suspend testing fails. So it would seem best to revert this. > > BTW, I looked at the change to the CPCAP driver and that driver actively > disables the IRQ after requesting it and so I am wondering if that will also > have alarm issues? I don't have a board with CPCAP to test. > That's right, I guess you can send reverts. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com