From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7357351FA6 for ; Thu, 30 Oct 2025 10:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761819920; cv=none; b=BumOXoeU3dPkpeeHz1Gmw+N6itnD9sA4d/DbNcoSiNkJLv7FRa8B04rKWHrXj2/aVpM678gM0j1aAsiAHYHGhs9KHDIQhdgJBh1BaoEbb1VQJT8/rTBihvS5asBNi5iG/mlJ6pM4OqSUMf+q9uPwfxByV1FSErm5yO3ApvHjr6o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761819920; c=relaxed/simple; bh=/OiTwmyjWBCx0q96Gsr9SY27ybAo0GLz8Cev2v1IhyU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n2aTYjeXX17n/xCM3LI+AoeCrmRtcLpd8hY1bH9bT8lY72HNXWZjIa5/0QqKm7yqqH6V1zM+82nv+qhykA+VG6R5GSkpiCUUW7N1RYU9ehYrP7z4HChkV3cF92Pk1Apwty03z5HjGQ/EwFGPLFr93tIrvh5L7fHOP7BBlsVm/s8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=MNEEIXp3; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="MNEEIXp3" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b3c82276592so15106366b.3 for ; Thu, 30 Oct 2025 03:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761819915; x=1762424715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lTgIsc3O+wDypaKqBlwZIo86kBPQGfr40arZuVCJ75M=; b=MNEEIXp3U3e0BlWXVNtco0TH/amTu+TWkWbkMT7o3svpJoWGHknjv0tQvlPVZErEpb gttDBZ8rFQUqABpCwyEN46K67Dy70sW3C2i7qddNytI8b38Bsa2naTSVzL2l27CGHhAc IZa6tvQeQsVLiSlDH/LYcokupeT96buvLXhSAECt1EtD5IrHWHuAquKgCRdMvpLYxDKy nBBckInWtiGQZvPlCGpnEw8FdtKP09FrBU++uDTRIXmZ/Hjj0nKSPRen4hNJZqQ1OMYb HMLQrFZvSOfO3nOwZ+oaMtPsh9hHwmvU0DjntMRJf9wjMq/z6zjXb374d+BXtFsqSwOu dXxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761819915; x=1762424715; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lTgIsc3O+wDypaKqBlwZIo86kBPQGfr40arZuVCJ75M=; b=ngrBn//DB0v3nupf82LIBCW/jjAoIjM67Kfm7HvQg58YiqAEKorNcurzK5cLAWwweK MHXb6e81eS1G1nSFqY4fVVfyc7AOWwC5EahLNI8Fo3tZ81o+fx11C80bZ3lih749wofJ OdMjaoBN0gc6nH3o0ag0f24A9Jt9b2LgjL7q8ch0EPzIUnQ8c7MGzpwOc5vOLMjDFpcS PtLAEoqk/5N/yN/KNLFFVIcIm761XlJqQ84D9lp6y/roQ5JGqEYP04oLzxh/iUd+vTA8 LfQWCz6bohI/vo14vuHTDYzJuM/qxJiaD3m1vEr2RCSlrN8BZbdmRmEp0XkF3bz7j1Us li2A== X-Gm-Message-State: AOJu0YzNZIQTgzbS/5jBy/PrjOeC4CqWJDY4U5tAbseOOBnfhgfJuP1V 9dEjR7ArOgdrZrAjktqPg/3wr/jvI1zyGtTH1/a0nS620uOQEbMkHh/VswwOmdO+PDA= X-Gm-Gg: ASbGnctEk+eIQQib2O2BZ83i2EHezJF7umnP8lWGysSo+HQ44DVKi/qs0nDel20CCTG 52jVcCcsfbFsbtQ922ioVc2j4qYCxmll7PqrhrD9ifOqtaiAJQVVqNPAoEUfUaYnMMXBLRRj/Ab 8l56lp43Ha8nQfHoLMP4v7or6EzBM44Esur4olGVm5mGy2nuBgDFWbBkrg5Fg6rV8x5As3n6WV+ bTB0GhqEQguEZ0SH1JfvRFXBzY1NOWhVa5OlWFR7tc7ow9Ri8PzMPlBv97/v8+MJ3ZMlUd4ckVA yZq7qarqCCVk8IVLNkQeNhDEdzG51tN5I2fBsgawd8PY6Y+F7w3SF5y0zT46zT/QfLcA2QJk/Ca LIAx3cx2W7oMdj3cByvJqkmWKZ4AtGfSDfNgQjO1ccGOrfDshgVCgPRUhwLHBb/ao8CAj5zlU0g kn3f/utOK+OIEjQWp8yxg9REioJ0qKuFyUibHGy9MQCAJziuJ61E9F7e2Wa+4A2HI9DYTsT4c4g yiL X-Google-Smtp-Source: AGHT+IEXsUOIqP3MBMqvuO3EOkZU6BKA34oP58piwLuVoouucxjytl3skX6Ka8nntE+ckkHO79CK6A== X-Received: by 2002:a17:906:f586:b0:b6d:5439:e668 with SMTP id a640c23a62f3a-b703d55e454mr372826866b.8.1761819915166; Thu, 30 Oct 2025 03:25:15 -0700 (PDT) Received: from mordecai (dynamic-2a00-1028-83b8-1e7a-3010-3bd6-8521-caf1.ipv6.o2.cz. [2a00:1028:83b8:1e7a:3010:3bd6:8521:caf1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b6d853c549fsm1728375066b.37.2025.10.30.03.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Oct 2025 03:25:14 -0700 (PDT) Date: Thu, 30 Oct 2025 11:25:03 +0100 From: Petr Tesarik To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, rcu@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Josh Poimboeuf , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Arnaldo Carvalho de Melo , Paolo Bonzini , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Sami Tolvanen , "David S. Miller" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Mel Gorman , Andrew Morton , Masahiro Yamada , Han Shen , Rik van Riel , Jann Horn , Dan Carpenter , Oleg Nesterov , Juri Lelli , Clark Williams , Yair Podemsky , Marcelo Tosatti , Daniel Wagner Subject: Re: [PATCH v6 06/29] static_call: Add read-only-after-init static calls Message-ID: <20251030112251.5afcf9ed@mordecai> In-Reply-To: <20251010153839.151763-7-vschneid@redhat.com> References: <20251010153839.151763-1-vschneid@redhat.com> <20251010153839.151763-7-vschneid@redhat.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.50; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 10 Oct 2025 17:38:16 +0200 Valentin Schneider wrote: > From: Josh Poimboeuf > > Deferring a code patching IPI is unsafe if the patched code is in a > noinstr region. In that case the text poke code must trigger an > immediate IPI to all CPUs, which can rudely interrupt an isolated NO_HZ > CPU running in userspace. > > If a noinstr static call only needs to be patched during boot, its key > can be made ro-after-init to ensure it will never be patched at runtime. > > Signed-off-by: Josh Poimboeuf > --- > include/linux/static_call.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/include/linux/static_call.h b/include/linux/static_call.h > index 78a77a4ae0ea8..ea6ca57e2a829 100644 > --- a/include/linux/static_call.h > +++ b/include/linux/static_call.h > @@ -192,6 +192,14 @@ extern long __static_call_return0(void); > }; \ > ARCH_DEFINE_STATIC_CALL_TRAMP(name, _func) > > +#define DEFINE_STATIC_CALL_RO(name, _func) \ > + DECLARE_STATIC_CALL(name, _func); \ > + struct static_call_key __ro_after_init STATIC_CALL_KEY(name) = {\ > + .func = _func, \ > + .type = 1, \ > + }; \ > + ARCH_DEFINE_STATIC_CALL_TRAMP(name, _func) > + > #define DEFINE_STATIC_CALL_NULL(name, _func) \ > DECLARE_STATIC_CALL(name, _func); \ > struct static_call_key STATIC_CALL_KEY(name) = { \ > @@ -200,6 +208,14 @@ extern long __static_call_return0(void); > }; \ > ARCH_DEFINE_STATIC_CALL_NULL_TRAMP(name) > > +#define DEFINE_STATIC_CALL_NULL_RO(name, _func) \ > + DECLARE_STATIC_CALL(name, _func); \ > + struct static_call_key __ro_after_init STATIC_CALL_KEY(name) = {\ > + .func = NULL, \ > + .type = 1, \ > + }; \ > + ARCH_DEFINE_STATIC_CALL_NULL_TRAMP(name) > + I think it would be a good idea to add a comment describing when these macros are supposed to be used, similar to the explanation you wrote for the _NOINSTR variants. Just to provide a clue for people adding a new static key in the future, because the commit message may become a bit hard to find if there are a few cleanup patches on top. Just my two cents, Petr T